Steve973 opened a new pull request, #11906:
URL: https://github.com/apache/camel/pull/11906
Utilize the multicast processor in the dynamic router, rather than rolling
an entirely new implementation.
# Target
- [ X ] I checked that the commit is targeting the correct branch (not
github-actions[bot] commented on PR #11906:
URL: https://github.com/apache/camel/pull/11906#issuecomment-1793480740
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committer
Steve973 commented on PR #11906:
URL: https://github.com/apache/camel/pull/11906#issuecomment-1793794431
@davsclaus I build this and it isn't showing any uncommitted changes
afterward. I am running `./mvnw -Dquickly install`. Is there something that I
am missing?
--
This is an automate
davsclaus commented on PR #11906:
URL: https://github.com/apache/camel/pull/11906#issuecomment-1793796118
You can revert your change in `camel-spring.xsd` file so its not part of the
commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
davsclaus commented on code in PR #11906:
URL: https://github.com/apache/camel/pull/11906#discussion_r1382909044
##
components/camel-dynamic-router/src/main/java/org/apache/camel/component/dynamicrouter/DynamicRouterControlChannelProcessor.java:
##
@@ -156,20 +157,22 @@ DynamicR
orpiske commented on code in PR #11906:
URL: https://github.com/apache/camel/pull/11906#discussion_r1383095951
##
components/camel-dynamic-router/src/main/java/org/apache/camel/component/dynamicrouter/DynamicRouterEndpoint.java:
##
@@ -140,30 +149,87 @@ protected void doInit() t
Steve973 commented on code in PR #11906:
URL: https://github.com/apache/camel/pull/11906#discussion_r1383880403
##
components/camel-dynamic-router/pom.xml:
##
@@ -69,4 +69,23 @@
test
+
+
Review Comment:
I am really not sure what I was doing there, so I wil
Steve973 commented on code in PR #11906:
URL: https://github.com/apache/camel/pull/11906#discussion_r1383883485
##
components/camel-dynamic-router/src/main/java/org/apache/camel/component/dynamicrouter/DynamicRouterControlChannelProcessor.java:
##
@@ -156,20 +157,22 @@ DynamicRo
Steve973 commented on code in PR #11906:
URL: https://github.com/apache/camel/pull/11906#discussion_r1383891428
##
components/camel-dynamic-router/src/main/java/org/apache/camel/component/dynamicrouter/DynamicRouterControlChannelProcessor.java:
##
@@ -156,20 +157,22 @@ DynamicRo
Steve973 commented on code in PR #11906:
URL: https://github.com/apache/camel/pull/11906#discussion_r1383896298
##
components/camel-dynamic-router/src/main/java/org/apache/camel/component/dynamicrouter/DynamicRouterControlChannelProcessor.java:
##
@@ -156,20 +157,22 @@ DynamicRo
Steve973 commented on code in PR #11906:
URL: https://github.com/apache/camel/pull/11906#discussion_r1383897845
##
components/camel-dynamic-router/src/main/java/org/apache/camel/component/dynamicrouter/DynamicRouterControlChannelProcessor.java:
##
@@ -156,20 +157,22 @@ DynamicRo
Steve973 commented on code in PR #11906:
URL: https://github.com/apache/camel/pull/11906#discussion_r1383903186
##
components/camel-dynamic-router/src/main/java/org/apache/camel/component/dynamicrouter/DynamicRouterEndpoint.java:
##
@@ -140,30 +149,87 @@ protected void doInit()
Steve973 commented on code in PR #11906:
URL: https://github.com/apache/camel/pull/11906#discussion_r1383908302
##
components/camel-dynamic-router/src/main/java/org/apache/camel/component/dynamicrouter/DynamicRouterMulticastProcessor.java:
##
@@ -0,0 +1,292 @@
+/*
+ * Licensed t
Steve973 commented on code in PR #11906:
URL: https://github.com/apache/camel/pull/11906#discussion_r1383909412
##
components/camel-dynamic-router/src/main/java/org/apache/camel/component/dynamicrouter/DynamicRouterEndpoint.java:
##
@@ -16,21 +16,26 @@
*/
package org.apache.c
Steve973 commented on code in PR #11906:
URL: https://github.com/apache/camel/pull/11906#discussion_r1383920063
##
components/camel-dynamic-router/src/main/java/org/apache/camel/component/dynamicrouter/DynamicRouterEndpoint.java:
##
@@ -140,30 +149,87 @@ protected void doInit()
Steve973 commented on code in PR #11906:
URL: https://github.com/apache/camel/pull/11906#discussion_r1383946530
##
components/camel-dynamic-router/src/main/java/org/apache/camel/component/dynamicrouter/DynamicRouterEndpoint.java:
##
@@ -140,30 +149,87 @@ protected void doInit()
Steve973 commented on code in PR #11906:
URL: https://github.com/apache/camel/pull/11906#discussion_r1383951383
##
components/camel-dynamic-router/src/main/java/org/apache/camel/component/dynamicrouter/DynamicRouterEndpoint.java:
##
@@ -140,30 +149,87 @@ protected void doInit()
Steve973 commented on code in PR #11906:
URL: https://github.com/apache/camel/pull/11906#discussion_r1383983952
##
components/camel-dynamic-router/src/main/java/org/apache/camel/component/dynamicrouter/DynamicRouterMulticastProcessor.java:
##
@@ -0,0 +1,292 @@
+/*
+ * Licensed t
Steve973 commented on code in PR #11906:
URL: https://github.com/apache/camel/pull/11906#discussion_r1383984723
##
components/camel-dynamic-router/src/main/java/org/apache/camel/component/dynamicrouter/DynamicRouterMulticastProcessor.java:
##
@@ -0,0 +1,292 @@
+/*
+ * Licensed t
Steve973 commented on PR #11906:
URL: https://github.com/apache/camel/pull/11906#issuecomment-1796443920
Thank you, @davsclaus and @orpiske for taking the time to look over the code
and offer comments. If I see any more comments, I'll be glad to make the
changes for round 2.
--
This is
orpiske commented on PR #11906:
URL: https://github.com/apache/camel/pull/11906#issuecomment-1798147244
> Thank you, @davsclaus and @orpiske for taking the time to look over the
code and offer comments. If I see any more comments, I'll be glad to make the
changes for round 2.
Thanks
davsclaus commented on code in PR #11906:
URL: https://github.com/apache/camel/pull/11906#discussion_r1384698132
##
components/camel-dynamic-router/src/main/java/org/apache/camel/component/dynamicrouter/DynamicRouterEndpoint.java:
##
@@ -140,30 +152,90 @@ protected void doInit()
Steve973 commented on code in PR #11906:
URL: https://github.com/apache/camel/pull/11906#discussion_r1385768284
##
components/camel-dynamic-router/src/main/java/org/apache/camel/component/dynamicrouter/DynamicRouterConfiguration.java:
##
@@ -131,6 +129,103 @@ public class Dynami
Steve973 commented on code in PR #11906:
URL: https://github.com/apache/camel/pull/11906#discussion_r1385771372
##
components/camel-dynamic-router/src/main/java/org/apache/camel/component/dynamicrouter/DynamicRouterConfiguration.java:
##
@@ -131,6 +129,103 @@ public class Dynami
Steve973 commented on code in PR #11906:
URL: https://github.com/apache/camel/pull/11906#discussion_r1385771372
##
components/camel-dynamic-router/src/main/java/org/apache/camel/component/dynamicrouter/DynamicRouterConfiguration.java:
##
@@ -131,6 +129,103 @@ public class Dynami
Steve973 commented on code in PR #11906:
URL: https://github.com/apache/camel/pull/11906#discussion_r1385778185
##
components/camel-dynamic-router/src/main/java/org/apache/camel/component/dynamicrouter/DynamicRouterEndpoint.java:
##
@@ -140,30 +152,90 @@ protected void doInit()
orpiske commented on PR #11906:
URL: https://github.com/apache/camel/pull/11906#issuecomment-1801239302
Last build had 3 failures on my CI (which I consider pretty good).
* MapJmsMessageTest.testTextMessage org.apache.camel.component.jms
* JettyJmsShutdownInProgressTest.testShutdow
davsclaus commented on code in PR #11906:
URL: https://github.com/apache/camel/pull/11906#discussion_r1386892009
##
components/camel-dynamic-router/src/main/java/org/apache/camel/component/dynamicrouter/DynamicRouterConfiguration.java:
##
@@ -131,6 +129,103 @@ public class Dynam
davsclaus commented on PR #11906:
URL: https://github.com/apache/camel/pull/11906#issuecomment-1803738327
This is a too big PR to do good review and there is too much nit picking
already.
Can you add a section to the 4.2 upgrade guide doc about changes in this
component so users sho
davsclaus commented on PR #11906:
URL: https://github.com/apache/camel/pull/11906#issuecomment-1803739563
And can you include the files that was updated but not included in the PR
(see the error)
atalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/components/dynamic-rou
davsclaus commented on PR #11906:
URL: https://github.com/apache/camel/pull/11906#issuecomment-1803908992
@Steve973 a heads up that we want to be ready tomorrow for the 4.2 release.
Not sure if you have time to cleanup the last bits, and include the uncommited
code, so the CI can do a build
Steve973 commented on code in PR #11906:
URL: https://github.com/apache/camel/pull/11906#discussion_r1388604668
##
components/camel-dynamic-router/src/main/java/org/apache/camel/component/dynamicrouter/DynamicRouterConfiguration.java:
##
@@ -131,6 +129,103 @@ public class Dynami
Steve973 commented on PR #11906:
URL: https://github.com/apache/camel/pull/11906#issuecomment-1804718712
> @Steve973 a heads up that we want to be ready tomorrow for the 4.2
release. Not sure if you have time to cleanup the last bits, and include the
uncommited code, so the CI can do a buil
Steve973 commented on code in PR #11906:
URL: https://github.com/apache/camel/pull/11906#discussion_r1388616690
##
components/camel-dynamic-router/src/main/java/org/apache/camel/component/dynamicrouter/DynamicRouterEndpoint.java:
##
@@ -16,21 +16,26 @@
*/
package org.apache.c
Steve973 commented on PR #11906:
URL: https://github.com/apache/camel/pull/11906#issuecomment-1804734252
> Last build had 3 failures on my CI (which I consider pretty good).
>
> * MapJmsMessageTest.testTextMessage org.apache.camel.component.jms
> * JettyJmsShutdownInProgressTest.tes
davsclaus merged PR #11906:
URL: https://github.com/apache/camel/pull/11906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.ap
orpiske commented on PR #11906:
URL: https://github.com/apache/camel/pull/11906#issuecomment-1805324163
> > Last build had 3 failures on my CI (which I consider pretty good).
> >
> > * MapJmsMessageTest.testTextMessage org.apache.camel.component.jms
> > * JettyJmsShutdownInProgressT
davsclaus commented on PR #11906:
URL: https://github.com/apache/camel/pull/11906#issuecomment-1805325989
this component is isolated and not used anywhere else at all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
orpiske commented on PR #11906:
URL: https://github.com/apache/camel/pull/11906#issuecomment-1805336886
> this component is isolated and not used anywhere else at all
Wouldn't this be tested by core? I was under the impression we had some
tests for it on `core`.
--
This is an auto
orpiske commented on PR #11906:
URL: https://github.com/apache/camel/pull/11906#issuecomment-1805338244
Anyway, if it's isolated we should be fine!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
davsclaus commented on PR #11906:
URL: https://github.com/apache/camel/pull/11906#issuecomment-1805338725
> > this component is isolated and not used anywhere else at all
>
> Wouldn't this be tested by core? I was under the impression we had some
tests for it on `core`.
No its
orpiske commented on PR #11906:
URL: https://github.com/apache/camel/pull/11906#issuecomment-1805340689
Awesome. Thanks for the clarification @davsclaus!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
42 matches
Mail list logo
