davsclaus commented on PR #13082:
URL: https://github.com/apache/camel/pull/13082#issuecomment-1948197139
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
cziesman commented on PR #13082:
URL: https://github.com/apache/camel/pull/13082#issuecomment-1947336180
I renamed the Salesforce integration tests to *ManualIT.java to match the
naming convention for other Camel manual integration tests. I also disabled
execution by `mvn verify` unless
cziesman commented on PR #13082:
URL: https://github.com/apache/camel/pull/13082#issuecomment-1942136931
I looked at the POM for the Salesforce component and the incremental build
log. I don't think the name change was responsible for the build failures. I
think that any code change would
cziesman commented on PR #13082:
URL: https://github.com/apache/camel/pull/13082#issuecomment-1939448176
@davsclaus There are many integration tests that require external resources,
not just the Salesforce tests. This will obviously cause test failures because
most people won't have the
davsclaus commented on PR #13082:
URL: https://github.com/apache/camel/pull/13082#issuecomment-1938299492
You cannot run the salesforce integrations tests automatically. You need to
setup a real account and more, see the readme file.
--
This is an automated message from the
cziesman commented on PR #13082:
URL: https://github.com/apache/camel/pull/13082#issuecomment-1937825419
@orpiske Good catch on the pom.xml changes! I have updated them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
orpiske commented on PR #13082:
URL: https://github.com/apache/camel/pull/13082#issuecomment-1936960501
> Otavio do you mean that some of the component have customized
configuration for failsafe-plugin in their pom? It seems so as if you do a git
grep failsafe-plugin then there are about
orpiske commented on PR #13082:
URL: https://github.com/apache/camel/pull/13082#issuecomment-1936958035
> > I think you also need to review the failsafe plugin configuration on the
component's pom file.
>
> Otavio do you mean that some of the component have customized
configuration
davsclaus commented on PR #13082:
URL: https://github.com/apache/camel/pull/13082#issuecomment-1936943144
> failsafe
Otavio do you mean that some of the component have customized configuration
for `failsafe-plugin` in their pom? It seems so as if you do a `git grep
failsafe-plugin`
github-actions[bot] commented on PR #13082:
URL: https://github.com/apache/camel/pull/13082#issuecomment-1936681791
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel
cziesman opened a new pull request, #13082:
URL: https://github.com/apache/camel/pull/13082
# Description
Several test classes are named *IntegrationTest.java. These have been
renamed to *IT.java so that they match the default naming pattern for the
failsafe plugin.
# Target
11 matches
Mail list logo
