Re: [PR] Builder annotation support [camel-k]

2024-01-26 Thread via GitHub
squakez merged PR #5104: URL: https://github.com/apache/camel-k/pull/5104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Builder annotation support [camel-k]

2024-01-25 Thread via GitHub
github-actions[bot] commented on PR #5104: URL: https://github.com/apache/camel-k/pull/5104#issuecomment-1911601737 :heavy_check_mark: Unit test coverage report - coverage increased from 34.8% to 35.6% (**+0.8%**) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Builder annotation support [camel-k]

2024-01-25 Thread via GitHub
github-actions[bot] commented on PR #5104: URL: https://github.com/apache/camel-k/pull/5104#issuecomment-1910537478 :heavy_check_mark: Unit test coverage report - coverage increased from 34.8% to 35.3% (**+0.5%**) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Builder annotation support [camel-k]

2024-01-25 Thread via GitHub
rodcloutier commented on code in PR #5104: URL: https://github.com/apache/camel-k/pull/5104#discussion_r1466607137 ## pkg/controller/integrationkit/build.go: ## @@ -133,8 +133,10 @@ func (action *buildAction) handleBuildSubmitted(ctx context.Context, kit *v1.Int

Re: [PR] Builder annotation support [camel-k]

2024-01-25 Thread via GitHub
rodcloutier commented on code in PR #5104: URL: https://github.com/apache/camel-k/pull/5104#discussion_r1466599547 ## pkg/apis/camel/v1/common_types.go: ## @@ -55,6 +55,8 @@ type BuildConfiguration struct { LimitMemory string `property:"limit-memory"

Re: [PR] Builder annotation support [camel-k]

2024-01-25 Thread via GitHub
rodcloutier commented on code in PR #5104: URL: https://github.com/apache/camel-k/pull/5104#discussion_r1466598609 ## pkg/cmd/operator/operator.go: ## @@ -295,7 +295,8 @@ func getOperatorImage(ctx context.Context, c ctrl.Reader) (string, error) { ns :=

Re: [PR] Builder annotation support [camel-k]

2024-01-25 Thread via GitHub
rodcloutier commented on code in PR #5104: URL: https://github.com/apache/camel-k/pull/5104#discussion_r1466597168 ## pkg/cmd/operator/operator.go: ## @@ -165,8 +165,8 @@ func Run(healthPort, monitoringPort int32, leaderElection bool, leaderElectionID // in

Re: [PR] Builder annotation support [camel-k]

2024-01-25 Thread via GitHub
github-actions[bot] commented on PR #5104: URL: https://github.com/apache/camel-k/pull/5104#issuecomment-1910283554 :heavy_check_mark: Unit test coverage report - coverage increased from 34.8% to 35.3% (**+0.5%**) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Builder annotation support [camel-k]

2024-01-25 Thread via GitHub
squakez commented on code in PR #5104: URL: https://github.com/apache/camel-k/pull/5104#discussion_r1466413582 ## pkg/cmd/operator/operator.go: ## @@ -295,7 +295,8 @@ func getOperatorImage(ctx context.Context, c ctrl.Reader) (string, error) { ns :=

Re: [PR] Builder annotation support [camel-k]

2024-01-25 Thread via GitHub
rodcloutier commented on PR #5104: URL: https://github.com/apache/camel-k/pull/5104#issuecomment-1910230153 I am struggling to find any place to insert test for this enhancement. Could anyone chime in? -- This is an automated message from the Apache Git Service. To respond to the

[PR] Builder annotation support [camel-k]

2024-01-25 Thread via GitHub
rodcloutier opened a new pull request, #5104: URL: https://github.com/apache/camel-k/pull/5104 This PR proposes to add the possibility to configure annotation on the build pod. This was required to allow build pods to properly execute in the context of using Buildah in an AppArmor