orpiske commented on PR #11934:
URL: https://github.com/apache/camel/pull/11934#issuecomment-1814484997
Thanks for your contribution @anton-goncharov !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
anton-goncharov commented on PR #11934:
URL: https://github.com/apache/camel/pull/11934#issuecomment-1814464794
thanks @orpiske , you're a mind reader, I was about to write to ask if we
can proceed with this one.
I'll be checking on ASF CI pipeline results
--
This is an automated messa
orpiske merged PR #11934:
URL: https://github.com/apache/camel/pull/11934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apac
orpiske commented on code in PR #11934:
URL: https://github.com/apache/camel/pull/11934#discussion_r1395281329
##
core/camel-core/src/test/java/org/apache/camel/TestSupport.java:
##
@@ -445,43 +422,6 @@ public static Channel unwrapChannel(Processor processor) {
}
}
anton-goncharov commented on code in PR #11934:
URL: https://github.com/apache/camel/pull/11934#discussion_r1394980990
##
core/camel-core/src/test/java/org/apache/camel/TestSupport.java:
##
@@ -445,43 +422,6 @@ public static Channel unwrapChannel(Processor processor) {
anton-goncharov commented on code in PR #11934:
URL: https://github.com/apache/camel/pull/11934#discussion_r1394979333
##
core/camel-core/src/test/java/org/apache/camel/component/file/FileConsumerFailureHandledTest.java:
##
@@ -72,7 +72,7 @@ public void testDublin() throws Excep
anton-goncharov commented on code in PR #11934:
URL: https://github.com/apache/camel/pull/11934#discussion_r1389210442
##
core/camel-core/src/test/java/org/apache/camel/component/file/FileConsumerFailureHandledTest.java:
##
@@ -57,7 +57,7 @@ public void testLondon() throws Excep
orpiske commented on PR #11934:
URL: https://github.com/apache/camel/pull/11934#issuecomment-1805390826
I think we won't have time to get this on in 4.2, but it's a good change. We
might be able to add it to 4.3.
--
This is an automated message from the Apache Git Service.
To respond to
orpiske commented on code in PR #11934:
URL: https://github.com/apache/camel/pull/11934#discussion_r1387733384
##
core/camel-core/src/test/java/org/apache/camel/component/file/FileConsumerFailureHandledTest.java:
##
@@ -57,7 +57,7 @@ public void testLondon() throws Exception {
anton-goncharov commented on code in PR #11934:
URL: https://github.com/apache/camel/pull/11934#discussion_r1386766506
##
core/camel-core/src/test/java/org/apache/camel/component/file/FileConsumerFailureHandledTest.java:
##
@@ -57,7 +57,7 @@ public void testLondon() throws Excep
anton-goncharov commented on code in PR #11934:
URL: https://github.com/apache/camel/pull/11934#discussion_r1386693104
##
core/camel-core/src/test/java/org/apache/camel/TestSupport.java:
##
@@ -445,43 +422,6 @@ public static Channel unwrapChannel(Processor processor) {
orpiske commented on code in PR #11934:
URL: https://github.com/apache/camel/pull/11934#discussion_r1386122476
##
core/camel-core/src/test/java/org/apache/camel/TestSupport.java:
##
@@ -445,43 +422,6 @@ public static Channel unwrapChannel(Processor processor) {
}
}
orpiske commented on code in PR #11934:
URL: https://github.com/apache/camel/pull/11934#discussion_r1386117008
##
core/camel-core/src/test/java/org/apache/camel/component/file/FileConsumerFailureHandledTest.java:
##
@@ -57,7 +57,7 @@ public void testLondon() throws Exception {
oscerd commented on PR #11934:
URL: https://github.com/apache/camel/pull/11934#issuecomment-1800255388
It's something reserved to PMC and committer, so each time you push
something we need to approve and run the pipeline again.
--
This is an automated message from the Apache Git Service.
anton-goncharov commented on PR #11934:
URL: https://github.com/apache/camel/pull/11934#issuecomment-1800227570
@oscerd I guess since it's my first contribution, it needs workflow approval
each time. Can you please approve again?
--
This is an automated message from the Apache Git Service
github-actions[bot] commented on PR #11934:
URL: https://github.com/apache/camel/pull/11934#issuecomment-1800160425
:robot: The Apache Camel test robot will run the tests for you :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
anton-goncharov commented on PR #11934:
URL: https://github.com/apache/camel/pull/11934#issuecomment-1800159885
/component-test camel-core camel-spring-xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] commented on PR #11934:
URL: https://github.com/apache/camel/pull/11934#issuecomment-1799811958
:robot: The Apache Camel test robot will run the tests for you :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
anton-goncharov commented on PR #11934:
URL: https://github.com/apache/camel/pull/11934#issuecomment-1799811362
/component-test camel-core camel-spring-xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] commented on PR #11934:
URL: https://github.com/apache/camel/pull/11934#issuecomment-1799400324
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committer
anton-goncharov opened a new pull request, #11934:
URL: https://github.com/apache/camel/pull/11934
# Description
Making use of junit5 `@TempDir` in TestSupport to control lifecycle of a
temporary directory when it's used in camel-core tests. @TempDir uses a
system-specific path dedic
21 matches
Mail list logo
