Re: [PR] CAMEL-20044 [camel]

2023-11-07 Thread via GitHub
CodeSmell commented on PR #11935: URL: https://github.com/apache/camel/pull/11935#issuecomment-1800351119 I was adding integration tests for this fix The two in the initial commit cover the basic behavior. Still working on adding IT for the 2 issues (Note: need to create multiple

Re: [PR] CAMEL-20044 [camel]

2023-11-07 Thread via GitHub
CodeSmell commented on PR #11935: URL: https://github.com/apache/camel/pull/11935#issuecomment-1800349018 Note this fix was done off my local branch that has the logging statements. Those logging statements are also in this approved PR but it wasn't merged yet -

Re: [PR] CAMEL-20044 [camel]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #11935: URL: https://github.com/apache/camel/pull/11935#issuecomment-1800348473 :star2: Thank you for your contribution to the Apache Camel project! :star2: :warning: Please note that the changes on this PR may be **tested automatically**.

[PR] CAMEL-20044 [camel]

2023-11-07 Thread via GitHub
CodeSmell opened a new pull request, #11935: URL: https://github.com/apache/camel/pull/11935 # Description This PR offers a fix for breakOnFirstError where the incorrect partition:offset when a forceCommit is done # Target This PR is off the camel-3.21.x branch