Re: [PR] CAMEL-20336: Add a WebAssembly component and language [camel]

2024-01-26 Thread via GitHub
oscerd merged PR #12857: URL: https://github.com/apache/camel/pull/12857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] CAMEL-20336: Add a WebAssembly component and language [camel]

2024-01-26 Thread via GitHub
lburgazzoli commented on PR #12857: URL: https://github.com/apache/camel/pull/12857#issuecomment-1911729417 > @lburgazzoli can your resolve conflicts so we could merge? Thanks! done -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] CAMEL-20336: Add a WebAssembly component and language [camel]

2024-01-25 Thread via GitHub
oscerd commented on PR #12857: URL: https://github.com/apache/camel/pull/12857#issuecomment-1910175909 @lburgazzoli can your resolve conflicts so we could merge? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] CAMEL-20336: Add a WebAssembly component and language [camel]

2024-01-22 Thread via GitHub
lburgazzoli commented on code in PR #12857: URL: https://github.com/apache/camel/pull/12857#discussion_r1461802949 ## components/camel-wasm/src/test/java/org/apache/camel/language/wasm/WasmLanguageTest.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] CAMEL-20336: Add a WebAssembly component and language [camel]

2024-01-22 Thread via GitHub
orpiske commented on code in PR #12857: URL: https://github.com/apache/camel/pull/12857#discussion_r1461794900 ## components/camel-wasm/src/test/java/org/apache/camel/language/wasm/WasmLanguageTest.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] CAMEL-20336: Add a WebAssembly component and language [camel]

2024-01-22 Thread via GitHub
orpiske commented on code in PR #12857: URL: https://github.com/apache/camel/pull/12857#discussion_r1461794900 ## components/camel-wasm/src/test/java/org/apache/camel/language/wasm/WasmLanguageTest.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] CAMEL-20336: Add a WebAssembly component and language [camel]

2024-01-22 Thread via GitHub
orpiske commented on code in PR #12857: URL: https://github.com/apache/camel/pull/12857#discussion_r1461781622 ## components/camel-wasm/pom.xml: ## @@ -0,0 +1,86 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;

Re: [PR] CAMEL-20336: Add a WebAssembly component and language [camel]

2024-01-22 Thread via GitHub
lburgazzoli commented on code in PR #12857: URL: https://github.com/apache/camel/pull/12857#discussion_r1461769357 ## components/camel-wasm/pom.xml: ## @@ -0,0 +1,86 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;

Re: [PR] CAMEL-20336: Add a WebAssembly component and language [camel]

2024-01-22 Thread via GitHub
orpiske commented on code in PR #12857: URL: https://github.com/apache/camel/pull/12857#discussion_r1461764067 ## components/camel-wasm/pom.xml: ## @@ -0,0 +1,86 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;

Re: [PR] CAMEL-20336: Add a WebAssembly component and language [camel]

2024-01-22 Thread via GitHub
lburgazzoli commented on PR #12857: URL: https://github.com/apache/camel/pull/12857#issuecomment-1903780317 > > LGTM, I have just a question: > > Is wee_alloc changeable? > > not needed anymore, will remove it done -- This is an automated message from the Apache Git

Re: [PR] CAMEL-20336: Add a WebAssembly component and language [camel]

2024-01-22 Thread via GitHub
lburgazzoli commented on PR #12857: URL: https://github.com/apache/camel/pull/12857#issuecomment-1903780061 > It may be that the docs for language is a mostly a copy of the component doc. I think I didnt see an example how to use it as a language. Also what is the benefit of a language vs

Re: [PR] CAMEL-20336: Add a WebAssembly component and language [camel]

2024-01-22 Thread via GitHub
davsclaus commented on PR #12857: URL: https://github.com/apache/camel/pull/12857#issuecomment-1903698637 It may be that the docs for language is a mostly a copy of the component doc. I think I didnt see an example how to use it as a language. Also what is the benefit of a language vs a

Re: [PR] CAMEL-20336: Add a WebAssembly component and language [camel]

2024-01-22 Thread via GitHub
lburgazzoli commented on PR #12857: URL: https://github.com/apache/camel/pull/12857#issuecomment-1903659313 > LGTM, I have just a question: > > Is wee_alloc changeable? > not needed anymore, will remove it -- This is an automated message from the Apache Git Service. To

Re: [PR] CAMEL-20336: Add a WebAssembly component and language [camel]

2024-01-22 Thread via GitHub
github-actions[bot] commented on PR #12857: URL: https://github.com/apache/camel/pull/12857#issuecomment-1903633729 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel

[PR] CAMEL-20336: Add a WebAssembly component and language [camel]

2024-01-22 Thread via GitHub
lburgazzoli opened a new pull request, #12857: URL: https://github.com/apache/camel/pull/12857 # Description # Target - [ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch) #