mgubaidullin merged PR #1113:
URL: https://github.com/apache/camel-karavan/pull/1113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mgubaidullin commented on PR #1113:
URL: https://github.com/apache/camel-karavan/pull/1113#issuecomment-1953181585
@vidhyasagarj @indubabu thanks for the contribution.
Next time please comment an issue first, so I could assign you to the issue.
and for complex issues like this one,
vidhyasagarj commented on PR #1113:
URL: https://github.com/apache/camel-karavan/pull/1113#issuecomment-1948282770
we have made the changes as suggested for vs code and fixed the issue with
karavan-space.
Also, I wanted to highlight that vs-code debug is not working consistently,
vidhyasagarj commented on PR #1113:
URL: https://github.com/apache/camel-karavan/pull/1113#issuecomment-1947381301
> @vidhyasagarj @indubabu appreciate your contribution. The issue is quite
complex. That is why it requires a lot of verification
>
>
Totally understand, we
vidhyasagarj commented on PR #1113:
URL: https://github.com/apache/camel-karavan/pull/1113#issuecomment-1947365283
> karavan-space (source for https://karavan.space/) can not be compiled
Will check this one.
--
This is an automated message from the Apache Git Service.
To respond
vidhyasagarj commented on code in PR #1113:
URL: https://github.com/apache/camel-karavan/pull/1113#discussion_r1491687962
##
karavan-designer/src/designer/karavan.css:
##
@@ -813,4 +818,8 @@
}
.karavan .knowledbase-eip-section .pf-v5-c-toggle-group{
margin:16px;
+}
mgubaidullin commented on PR #1113:
URL: https://github.com/apache/camel-karavan/pull/1113#issuecomment-1946430294
@vidhyasagarj @indubabu appreciate your contribution. The issue is quite
complex. That is why it requires a lot of verification
--
This is an automated message from the
mgubaidullin commented on code in PR #1113:
URL: https://github.com/apache/camel-karavan/pull/1113#discussion_r1491250711
##
karavan-designer/src/designer/karavan.css:
##
@@ -813,4 +818,8 @@
}
.karavan .knowledbase-eip-section .pf-v5-c-toggle-group{
margin:16px;
+}
mgubaidullin commented on PR #1113:
URL: https://github.com/apache/camel-karavan/pull/1113#issuecomment-1946407572
`snippets` folder in vscode extension is read-only. users can not write
there.
blocked component/kamelet files could be stored same way as custom kamelets
(in special
mgubaidullin commented on PR #1113:
URL: https://github.com/apache/camel-karavan/pull/1113#issuecomment-1946381852
karavan-space (source for https://karavan.space/) can not be compiled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mgubaidullin commented on PR #1113:
URL: https://github.com/apache/camel-karavan/pull/1113#issuecomment-1946379273
karavan-designer starts with bunch of errors
https://github.com/apache/camel-karavan/assets/1379213/81ccac64-7e58-4a99-a114-4b122cc7e621;>
--
This is an automated
vidhyasagarj commented on PR #1113:
URL: https://github.com/apache/camel-karavan/pull/1113#issuecomment-1945358069
@mgubaidullin has made the changes as per the comments, let me know if any
further change required.
1. remove additional formatting where no code changes - **done**
vidhyasagarj commented on code in PR #1113:
URL: https://github.com/apache/camel-karavan/pull/1113#discussion_r1488802752
##
karavan-web/karavan-app/src/main/resources/snippets/kamelets-blocklist.txt:
##
Review Comment:
This file was added for testing and will be removed,
vidhyasagarj commented on code in PR #1113:
URL: https://github.com/apache/camel-karavan/pull/1113#discussion_r1488803179
##
karavan-web/karavan-app/src/main/resources/snippets/components-blocklist.txt:
##
Review Comment:
Will be removed. Sorry for missing out.
--
This
mgubaidullin commented on code in PR #1113:
URL: https://github.com/apache/camel-karavan/pull/1113#discussion_r1487794777
##
karavan-web/karavan-app/src/main/resources/snippets/components-blocklist.txt:
##
Review Comment:
Why these components are blocked by default?
mgubaidullin commented on PR #1113:
URL: https://github.com/apache/camel-karavan/pull/1113#issuecomment-1934354119
Thank you @vidhyasagarj
a few comments
backend
1. We could keep a list of accepted components and kamelets in the files in
the templates project.
We store
vidhyasagarj opened a new pull request, #1113:
URL: https://github.com/apache/camel-karavan/pull/1113
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
17 matches
Mail list logo
