[PR] Update camel-salesforce to use a newer protobuf-maven-plugin for gRPC [camel]

2024-05-28 Thread via GitHub
cziesman opened a new pull request, #14269: URL: https://github.com/apache/camel/pull/14269 # Description The https://www.xolstice.org/protobuf-maven-plugin is not maintained anymore and the last release is from 2018. We can use https://github.com/ascopes/protobuf-maven-plugin

Re: [PR] Update camel-salesforce to use a newer protobuf-maven-plugin for gRPC [camel]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #14269: URL: https://github.com/apache/camel/pull/14269#issuecomment-2136296543 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committer

Re: [PR] Update camel-salesforce to use a newer protobuf-maven-plugin for gRPC [camel]

2024-05-29 Thread via GitHub
oscerd commented on code in PR #14269: URL: https://github.com/apache/camel/pull/14269#discussion_r1618561096 ## components/camel-salesforce/camel-salesforce-component/pom.xml: ## @@ -34,6 +34,9 @@ .. +1.62.2 +3.21.5 +2.1.1 Review Commen

Re: [PR] Update camel-salesforce to use a newer protobuf-maven-plugin for gRPC [camel]

2024-05-29 Thread via GitHub
cziesman commented on code in PR #14269: URL: https://github.com/apache/camel/pull/14269#discussion_r1619017430 ## components/camel-salesforce/camel-salesforce-component/pom.xml: ## @@ -34,6 +34,9 @@ .. +1.62.2 +3.21.5 +2.1.1 Review Comm

Re: [PR] Update camel-salesforce to use a newer protobuf-maven-plugin for gRPC [camel]

2024-05-29 Thread via GitHub
davsclaus commented on code in PR #14269: URL: https://github.com/apache/camel/pull/14269#discussion_r1619885526 ## parent/pom.xml: ## @@ -262,6 +262,7 @@ 4.0.1 1.1.4 4.0.5 +1.62.2 Review Comment: We do not use dot but dash ## pa

Re: [PR] Update camel-salesforce to use a newer protobuf-maven-plugin for gRPC [camel]

2024-05-30 Thread via GitHub
cziesman commented on code in PR #14269: URL: https://github.com/apache/camel/pull/14269#discussion_r1620806477 ## parent/pom.xml: ## @@ -262,6 +262,7 @@ 4.0.1 1.1.4 4.0.5 +1.62.2 Review Comment: Fixed -- This is an automated message fr

Re: [PR] Update camel-salesforce to use a newer protobuf-maven-plugin for gRPC [camel]

2024-05-30 Thread via GitHub
cziesman commented on code in PR #14269: URL: https://github.com/apache/camel/pull/14269#discussion_r1620807228 ## parent/pom.xml: ## @@ -404,7 +405,7 @@ 1.2.1 2.22.0 3.25.3 -0.6.1 +2.1.1 Review Comment: Fixed -- This is an au

Re: [PR] Update camel-salesforce to use a newer protobuf-maven-plugin for gRPC [camel]

2024-05-31 Thread via GitHub
davsclaus commented on PR #14269: URL: https://github.com/apache/camel/pull/14269#issuecomment-2141908095 The logs seems to say that there is build error in camel-salesforce. Though it could also be that the PR is not sync with latest main, or that we had some GH build issues. Have y

Re: [PR] Update camel-salesforce to use a newer protobuf-maven-plugin for gRPC [camel]

2024-05-31 Thread via GitHub
cziesman commented on PR #14269: URL: https://github.com/apache/camel/pull/14269#issuecomment-2142306480 @davsclaus I have synced and built locally. All tests pass. Where can I see the actual logs for the PR build? The error shown in the details link ```Error: Process completed with e

Re: [PR] Update camel-salesforce to use a newer protobuf-maven-plugin for gRPC [camel]

2024-05-31 Thread via GitHub
jamesnetherton commented on code in PR #14269: URL: https://github.com/apache/camel/pull/14269#discussion_r1622524959 ## parent/pom.xml: ## @@ -262,6 +262,7 @@ 4.0.1 1.1.4 4.0.5 +1.62.2 Review Comment: Please remove this as `grpc-version` i

Re: [PR] Update camel-salesforce to use a newer protobuf-maven-plugin for gRPC [camel]

2024-05-31 Thread via GitHub
cziesman commented on code in PR #14269: URL: https://github.com/apache/camel/pull/14269#discussion_r1622605733 ## parent/pom.xml: ## @@ -262,6 +262,7 @@ 4.0.1 1.1.4 4.0.5 +1.62.2 Review Comment: Fixed -- This is an automated message fr

Re: [PR] Update camel-salesforce to use a newer protobuf-maven-plugin for gRPC [camel]

2024-06-03 Thread via GitHub
davsclaus commented on PR #14269: URL: https://github.com/apache/camel/pull/14269#issuecomment-2144870255 there is a merge conflict. And I wonder if you can rebase on main for this PR so its on top of latest code -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] Update camel-salesforce to use a newer protobuf-maven-plugin for gRPC [camel]

2024-06-03 Thread via GitHub
cziesman commented on PR #14269: URL: https://github.com/apache/camel/pull/14269#issuecomment-2145616766 Merge conflicts should be fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci