lburgazzoli closed pull request #13273: feat(camel-main): add options to let
the shutdown strategy to wait or ignore inflight messages
URL: https://github.com/apache/camel/pull/13273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
lburgazzoli commented on PR #13273:
URL: https://github.com/apache/camel/pull/13273#issuecomment-1964472212
> > mh, thinking a little bit more about this, any combination would
probably be sub optimal for the camel-k POV, so I'm inclined to keep the
implementation on the camel-k side and
orpiske commented on PR #13273:
URL: https://github.com/apache/camel/pull/13273#issuecomment-196885
> mh, thinking a little bit more about this, any combination would probably
be sub optimal for the camel-k POV, so I'm inclined to keep the implementation
on the camel-k side and avoid
davsclaus commented on PR #13273:
URL: https://github.com/apache/camel/pull/13273#issuecomment-1964441514
> mh, thinking a little bit more about this, any combination would probably
be sub optimal for the camel-k POV, so I'm inclined to keep the implementation
on the camel-k side and avoid
lburgazzoli commented on PR #13273:
URL: https://github.com/apache/camel/pull/13273#issuecomment-1964420220
mh, thinking a little bit more about this, any combination would probably be
sub optimal for the camel-k POV, so I'm inclined to keep the implementation on
the camel-k side and avoid
lburgazzoli commented on PR #13273:
URL: https://github.com/apache/camel/pull/13273#issuecomment-1964349200
mh, I'm not sure if this is gogin to work in the camel-k scenario as for
example:
1. you set the max messages to 1
2. you set the max idle to 5 sec
Now, if an "child"
davsclaus commented on PR #13273:
URL: https://github.com/apache/camel/pull/13273#issuecomment-1964053912
In stream caching we have `anySpoolRule` (boolean)
So I wonder if we should use `ANY | ALL` as the enums.
durationCompletionRule = ANY | ALL
--
This is an
lburgazzoli commented on PR #13273:
URL: https://github.com/apache/camel/pull/13273#issuecomment-1964035551
Something like this ?
```
DurationStrategies { AND, OR }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
orpiske commented on PR #13273:
URL: https://github.com/apache/camel/pull/13273#issuecomment-1963954707
IMHO, I think an `enum` would be better ... something like `QuiescePolicy ->
{ INCLUSIVE, EXCLUSIVE }`
--
This is an automated message from the Apache Git Service.
To respond to the
davsclaus commented on PR #13273:
URL: https://github.com/apache/camel/pull/13273#issuecomment-1963938991
> Do you think we need an option to turn on this behavior ?
Yes I had a walk with the dogs and thought the same. If we have an option to
decide if its OR/AND then you can set
lburgazzoli commented on PR #13273:
URL: https://github.com/apache/camel/pull/13273#issuecomment-1963890907
> > Although I think this should be done at some point, I feel that as today
the implementation is inconsistent as my understanding is that if you set bot
max messages and idle time,
davsclaus commented on PR #13273:
URL: https://github.com/apache/camel/pull/13273#issuecomment-1963830099
> Although I think this should be done at some point, I feel that as today
the implementation is inconsistent as my understanding is that if you set bot
max messages and idle time,
lburgazzoli commented on PR #13273:
URL: https://github.com/apache/camel/pull/13273#issuecomment-1963708431
> > > Yeah I can see the point that max does not have a inflight check, but
that was also not its intention. But to say that after X message then shutdown.
And during shutdown any
orpiske commented on PR #13273:
URL: https://github.com/apache/camel/pull/13273#issuecomment-1963693654
> > Yeah I can see the point that max does not have a inflight check, but
that was also not its intention. But to say that after X message then shutdown.
And during shutdown any inflight
davsclaus commented on PR #13273:
URL: https://github.com/apache/camel/pull/13273#issuecomment-1963689695
> > Yeah I can see the point that max does not have a inflight check, but
that was also not its intention. But to say that after X message then shutdown.
And during shutdown any
lburgazzoli commented on PR #13273:
URL: https://github.com/apache/camel/pull/13273#issuecomment-1963685495
> Yeah I can see the point that max does not have a inflight check, but that
was also not its intention. But to say that after X message then shutdown. And
during shutdown any
davsclaus commented on PR #13273:
URL: https://github.com/apache/camel/pull/13273#issuecomment-1963609610
When this is done, then you need to add these 2 new options in
camel-spring-boot project
--
This is an automated message from the Apache Git Service.
To respond to the message,
davsclaus commented on PR #13273:
URL: https://github.com/apache/camel/pull/13273#issuecomment-1963602965
Yeah I can see the point that max does not have a inflight check, but that
was also not its intention. But to say that after X message then shutdown. And
during shutdown any inflight
davsclaus commented on PR #13273:
URL: https://github.com/apache/camel/pull/13273#issuecomment-1963597873
Typo
Ingore -> Ignore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
davsclaus commented on PR #13273:
URL: https://github.com/apache/camel/pull/13273#issuecomment-1962853355
Yeah lets give this some thinking on monday
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
lburgazzoli commented on PR #13273:
URL: https://github.com/apache/camel/pull/13273#issuecomment-1962358545
If you don't see this generally applicable to camel-main, we can retain the
behavior in camel-k without problems
--
This is an automated message from the Apache Git Service.
To
lburgazzoli commented on PR #13273:
URL: https://github.com/apache/camel/pull/13273#issuecomment-1962350520
> This can lead to waiting forever as if the system keeps taking in new
inflight messages, as this will never issue the shutdown strategy to begin
shutting down. The shutdown
davsclaus commented on PR #13273:
URL: https://github.com/apache/camel/pull/13273#issuecomment-1962317365
This can lead to waiting forever as if the system keeps taking in new
inflight messages, as this will never issue the shutdown strategy to begin
shutting down. The shutdown strategy
orpiske commented on code in PR #13273:
URL: https://github.com/apache/camel/pull/13273#discussion_r1500404647
##
core/camel-main/src/main/java/org/apache/camel/main/MainDurationEventNotifier.java:
##
@@ -110,10 +121,19 @@ protected void doNotify(CamelEvent event) {
lburgazzoli commented on code in PR #13273:
URL: https://github.com/apache/camel/pull/13273#discussion_r1499977160
##
core/camel-main/src/main/java/org/apache/camel/main/MainDurationEventNotifier.java:
##
@@ -110,10 +121,19 @@ protected void doNotify(CamelEvent event) {
orpiske commented on code in PR #13273:
URL: https://github.com/apache/camel/pull/13273#discussion_r1499458392
##
core/camel-main/src/main/java/org/apache/camel/main/MainDurationEventNotifier.java:
##
@@ -110,10 +121,19 @@ protected void doNotify(CamelEvent event) {
orpiske commented on code in PR #13273:
URL: https://github.com/apache/camel/pull/13273#discussion_r1499458392
##
core/camel-main/src/main/java/org/apache/camel/main/MainDurationEventNotifier.java:
##
@@ -110,10 +121,19 @@ protected void doNotify(CamelEvent event) {
lburgazzoli commented on PR #13273:
URL: https://github.com/apache/camel/pull/13273#issuecomment-1959630115
@davsclaus this is a draft work about having camel main be able to ignore or
not inflight exchanges before shutting down the context. Not sure if this is
the right approach as it
github-actions[bot] commented on PR #13273:
URL: https://github.com/apache/camel/pull/13273#issuecomment-1959626264
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel
lburgazzoli opened a new pull request, #13273:
URL: https://github.com/apache/camel/pull/13273
# Description
# Target
- [ ] I checked that the commit is targeting the correct branch (note that
Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
#
30 matches
Mail list logo
