Re: [PR] fix(#4776): Fix catalog loading in camel trait [camel-k]

2024-01-22 Thread via GitHub
christophd merged PR #5086: URL: https://github.com/apache/camel-k/pull/5086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix(#4776): Fix catalog loading in camel trait [camel-k]

2024-01-22 Thread via GitHub
squakez commented on code in PR #5086: URL: https://github.com/apache/camel-k/pull/5086#discussion_r1461778750 ## pkg/trait/camel.go: ## @@ -61,7 +61,11 @@ func (t *camelTrait) InfluencesBuild(this, prev map[string]interface{}) bool { func (t *camelTrait) Configure(e

Re: [PR] fix(#4776): Fix catalog loading in camel trait [camel-k]

2024-01-22 Thread via GitHub
christophd commented on code in PR #5086: URL: https://github.com/apache/camel-k/pull/5086#discussion_r1461763874 ## pkg/trait/camel.go: ## @@ -61,7 +61,11 @@ func (t *camelTrait) InfluencesBuild(this, prev map[string]interface{}) bool { func (t *camelTrait) Configure(e

Re: [PR] fix(#4776): Fix catalog loading in camel trait [camel-k]

2024-01-22 Thread via GitHub
squakez commented on code in PR #5086: URL: https://github.com/apache/camel-k/pull/5086#discussion_r1461735899 ## pkg/trait/camel.go: ## @@ -61,7 +61,11 @@ func (t *camelTrait) InfluencesBuild(this, prev map[string]interface{}) bool { func (t *camelTrait) Configure(e

Re: [PR] fix(#4776): Fix catalog loading in camel trait [camel-k]

2024-01-22 Thread via GitHub
christophd commented on code in PR #5086: URL: https://github.com/apache/camel-k/pull/5086#discussion_r1461724333 ## pkg/trait/camel.go: ## @@ -276,5 +278,5 @@ func determineRuntimeVersion(e *Environment) string { if e.Platform != nil &&

Re: [PR] fix(#4776): Fix catalog loading in camel trait [camel-k]

2024-01-22 Thread via GitHub
squakez commented on code in PR #5086: URL: https://github.com/apache/camel-k/pull/5086#discussion_r1461509673 ## pkg/trait/camel.go: ## @@ -276,5 +278,5 @@ func determineRuntimeVersion(e *Environment) string { if e.Platform != nil &&

[PR] fix(#4776): Fix catalog loading in camel trait [camel-k]

2024-01-19 Thread via GitHub
christophd opened a new pull request, #5086: URL: https://github.com/apache/camel-k/pull/5086 - When new runtime version is used on integration the camel trait creates the catalog if it does not exist already - Use proper catalog namespace to verify that the catalog resource has been