Re: [PR] fix(traits): use Comparable matches [camel-k]

2024-03-12 Thread via GitHub
squakez merged PR #5230: URL: https://github.com/apache/camel-k/pull/5230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix(traits): use Comparable matches [camel-k]

2024-03-12 Thread via GitHub
github-actions[bot] commented on PR #5230: URL: https://github.com/apache/camel-k/pull/5230#issuecomment-1990953463 :heavy_check_mark: Unit test coverage report - coverage increased from 36.9% to 37.1% (**+0.2%**) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] fix(traits): use Comparable matches [camel-k]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #5230: URL: https://github.com/apache/camel-k/pull/5230#issuecomment-1988654389 :heavy_check_mark: Unit test coverage report - coverage increased from 36.9% to 37.1% (**+0.2%**) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] fix(traits): use Comparable matches [camel-k]

2024-03-08 Thread via GitHub
squakez commented on PR #5230: URL: https://github.com/apache/camel-k/pull/5230#issuecomment-1986387256 ``` --- PASS: TestNativeHighMemoryIntegrations (1750.79s) --- PASS: TestNativeHighMemoryIntegrations/java_native_support (847.92s) --- PASS:

Re: [PR] fix(traits): use Comparable matches [camel-k]

2024-03-08 Thread via GitHub
github-actions[bot] commented on PR #5230: URL: https://github.com/apache/camel-k/pull/5230#issuecomment-1985981407 :heavy_check_mark: Unit test coverage report - coverage increased from 36.9% to 37.1% (**+0.2%**) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] fix(traits): use Comparable matches [camel-k]

2024-03-07 Thread via GitHub
lburgazzoli commented on code in PR #5230: URL: https://github.com/apache/camel-k/pull/5230#discussion_r1517349545 ## pkg/trait/builder.go: ## @@ -56,9 +57,18 @@ func (t *builderTrait) InfluencesKit() bool { return true } -// InfluencesBuild overrides base class

Re: [PR] fix(traits): use Comparable matches [camel-k]

2024-03-07 Thread via GitHub
squakez commented on code in PR #5230: URL: https://github.com/apache/camel-k/pull/5230#discussion_r1517281977 ## pkg/trait/builder.go: ## @@ -56,9 +57,18 @@ func (t *builderTrait) InfluencesKit() bool { return true } -// InfluencesBuild overrides base class method.

Re: [PR] fix(traits): use Comparable matches [camel-k]

2024-03-07 Thread via GitHub
lburgazzoli commented on code in PR #5230: URL: https://github.com/apache/camel-k/pull/5230#discussion_r1517247695 ## pkg/trait/builder.go: ## @@ -56,9 +57,18 @@ func (t *builderTrait) InfluencesKit() bool { return true } -// InfluencesBuild overrides base class

Re: [PR] fix(traits): use Comparable matches [camel-k]

2024-03-07 Thread via GitHub
squakez commented on code in PR #5230: URL: https://github.com/apache/camel-k/pull/5230#discussion_r1517210674 ## pkg/trait/builder.go: ## @@ -56,9 +57,18 @@ func (t *builderTrait) InfluencesKit() bool { return true } -// InfluencesBuild overrides base class method.

Re: [PR] fix(traits): use Comparable matches [camel-k]

2024-03-07 Thread via GitHub
squakez commented on PR #5230: URL: https://github.com/apache/camel-k/pull/5230#issuecomment-1985096678 ``` === NAME TestNativeHighMemoryIntegrations native_with_sources_test.go:60: Timed out after 60.000s. Expected : 2024-03-07 17:04:07,602

Re: [PR] fix(traits): use Comparable matches [camel-k]

2024-03-07 Thread via GitHub
squakez commented on PR #5230: URL: https://github.com/apache/camel-k/pull/5230#issuecomment-1985096440 Result of Quarkus native integrations: ``` --- PASS: TestNativeBinding (549.82s) --- PASS: TestNativeBinding/binding_with_native_build (535.03s) --- PASS:

Re: [PR] fix(traits): use Comparable matches [camel-k]

2024-03-07 Thread via GitHub
lburgazzoli commented on code in PR #5230: URL: https://github.com/apache/camel-k/pull/5230#discussion_r1516882356 ## pkg/trait/builder.go: ## @@ -56,9 +57,18 @@ func (t *builderTrait) InfluencesKit() bool { return true } -// InfluencesBuild overrides base class

Re: [PR] fix(traits): use Comparable matches [camel-k]

2024-03-07 Thread via GitHub
github-actions[bot] commented on PR #5230: URL: https://github.com/apache/camel-k/pull/5230#issuecomment-1983979304 :heavy_check_mark: Unit test coverage report - coverage increased from 36.8% to 37% (**+0.2%**) -- This is an automated message from the Apache Git Service. To respond to

[PR] fix(traits): use Comparable matches [camel-k]

2024-03-07 Thread via GitHub
squakez opened a new pull request, #5230: URL: https://github.com/apache/camel-k/pull/5230 Reverting #4512 which introduced a function diverging the match from the original design This PR aims to fix a diverging design I introduced some times ago. With this one we move back to the