[GitHub] [camel-k] squakez commented on pull request #1912: Feat(cli): version operator and warning compatibility message

2021-01-20 Thread GitBox
squakez commented on pull request #1912: URL: https://github.com/apache/camel-k/pull/1912#issuecomment-763473046 Ready for review now. @astefanutti if you want to have a look :) This is an automated message from the Apache

[GitHub] [camel-k] squakez commented on pull request #1912: Feat(cli): version operator and warning compatibility message

2021-01-19 Thread GitBox
squakez commented on pull request #1912: URL: https://github.com/apache/camel-k/pull/1912#issuecomment-762744944 > Right, resolving the version from the `IntegrationPlatfom` status is actually a great idea! It seems to solve all our concerns. Now I feel bad I distracted you with less

[GitHub] [camel-k] squakez commented on pull request #1912: Feat(cli): version operator and warning compatibility message

2021-01-19 Thread GitBox
squakez commented on pull request #1912: URL: https://github.com/apache/camel-k/pull/1912#issuecomment-762733070 > Great, let's dive into the `version` endpoint approach . > > The health and monitoring endpoints are delegated to controller-runtime: > >

[GitHub] [camel-k] squakez commented on pull request #1912: Feat(cli): version operator and warning compatibility message

2021-01-18 Thread GitBox
squakez commented on pull request #1912: URL: https://github.com/apache/camel-k/pull/1912#issuecomment-762201031 > > I am making the development to exec into the kamel operator, however I am thinking about the possible security concerns. Should we allow the CLI to run an arbitrary command

[GitHub] [camel-k] squakez commented on pull request #1912: Feat(cli): version operator and warning compatibility message

2021-01-18 Thread GitBox
squakez commented on pull request #1912: URL: https://github.com/apache/camel-k/pull/1912#issuecomment-762190832 > Another point is the retrieval of the operator version. Relying on extracting the tag from the Deployment image may fail in a number of situations, like when SHA pinning is

[GitHub] [camel-k] squakez commented on pull request #1912: Feat(cli): version operator and warning compatibility message

2021-01-15 Thread GitBox
squakez commented on pull request #1912: URL: https://github.com/apache/camel-k/pull/1912#issuecomment-760748643 > That is a great improvement! Here are my first feedback: > > * I wonder whether the `--operator` is necessary and `kamel version` should just output both client and

[GitHub] [camel-k] squakez commented on pull request #1912: Feat(cli): version operator and warning compatibility message

2021-01-14 Thread GitBox
squakez commented on pull request #1912: URL: https://github.com/apache/camel-k/pull/1912#issuecomment-760257361 Few points I'd like to hear about: 1. I'm considering compatibility up to patch level (ie, 1.3.1 cli is compatible with 1.3.0 operator, same for SNAPSHOT): does it make