Re: [PR] CASSANDRA-19500 Mask hash value produced by lz4's xxhash implementation [cassandra-analytics]

2024-03-27 Thread via GitHub
frankgh merged PR #46: URL: https://github.com/apache/cassandra-analytics/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ca

Re: [PR] CASSANDRA-19500 Mask hash value produced by lz4's xxhash implementation [cassandra-analytics]

2024-03-27 Thread via GitHub
frankgh commented on code in PR #46: URL: https://github.com/apache/cassandra-analytics/pull/46#discussion_r1541831858 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/utils/XXHash32DigestAlgorithm.java: ## @@ -61,7 +61,10 @@ public Digest calculateFileDiges

Re: [PR] CASSANDRA-19500 Mask hash value produced by lz4's xxhash implementation [cassandra-analytics]

2024-03-27 Thread via GitHub
yifan-c commented on code in PR #46: URL: https://github.com/apache/cassandra-analytics/pull/46#discussion_r1541824843 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/utils/XXHash32DigestAlgorithm.java: ## @@ -61,7 +61,10 @@ public Digest calculateFileDiges

Re: [PR] CASSANDRA-19500 Mask hash value produced by lz4's xxhash implementation [cassandra-analytics]

2024-03-27 Thread via GitHub
frankgh commented on code in PR #46: URL: https://github.com/apache/cassandra-analytics/pull/46#discussion_r1541666540 ## cassandra-analytics-core/src/test/java/org/apache/cassandra/spark/utils/XXHash32DigestAlgorithmTest.java: ## @@ -51,8 +51,8 @@ class XXHash32DigestAlgorithm

Re: [PR] CASSANDRA-19500 Mask hash value produced by lz4's xxhash implementation [cassandra-analytics]

2024-03-27 Thread via GitHub
frankgh commented on code in PR #46: URL: https://github.com/apache/cassandra-analytics/pull/46#discussion_r1541659110 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraClusterInfo.java: ## @@ -43,20 +43,20 @@ import org.slf4j.Logger; im

[PR] CASSANDRA-19500 Mask hash value produced by lz4's xxhash implementation [cassandra-analytics]

2024-03-27 Thread via GitHub
frankgh opened a new pull request, #46: URL: https://github.com/apache/cassandra-analytics/pull/46 This PR bumps the Sidecar version to the current latest HEAD of Sidecar. Bumping the version surfaced an issue in the LZ4's implementation of the XXHash32 hash value. The hash value is not mas