yifan-c merged PR #63:
URL: https://github.com/apache/cassandra-analytics/pull/63
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@ca
frankgh commented on code in PR #63:
URL:
https://github.com/apache/cassandra-analytics/pull/63#discussion_r1680162785
##
scripts/build-sidecar.sh:
##
@@ -24,7 +24,7 @@ else
SCRIPT_DIR=$( dirname -- "$( readlink -f -- "$0"; )"; )
SIDECAR_REPO="${SIDECAR_REPO:-https://git
frankgh commented on code in PR #63:
URL:
https://github.com/apache/cassandra-analytics/pull/63#discussion_r1680162367
##
cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/utils/MapUtils.java:
##
@@ -239,4 +245,35 @@ public static boolean containsKey(Map
opti
yifan-c commented on code in PR #63:
URL:
https://github.com/apache/cassandra-analytics/pull/63#discussion_r1680080380
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/common/SidecarInstanceFactory.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Sof
yifan-c commented on code in PR #63:
URL:
https://github.com/apache/cassandra-analytics/pull/63#discussion_r1680072271
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/common/SidecarInstanceFactory.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Sof
yifan-c commented on code in PR #63:
URL:
https://github.com/apache/cassandra-analytics/pull/63#discussion_r1680058191
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkSparkConf.java:
##
@@ -146,17 +148,16 @@ public class BulkSparkConf impleme
yifan-c commented on code in PR #63:
URL:
https://github.com/apache/cassandra-analytics/pull/63#discussion_r1680056218
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkSparkConf.java:
##
@@ -240,38 +241,47 @@ protected Set buildBlockedInstance
yifan-c commented on code in PR #63:
URL:
https://github.com/apache/cassandra-analytics/pull/63#discussion_r1680053097
##
cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/utils/MapUtils.java:
##
@@ -239,4 +245,35 @@ public static boolean containsKey(Map
opti
yifan-c commented on code in PR #63:
URL:
https://github.com/apache/cassandra-analytics/pull/63#discussion_r1680052228
##
cassandra-analytics-core/src/test/spark3/org/apache/cassandra/spark/common/SidecarInstanceFactoryTest.java:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apac
frankgh commented on code in PR #63:
URL:
https://github.com/apache/cassandra-analytics/pull/63#discussion_r1680017755
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkSparkConf.java:
##
@@ -146,17 +148,16 @@ public class BulkSparkConf impleme
yifan-c opened a new pull request, #63:
URL: https://github.com/apache/cassandra-analytics/pull/63
This patch introduces a new option SIDECAR_CONTACT_POINTS for both bulk
writer and reader. The option name better describes the purpose, which is to
specify the initial contact points to disco
11 matches
Mail list logo