Re: [PR] JAVA-2967: Support native_transport_(address|port) + native_transport_port_ssl for DSE 6.8 (4.x edition) [cassandra-java-driver]

2024-03-11 Thread via GitHub
absurdfarce commented on PR #1913: URL: https://github.com/apache/cassandra-java-driver/pull/1913#issuecomment-1989604266 With two +1's from committers (mine + @adutra) this ticket was considered eligible to merge. We can't do a squash merge at the moment, however, so we need to resolve

Re: [PR] JAVA-2967: Support native_transport_(address|port) + native_transport_port_ssl for DSE 6.8 (4.x edition) [cassandra-java-driver]

2024-03-08 Thread via GitHub
absurdfarce commented on PR #1913: URL: https://github.com/apache/cassandra-java-driver/pull/1913#issuecomment-1986449928 Can't add my +1 for some reason but I approve this message as well. :) -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] JAVA-2967: Support native_transport_(address|port) + native_transport_port_ssl for DSE 6.8 (4.x edition) [cassandra-java-driver]

2024-02-22 Thread via GitHub
absurdfarce commented on code in PR #1913: URL: https://github.com/apache/cassandra-java-driver/pull/1913#discussion_r1500039158 ## core/src/test/java/com/datastax/oss/driver/internal/core/metadata/DefaultTopologyMonitorTest.java: ## @@ -654,4 +794,12 @@ private void

Re: [PR] JAVA-2967: Support native_transport_(address|port) + native_transport_port_ssl for DSE 6.8 (4.x edition) [cassandra-java-driver]

2024-02-22 Thread via GitHub
absurdfarce commented on code in PR #1913: URL: https://github.com/apache/cassandra-java-driver/pull/1913#discussion_r1499879526 ## core/src/main/java/com/datastax/oss/driver/internal/core/metadata/DefaultTopologyMonitor.java: ## @@ -494,28 +499,50 @@ private void

Re: [PR] JAVA-2967: Support native_transport_(address|port) + native_transport_port_ssl for DSE 6.8 (4.x edition) [cassandra-java-driver]

2024-02-22 Thread via GitHub
absurdfarce commented on code in PR #1913: URL: https://github.com/apache/cassandra-java-driver/pull/1913#discussion_r1499879526 ## core/src/main/java/com/datastax/oss/driver/internal/core/metadata/DefaultTopologyMonitor.java: ## @@ -494,28 +499,50 @@ private void

Re: [PR] JAVA-2967: Support native_transport_(address|port) + native_transport_port_ssl for DSE 6.8 (4.x edition) [cassandra-java-driver]

2024-02-22 Thread via GitHub
aratno commented on code in PR #1913: URL: https://github.com/apache/cassandra-java-driver/pull/1913#discussion_r1499796291 ## core/src/main/java/com/datastax/oss/driver/internal/core/metadata/DefaultTopologyMonitor.java: ## @@ -494,28 +499,50 @@ private void

Re: [PR] JAVA-2967: Support native_transport_(address|port) + native_transport_port_ssl for DSE 6.8 (4.x edition) [cassandra-java-driver]

2024-02-22 Thread via GitHub
absurdfarce commented on code in PR #1913: URL: https://github.com/apache/cassandra-java-driver/pull/1913#discussion_r1499650482 ## core/src/main/java/com/datastax/oss/driver/internal/core/metadata/DefaultTopologyMonitor.java: ## @@ -494,28 +499,50 @@ private void

Re: [PR] JAVA-2967: Support native_transport_(address|port) + native_transport_port_ssl for DSE 6.8 (4.x edition) [cassandra-java-driver]

2024-02-22 Thread via GitHub
absurdfarce commented on code in PR #1913: URL: https://github.com/apache/cassandra-java-driver/pull/1913#discussion_r1499649538 ## core/src/main/java/com/datastax/oss/driver/internal/core/metadata/DefaultTopologyMonitor.java: ## @@ -494,28 +499,50 @@ private void

Re: [PR] JAVA-2967: Support native_transport_(address|port) + native_transport_port_ssl for DSE 6.8 (4.x edition) [cassandra-java-driver]

2024-02-22 Thread via GitHub
absurdfarce commented on code in PR #1913: URL: https://github.com/apache/cassandra-java-driver/pull/1913#discussion_r1499621047 ## core/src/main/java/com/datastax/oss/driver/internal/core/metadata/DefaultTopologyMonitor.java: ## @@ -494,28 +499,50 @@ private void

Re: [PR] JAVA-2967: Support native_transport_(address|port) + native_transport_port_ssl for DSE 6.8 (4.x edition) [cassandra-java-driver]

2024-02-15 Thread via GitHub
aratno commented on code in PR #1913: URL: https://github.com/apache/cassandra-java-driver/pull/1913#discussion_r1491756553 ## core/src/main/java/com/datastax/oss/driver/internal/core/metadata/DefaultTopologyMonitor.java: ## @@ -494,28 +499,50 @@ private void

Re: [PR] JAVA-2967: Support native_transport_(address|port) + native_transport_port_ssl for DSE 6.8 (4.x edition) [cassandra-java-driver]

2024-02-06 Thread via GitHub
absurdfarce commented on PR #1913: URL: https://github.com/apache/cassandra-java-driver/pull/1913#issuecomment-1931019450 Tested this via manual testing against the following configurations: * OSS C*, native_port support provided by @smiklosovic

Re: [PR] JAVA-2967: Support native_transport_(address|port) + native_transport_port_ssl for DSE 6.8 (4.x edition) [cassandra-java-driver]

2024-02-06 Thread via GitHub
absurdfarce commented on code in PR #1913: URL: https://github.com/apache/cassandra-java-driver/pull/1913#discussion_r1480698400 ## core/src/main/java/com/datastax/oss/driver/internal/core/metadata/DefaultTopologyMonitor.java: ## @@ -494,28 +499,50 @@ private void

[PR] JAVA-2967: Support native_transport_(address|port) + native_transport_port_ssl for DSE 6.8 (4.x edition) [cassandra-java-driver]

2024-02-06 Thread via GitHub
absurdfarce opened a new pull request, #1913: URL: https://github.com/apache/cassandra-java-driver/pull/1913 This patch also includes support for native_(address|port) as well as native_port_ssl which are being added to Cassandra. For more information on that aspect of this change take a