Re: [PR] JAVA-3145: Implement some notion of retry logic around call to metadata service for Astra clients [cassandra-java-driver]

2023-12-21 Thread via GitHub
absurdfarce commented on code in PR #1902: URL: https://github.com/apache/cassandra-java-driver/pull/1902#discussion_r1434162481 ## core/src/main/java/com/datastax/oss/driver/internal/core/config/cloud/CloudConfigFactory.java: ## @@ -225,22 +228,51 @@ protected TrustManagerFact

Re: [PR] JAVA-3145: Implement some notion of retry logic around call to metadata service for Astra clients [cassandra-java-driver]

2023-12-20 Thread via GitHub
SiyaoIsHiding commented on code in PR #1902: URL: https://github.com/apache/cassandra-java-driver/pull/1902#discussion_r1433178698 ## core/src/main/java/com/datastax/oss/driver/internal/core/config/cloud/CloudConfigFactory.java: ## @@ -225,22 +228,40 @@ protected TrustManagerFa

Re: [PR] JAVA-3145: Implement some notion of retry logic around call to metadata service for Astra clients [cassandra-java-driver]

2023-12-20 Thread via GitHub
SiyaoIsHiding commented on code in PR #1902: URL: https://github.com/apache/cassandra-java-driver/pull/1902#discussion_r1433158316 ## core/src/main/java/com/datastax/oss/driver/internal/core/config/cloud/CloudConfigFactory.java: ## @@ -225,22 +228,40 @@ protected TrustManagerFa

Re: [PR] JAVA-3145: Implement some notion of retry logic around call to metadata service for Astra clients [cassandra-java-driver]

2023-12-17 Thread via GitHub
absurdfarce commented on PR #1902: URL: https://github.com/apache/cassandra-java-driver/pull/1902#issuecomment-1859640807 Regarding your alternate proposed implementation above @SiyaoIsHiding; I think we probably should prefer the version actually contained in this PR. We know _some_ non-

Re: [PR] JAVA-3145: Implement some notion of retry logic around call to metadata service for Astra clients [cassandra-java-driver]

2023-12-17 Thread via GitHub
absurdfarce commented on code in PR #1902: URL: https://github.com/apache/cassandra-java-driver/pull/1902#discussion_r1429553321 ## core/src/main/java/com/datastax/oss/driver/internal/core/config/cloud/CloudConfigFactory.java: ## @@ -225,22 +228,40 @@ protected TrustManagerFact

[PR] JAVA-3145: Implement some notion of retry logic around call to metadata service for Astra clients [cassandra-java-driver]

2023-12-05 Thread via GitHub
SiyaoIsHiding opened a new pull request, #1902: URL: https://github.com/apache/cassandra-java-driver/pull/1902 I implemented the retry mechanism in two ways. Apart from the current one, the following also works: ```java @NonNull protected BufferedReader fetchProxyMetadata(