[
https://issues.apache.org/jira/browse/CASSANDRA-12244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460524#comment-16460524
]
mck edited comment on CASSANDRA-12244 at 5/3/18 10:33 AM:
----------------------------------------------------------
Patch looks good. Note in trunk it was fixed in a different manner, but the
clash with the human readable flag was still there so I kept the introduction
of the {{Unit}} enum.
I've put your patch into relevant branches, and will commit once they go green.
In the meantime [~jasonstack], could you please check i've applied your patch
appropriately in each branch and commit.
|| Branch || uTest || dTest ||
|[cassandra-3.0_12244|https://github.com/thelastpickle/cassandra/tree/mck/cassandra-3.0_12244]|[!https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Fcassandra-3.0_12244.svg?style=svg!|https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Fcassandra-3.0_12244]|
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/540/
|
|[cassandra-3.11_12244|https://github.com/thelastpickle/cassandra/tree/mck/cassandra-3.11_12244]|[!https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Fcassandra-3.11_12244.svg?style=svg!|https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Fcassandra-3.11_12244]|
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/541/
|
|[trunk_12244|https://github.com/thelastpickle/cassandra/tree/mck/trunk_12244]|[!https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Ftrunk_12244.svg?style=svg!|https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Ftrunk_12244]|
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/542/
|
was (Author: michaelsembwever):
Patch looks good. Note in trunk it was fixed in a different manner, but the
clash with the human readable flag was still there so I kept the introduction
of the {{Unit}} enum.
I've put your patch into relevant branches, and will commit once they go green.
In the meantime [~jasonstack], could you please check i've applied your patch
appropriately in each branch and commit.
|| Branch || uTest || dTest ||
|[cassandra-3.0_12244|https://github.com/thelastpickle/cassandra/tree/mck/cassandra-3.0_12244]|[!https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Fcassandra-3.0_12244.svg?style=svg!|https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Fcassandra-3.0_12244]|
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/540/
|
|[cassandra-3.11_12244|https://github.com/thelastpickle/cassandra/tree/mck/cassandra-3.11_12244]|[!https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Fcassandra-3.11_12244.svg?style=svg!|https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Fcassandra-3.11_12244]|
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/541/
|
|[trunk_12244|https://github.com/thelastpickle/cassandra/tree/mck/trunk_12244]|[!https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Ftrunk_12244.svg?style=svg!|https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Ftrunk_12244]|
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/541/
|
> progress in compactionstats is reported wrongly for view builds
> ---------------------------------------------------------------
>
> Key: CASSANDRA-12244
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12244
> Project: Cassandra
> Issue Type: Bug
> Reporter: Tom van der Woerdt
> Assignee: ZhaoYang
> Priority: Minor
> Labels: lhf
> Fix For: 3.0.x
>
>
> In the view build progress given by compactionstats, there are several issues
> :
> {code}
> id compaction type keyspace
> table completed total unit progress
> 038d3690-4dbe-11e6-b207-21ec388d48e6 View build mykeyspace
> mytable 844 bytes 967 bytes ranges 87.28%
> Active compaction remaining time : n/a
> {code}
> 1) those are ranges, not bytes
> 2) it's not at 87.28%, it's at ~4%. the method for calculating progress in
> Cassandra is wrong: it neglects to sort the tokens it's iterating through
> (ViewBuilder.java) and thus ends up with a random number.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
