[ https://issues.apache.org/jira/browse/CASSANDRA-13163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995711#comment-15995711 ]
Ariel Weisberg edited comment on CASSANDRA-13163 at 5/3/17 10:18 PM: --------------------------------------------------------------------- Committed as [6ed9134336bb48d04284cefd303d8374ed901c0a|https://github.com/apache/cassandra/commit/6ed9134336bb48d04284cefd303d8374ed901c0a] was (Author: aweisberg): Committed as [18b77c3e0b8988956e42b1362eb350dfada27eb0|https://github.com/apache/cassandra/commit/18b77c3e0b8988956e42b1362eb350dfada27eb0] > NPE in StorageService.excise > ---------------------------- > > Key: CASSANDRA-13163 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13163 > Project: Cassandra > Issue Type: Bug > Components: Core > Reporter: Ariel Weisberg > Assignee: Ariel Weisberg > Fix For: 3.0.x, 3.11.x, 4.x > > > {code} > private void excise(Collection<Token> tokens, InetAddress endpoint) > { > logger.info("Removing tokens {} for {}", tokens, endpoint); > if (tokenMetadata.isMember(endpoint)) > HintsService.instance.excise(tokenMetadata.getHostId(endpoint)); > {code} > The check for TMD.isMember() is not enough to guarantee that TMD.getHostId() > will not return null. If HintsService.excise() is called with null you get an > NPE in a map lookup. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org