[ 
https://issues.apache.org/jira/browse/CASSANDRA-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887961#comment-15887961
 ] 

Benjamin Roth edited comment on CASSANDRA-13226 at 2/28/17 1:12 PM:
--------------------------------------------------------------------

Sorry for that many comments, just another thought:

Flushes can be optimized very easily in that way that a flush is only executed 
if the memtable contains mutations for the requested range OR if the memtable 
exceeds a certain size, so that the check is still cheap. I implemented this 
just for fun some months ago but did never create a ticket for it.

See patch here 
https://github.com/Jaumo/cassandra/commit/983514b0d3e15cea042533273ead5ea33c00bacf

Just saw it also disabled pre-repair flush as proposed before.


was (Author: brstgt):
Sorry for that many comments, just another thought:

Flushes can be optimized very easily in that way that a flush is only executed 
if the memtable contains mutations for the requested range OR if the memtable 
exceeds a certain size, so that the check is still cheap. I implemented this 
just for fun some months ago but did never create a ticket for it.

> StreamPlan for incremental repairs flushing memtables unnecessarily
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-13226
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13226
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>            Priority: Minor
>             Fix For: 4.0
>
>
> Since incremental repairs are run against a fixed dataset, there's no need to 
> flush memtables when streaming for them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to