[ 
https://issues.apache.org/jira/browse/CASSANDRA-16892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409579#comment-17409579
 ] 

Benjamin Lerer edited comment on CASSANDRA-16892 at 9/3/21, 3:50 PM:
---------------------------------------------------------------------

I ran the patched {{upgrade_tests/thrift_upgrade_test.py}} using the 
repeated_upgrade_dtest runner 100 times and did not get any failure. Results 
are 
[here|https://app.circleci.com/pipelines/github/blerer/cassandra/195/workflows/a9c26e1f-01e6-4af5-84c3-a0314c08ed59].

The fix looks good. +1

Thanks for the patch [~stefan.miklosovic]


was (Author: blerer):
I ran the patched {{upgrade_tests/thrift_upgrade_test.py}} using the 
repeated_upgrade_dtest runner 100 times and did not get any failure. Results 
are 
[here|https://app.circleci.com/pipelines/github/blerer/cassandra/195/workflows/a9c26e1f-01e6-4af5-84c3-a0314c08ed59].

The fix looks good. +1

> Fix flakiness in upgrade_tests/thrift_upgrade_test.py in dtests
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-16892
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16892
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/dtest/python
>            Reporter: Stefan Miklosovic
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: NA
>
>
> I noticed that tests for dtest in upgrade_tests/thrift_upgrade_test.py are 
> flaky.
> The reason this flakiness happens is that we are stopping and starting a node 
> too fast without waiting for its full initialisation and then next attempt to 
> connect to rpc port fails and whole test fails.
> The fix is rather easy, we just need to wait until it is full started.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to