[ https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686853#comment-17686853 ]
Josh McKenzie edited comment on CASSANDRA-18239 at 2/10/23 4:13 PM: -------------------------------------------------------------------- Little email search turned up this: [https://sonarcloud.io/organizations/apache/projects] The new SonarCloud sounded familiar; pretty sure we used to use that to prevent new stuff getting in before it got deprecated/moved. was (Author: jmckenzie): Little email search turned up this: [https://sonarcloud.io/organizations/apache/projects] New SonarCloud sounded familiar; pretty sure we used to use that to prevent new stuff getting in before it got deprecated/moved. > Remove eclipse warnings task and replace it with something better > ----------------------------------------------------------------- > > Key: CASSANDRA-18239 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18239 > Project: Cassandra > Issue Type: Task > Components: Build > Reporter: Jacek Lewandowski > Priority: Normal > > Eclipse warnings is used for static code analysis. However, it does not fit > well into Cassandra code and practically we end up explicitly adding > suppressions in many places just to satisfy that tool rather than fix the > real issues. > This is an incomplete list of reasons to remove it: > - not closed resources are detected incorrectly > - does not recognize custom utility methods used to close the resources, > which use use heavily in the code, like {{Throwables.close}}, > {{FileUtils.close}}, {{closeQuietly}}... > - because of the above, we cannot make important things like {{Ref}} to > implement {{Closeable}} as it would make the tool to explode with tons of > warnings > - it complains about correct generics - something like "method X is not > applicable for ..." when the code compiles successfully is not acceptable > - it is old and not maintained > There are better tools like IntelliJ inspections for example, which can also > be run in headless mode -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org