[
https://issues.apache.org/jira/browse/CASSANDRA-12179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401401#comment-15401401
]
sankalp kohli commented on CASSANDRA-12179:
---
LGTM
> Make DynamicEndpointS
[
https://issues.apache.org/jira/browse/CASSANDRA-12179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401148#comment-15401148
]
Robert Stupp commented on CASSANDRA-12179:
--
Forgot to mention: Generally thi
[
https://issues.apache.org/jira/browse/CASSANDRA-12179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401141#comment-15401141
]
Robert Stupp commented on CASSANDRA-12179:
--
Some more comments:
* The {{if}
[
https://issues.apache.org/jira/browse/CASSANDRA-12179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387196#comment-15387196
]
Robert Stupp commented on CASSANDRA-12179:
--
CI results:
||trunk|[branch|http
[
https://issues.apache.org/jira/browse/CASSANDRA-12179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385183#comment-15385183
]
Robert Stupp commented on CASSANDRA-12179:
--
Looks good so far. Let me play w
[
https://issues.apache.org/jira/browse/CASSANDRA-12179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383310#comment-15383310
]
sankalp kohli commented on CASSANDRA-12179:
---
Attaching v3 using update snit
[
https://issues.apache.org/jira/browse/CASSANDRA-12179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382033#comment-15382033
]
Robert Stupp commented on CASSANDRA-12179:
--
I think the instanceof check is
[
https://issues.apache.org/jira/browse/CASSANDRA-12179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381562#comment-15381562
]
sankalp kohli commented on CASSANDRA-12179:
---
Attached v2. I am not sure how
[
https://issues.apache.org/jira/browse/CASSANDRA-12179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376038#comment-15376038
]
Robert Stupp commented on CASSANDRA-12179:
--
Can you expose the setting via t
