[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178679#comment-16178679
]
Alex Petrov commented on CASSANDRA-12373:
-
Thank you for the thorough review & patience
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176453#comment-16176453
]
Aleksey Yeschenko commented on CASSANDRA-12373:
---
And thanks from me to you both. I had
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176370#comment-16176370
]
Sylvain Lebresne commented on CASSANDRA-12373:
--
Well, that's a +1 from me. Great job
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173016#comment-16173016
]
Alex Petrov commented on CASSANDRA-12373:
-
bq. Thanks for the changes and you patience on
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172976#comment-16172976
]
Sylvain Lebresne commented on CASSANDRA-12373:
--
Thanks for the changes and you patience
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172137#comment-16172137
]
Aleksey Yeschenko commented on CASSANDRA-12373:
---
It's a case of better late than never.
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172132#comment-16172132
]
sankalp kohli commented on CASSANDRA-12373:
---
Is this not too late for 3.0?
> 3.0 breaks
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166050#comment-16166050
]
Alex Petrov commented on CASSANDRA-12373:
-
Thank you for the review and comments.
I agree
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163085#comment-16163085
]
Sylvain Lebresne commented on CASSANDRA-12373:
--
The one main remaining things I'm not
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160985#comment-16160985
]
Alex Petrov commented on CASSANDRA-12373:
-
bq. In the ctor, for isDense, we seem to force
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153401#comment-16153401
]
Sylvain Lebresne commented on CASSANDRA-12373:
--
Thanks for the update and great job on
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146940#comment-16146940
]
Alex Petrov commented on CASSANDRA-12373:
-
[~slebresne] thank you for the review.
I have
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138397#comment-16138397
]
Jeremiah Jordan commented on CASSANDRA-12373:
-
bq. That's where CASSANDRA-10857 come in,
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138350#comment-16138350
]
Sylvain Lebresne commented on CASSANDRA-12373:
--
bq. but in 3.x we started exposing the
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137056#comment-16137056
]
Jeremiah Jordan commented on CASSANDRA-12373:
-
bq. I'll note at this point that the "why"
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137023#comment-16137023
]
Sylvain Lebresne commented on CASSANDRA-12373:
--
The general approach lgtm, but I think
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094434#comment-16094434
]
Alex Petrov commented on CASSANDRA-12373:
-
Rebased on top of {{3.0}} and {{3.11}}. Since
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024948#comment-16024948
]
Aleksey Yeschenko commented on CASSANDRA-12373:
---
Tests LGTM, feel free to commit them
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761691#comment-15761691
]
Alex Petrov commented on CASSANDRA-12373:
-
Previous patch had problems with renames of dense
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15701923#comment-15701923
]
Alex Petrov commented on CASSANDRA-12373:
-
Rebased all branches, links are updated above.
>
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15693869#comment-15693869
]
Aleksey Yeschenko commented on CASSANDRA-12373:
---
Reviewing this next. Can you please
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608436#comment-15608436
]
Alex Petrov commented on CASSANDRA-12373:
-
I've added a possible fix for that. In order to
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15606282#comment-15606282
]
Alex Petrov commented on CASSANDRA-12373:
-
You're right, I've just checked and it is in fact
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15606191#comment-15606191
]
Aleksey Yeschenko commented on CASSANDRA-12373:
---
bq. These columns are not persisted
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592857#comment-15592857
]
Alex Petrov commented on CASSANDRA-12373:
-
Thank you. LWTs [didn't
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592068#comment-15592068
]
Aleksey Yeschenko commented on CASSANDRA-12373:
---
bq. Should we include support for
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591861#comment-15591861
]
Alex Petrov commented on CASSANDRA-12373:
-
I've implemented a _preliminary_ version of the
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585042#comment-15585042
]
Alex Petrov commented on CASSANDRA-12373:
-
[~slebresne] [~iamaleksey] do we want to also
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571299#comment-15571299
]
Alex Petrov commented on CASSANDRA-12373:
-
While discussing [CASSANDRA-7190], we decided to
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571193#comment-15571193
]
Sylvain Lebresne commented on CASSANDRA-12373:
--
bq. What we want/need to do re:schema is
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568953#comment-15568953
]
Aleksey Yeschenko commented on CASSANDRA-12373:
---
What we want/need to do re:schema is
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568968#comment-15568968
]
Jeremiah Jordan commented on CASSANDRA-12373:
-
Don't forget the "snapshot" schema
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568868#comment-15568868
]
Alex Petrov commented on CASSANDRA-12373:
-
bq. Actually, we don't want to touch the schema.
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568738#comment-15568738
]
Sylvain Lebresne commented on CASSANDRA-12373:
--
bq. We would like to change the way
[
https://issues.apache.org/jira/browse/CASSANDRA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1025#comment-1025
]
Alex Petrov commented on CASSANDRA-12373:
-
I've started collecting information on what needs
35 matches
Mail list logo