[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937125#comment-15937125
]
Joel Knighton commented on CASSANDRA-12653:
---
Committed to 2.2 as
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15907535#comment-15907535
]
Joel Knighton commented on CASSANDRA-12653:
---
I planned on leaving that honor to
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906881#comment-15906881
]
Jeff Jirsa commented on CASSANDRA-12653:
Which of you two new committers (congrats!) feels
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903212#comment-15903212
]
Joel Knighton commented on CASSANDRA-12653:
---
Sure - while I'd argue that a need for a
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902788#comment-15902788
]
Stefan Podkowinski commented on CASSANDRA-12653:
The value might be effectively
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892772#comment-15892772
]
Joel Knighton commented on CASSANDRA-12653:
---
Thanks! The latest changes look good -
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890169#comment-15890169
]
Jason Brown commented on CASSANDRA-12653:
-
Nice work, +1. [~jkni] Do you want to give this
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889785#comment-15889785
]
Stefan Podkowinski commented on CASSANDRA-12653:
As for the firstSynSendAt timestamp,
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884235#comment-15884235
]
Jason Brown commented on CASSANDRA-12653:
-
[~spod] I'm on board with {{firstSynSendAt}} being
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883114#comment-15883114
]
Joel Knighton commented on CASSANDRA-12653:
---
Do those answers address your questions well
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880207#comment-15880207
]
Stefan Podkowinski commented on CASSANDRA-12653:
The goal of introducing the
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878461#comment-15878461
]
Joel Knighton commented on CASSANDRA-12653:
---
I think I can answer these - feel free to
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878356#comment-15878356
]
Jason Brown commented on CASSANDRA-12653:
-
Also, I'm not sure {{Gossiper#doShadowRound}}
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878328#comment-15878328
]
Jason Brown commented on CASSANDRA-12653:
-
On the whole, I'm pretty good with this patch -
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874646#comment-15874646
]
Stefan Podkowinski commented on CASSANDRA-12653:
Thanks for your comments, Joel!
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866010#comment-15866010
]
Jeff Jirsa commented on CASSANDRA-12653:
Fair points all around. I've deployed this as-is
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865504#comment-15865504
]
Stefan Podkowinski commented on CASSANDRA-12653:
bq. Stefan Podkowinski - is there
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864426#comment-15864426
]
Jeff Jirsa commented on CASSANDRA-12653:
[~spo...@gmail.com] - is there some deeper purpose
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863233#comment-15863233
]
Joel Knighton commented on CASSANDRA-12653:
---
[~jjirsa] - yes. That said, I don't anticipate
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862255#comment-15862255
]
Jeff Jirsa commented on CASSANDRA-12653:
[~jkni] - this still on your radar?
> In-flight
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818707#comment-15818707
]
Joel Knighton commented on CASSANDRA-12653:
---
Thanks for the quick response; I agree with
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818621#comment-15818621
]
Stefan Podkowinski commented on CASSANDRA-12653:
The firstSynSendAt value is only set
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815325#comment-15815325
]
Joshua McKenzie commented on CASSANDRA-12653:
-
What's status here [~jkni]?
> In-flight
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15637549#comment-15637549
]
Joel Knighton commented on CASSANDRA-12653:
---
[~spo...@gmail.com] - yes! I sincerely
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632105#comment-15632105
]
Stefan Podkowinski commented on CASSANDRA-12653:
Are you still planing to review the
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513406#comment-15513406
]
Stefan Podkowinski commented on CASSANDRA-12653:
The attached patch will solve this
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503294#comment-15503294
]
Stefan Podkowinski commented on CASSANDRA-12653:
I think we can get around changing
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502472#comment-15502472
]
Stefania commented on CASSANDRA-12653:
--
It's been a while since I've looked at this, but I agree
[
https://issues.apache.org/jira/browse/CASSANDRA-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496613#comment-15496613
]
Joel Knighton commented on CASSANDRA-12653:
---
You are definitely correct about the cause of
29 matches
Mail list logo
