[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216632#comment-16216632
]
Sam Tunnicliffe commented on CASSANDRA-13291:
-
[~mkjellman] thanks for that, I think it
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216001#comment-16216001
]
Michael Kjellman commented on CASSANDRA-13291:
--
[~beobal] The profiling I did was with
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210977#comment-16210977
]
Jason Brown commented on CASSANDRA-13291:
-
Let's leave CASSANDRA-13964 out of this patch as
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210932#comment-16210932
]
Sam Tunnicliffe commented on CASSANDRA-13291:
-
The comment in {{o.a.c.utils.MD5Digest}}
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209970#comment-16209970
]
Michael Kjellman commented on CASSANDRA-13291:
--
Alright, after chatting a bit with Sam
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209259#comment-16209259
]
Jason Brown commented on CASSANDRA-13291:
-
[~beobal] Hmm, you are correct, and I can repro
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209220#comment-16209220
]
Sam Tunnicliffe commented on CASSANDRA-13291:
-
This breaks stuff in schema updates when
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208858#comment-16208858
]
Jason Brown commented on CASSANDRA-13291:
-
bq. the reason we got here is because of the fact
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208855#comment-16208855
]
Michael Kjellman commented on CASSANDRA-13291:
--
Re: the {{newHasher()}} stuff, I agree
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208846#comment-16208846
]
Jason Brown commented on CASSANDRA-13291:
-
[~beobal] Thanks for doing the hard part of this
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208811#comment-16208811
]
Jason Brown commented on CASSANDRA-13291:
-
Pulled [~mkjellman]'s patch into a fresh branch
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208533#comment-16208533
]
Michael Kjellman commented on CASSANDRA-13291:
--
[~beobal] wow absolute total typo!!
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208136#comment-16208136
]
Sam Tunnicliffe commented on CASSANDRA-13291:
-
bq.I'm not sure I see how the latest
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207853#comment-16207853
]
Michael Kjellman commented on CASSANDRA-13291:
--
[~beobal] yeah, originally i left the
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207505#comment-16207505
]
Sam Tunnicliffe commented on CASSANDRA-13291:
-
{{RandomPartitioner::hashToBigInteger}} is
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207137#comment-16207137
]
Michael Kjellman commented on CASSANDRA-13291:
--
[~jasobrown]
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184029#comment-16184029
]
Jason Brown commented on CASSANDRA-13291:
-
I'm +1 on the code. [~mkjellman] wdyt about
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16183552#comment-16183552
]
Michael Kjellman commented on CASSANDRA-13291:
--
Correct:
{{Hashing.md5()}} internally
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16183505#comment-16183505
]
Jason Brown commented on CASSANDRA-13291:
-
A [slightly
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16183400#comment-16183400
]
Jason Brown commented on CASSANDRA-13291:
-
I knocked out a quick [JMH
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16183191#comment-16183191
]
Jason Brown commented on CASSANDRA-13291:
-
fwiw, I've kicked off utests and dtests here:
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182245#comment-16182245
]
Robert Stupp commented on CASSANDRA-13291:
--
[~mkjellman] I probably won't find time to
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181674#comment-16181674
]
Michael Kjellman commented on CASSANDRA-13291:
--
[~snazy] let me know if you have a
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181672#comment-16181672
]
Michael Kjellman commented on CASSANDRA-13291:
--
Finally got some time to work on this
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15933567#comment-15933567
]
Michael Kjellman commented on CASSANDRA-13291:
--
[~snazy] sorry for the delay replying. I
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929784#comment-15929784
]
Robert Stupp commented on CASSANDRA-13291:
--
bq.
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923160#comment-15923160
]
Michael Kjellman commented on CASSANDRA-13291:
--
* re:
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923129#comment-15923129
]
Michael Kjellman commented on CASSANDRA-13291:
--
Thanks Robert!
I've pushed up the
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906159#comment-15906159
]
Robert Stupp commented on CASSANDRA-13291:
--
[~mkjellman], the patch doesn't cleanly apply to
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903856#comment-15903856
]
Michael Kjellman commented on CASSANDRA-13291:
--
[~snazy] any chance you want to review
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894759#comment-15894759
]
Michael Kjellman commented on CASSANDRA-13291:
--
>From Hashing.java
{code}
private static
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894754#comment-15894754
]
Robert Stupp commented on CASSANDRA-13291:
--
Fair enough. Thought Guava has an alternative
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894744#comment-15894744
]
Michael Kjellman commented on CASSANDRA-13291:
--
[~snazy] I haven't benchmarked trunk
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894050#comment-15894050
]
Robert Stupp commented on CASSANDRA-13291:
--
[~mkjellman] can you provide some micro
[
https://issues.apache.org/jira/browse/CASSANDRA-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893149#comment-15893149
]
Michael Kjellman commented on CASSANDRA-13291:
--
Created CASSANDRA-13292 to track the
35 matches
Mail list logo