[jira] [Commented] (CASSANDRA-13906) Properly close StreamCompressionInputStream to release any ByteBuf

2017-09-26 Thread Jason Brown (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-13906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181752#comment-16181752 ] Jason Brown commented on CASSANDRA-13906: - The cause of the leaked {{ByteBuf}

[jira] [Commented] (CASSANDRA-13906) Properly close StreamCompressionInputStream to release any ByteBuf

2017-09-29 Thread Ariel Weisberg (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-13906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16186051#comment-16186051 ] Ariel Weisberg commented on CASSANDRA-13906: So to bikeshed this all to h

[jira] [Commented] (CASSANDRA-13906) Properly close StreamCompressionInputStream to release any ByteBuf

2017-09-29 Thread Jason Brown (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-13906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16186066#comment-16186066 ] Jason Brown commented on CASSANDRA-13906: - bq. Wouldn't the most idiomatic wa

[jira] [Commented] (CASSANDRA-13906) Properly close StreamCompressionInputStream to release any ByteBuf

2017-09-29 Thread Ariel Weisberg (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-13906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16186087#comment-16186087 ] Ariel Weisberg commented on CASSANDRA-13906: If you implement Closable it

[jira] [Commented] (CASSANDRA-13906) Properly close StreamCompressionInputStream to release any ByteBuf

2017-09-29 Thread Jason Brown (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-13906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16186149#comment-16186149 ] Jason Brown commented on CASSANDRA-13906: - OK, I pushed up a fresh branch usi

[jira] [Commented] (CASSANDRA-13906) Properly close StreamCompressionInputStream to release any ByteBuf

2017-09-29 Thread Ariel Weisberg (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-13906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16186310#comment-16186310 ] Ariel Weisberg commented on CASSANDRA-13906: Is releasing references to a

[jira] [Commented] (CASSANDRA-13906) Properly close StreamCompressionInputStream to release any ByteBuf

2017-09-29 Thread Jason Brown (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-13906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16186600#comment-16186600 ] Jason Brown commented on CASSANDRA-13906: - bq. Isn't that kind of abusing the

[jira] [Commented] (CASSANDRA-13906) Properly close StreamCompressionInputStream to release any ByteBuf

2017-10-02 Thread Ariel Weisberg (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-13906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188968#comment-16188968 ] Ariel Weisberg commented on CASSANDRA-13906: I agree reference counting i

[jira] [Commented] (CASSANDRA-13906) Properly close StreamCompressionInputStream to release any ByteBuf

2017-10-03 Thread Ariel Weisberg (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-13906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190107#comment-16190107 ] Ariel Weisberg commented on CASSANDRA-13906: +1 > Properly close StreamC

[jira] [Commented] (CASSANDRA-13906) Properly close StreamCompressionInputStream to release any ByteBuf

2017-10-03 Thread Jason Brown (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-13906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190153#comment-16190153 ] Jason Brown commented on CASSANDRA-13906: - [~aweisberg] and I discussed offli

[jira] [Commented] (CASSANDRA-13906) Properly close StreamCompressionInputStream to release any ByteBuf

2017-10-03 Thread Jason Brown (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-13906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190184#comment-16190184 ] Jason Brown commented on CASSANDRA-13906: - committed as sha {{982ab93a2f8a0f5