[jira] [Commented] (CASSANDRA-14467) Add option to sanity check tombstones on reads/compaction

[ https://issues.apache.org/jira/browse/CASSANDRA-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628462#comment-16628462 ] ASF GitHub Bot commented on CASSANDRA-14467: Github user asfgit closed the pull request

[jira] [Commented] (CASSANDRA-14467) Add option to sanity check tombstones on reads/compaction

[ https://issues.apache.org/jira/browse/CASSANDRA-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622416#comment-16622416 ] Ariel Weisberg commented on CASSANDRA-14467: Seems like I dropped the ball here. +1

[jira] [Commented] (CASSANDRA-14467) Add option to sanity check tombstones on reads/compaction

[ https://issues.apache.org/jira/browse/CASSANDRA-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526064#comment-16526064 ] Marcus Eriksson commented on CASSANDRA-14467: - yeah, waiting for you to review the dtest

[jira] [Commented] (CASSANDRA-14467) Add option to sanity check tombstones on reads/compaction

[ https://issues.apache.org/jira/browse/CASSANDRA-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525347#comment-16525347 ] Ariel Weisberg commented on CASSANDRA-14467: Committed but still set to patch available?

[jira] [Commented] (CASSANDRA-14467) Add option to sanity check tombstones on reads/compaction

[ https://issues.apache.org/jira/browse/CASSANDRA-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502436#comment-16502436 ] Marcus Eriksson commented on CASSANDRA-14467: - not that I know of, people will need to

[jira] [Commented] (CASSANDRA-14467) Add option to sanity check tombstones on reads/compaction

[ https://issues.apache.org/jira/browse/CASSANDRA-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502425#comment-16502425 ] Ariel Weisberg commented on CASSANDRA-14467: The thing about the dtest changes is that

[jira] [Commented] (CASSANDRA-14467) Add option to sanity check tombstones on reads/compaction

[ https://issues.apache.org/jira/browse/CASSANDRA-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502412#comment-16502412 ] Marcus Eriksson commented on CASSANDRA-14467: - [~aweisberg] did you review the dtest

[jira] [Commented] (CASSANDRA-14467) Add option to sanity check tombstones on reads/compaction

[ https://issues.apache.org/jira/browse/CASSANDRA-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502411#comment-16502411 ] ASF GitHub Bot commented on CASSANDRA-14467: GitHub user krummas opened a pull request:

[jira] [Commented] (CASSANDRA-14467) Add option to sanity check tombstones on reads/compaction

[ https://issues.apache.org/jira/browse/CASSANDRA-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502109#comment-16502109 ] Ariel Weisberg commented on CASSANDRA-14467: +1 with the latest changes. > Add option

[jira] [Commented] (CASSANDRA-14467) Add option to sanity check tombstones on reads/compaction

[ https://issues.apache.org/jira/browse/CASSANDRA-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498155#comment-16498155 ] Ariel Weisberg commented on CASSANDRA-14467: Only remaining nit is that when you reset

[jira] [Commented] (CASSANDRA-14467) Add option to sanity check tombstones on reads/compaction

[ https://issues.apache.org/jira/browse/CASSANDRA-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497918#comment-16497918 ] Marcus Eriksson commented on CASSANDRA-14467: - bq. why is this not just an assertion? It

[jira] [Commented] (CASSANDRA-14467) Add option to sanity check tombstones on reads/compaction

[ https://issues.apache.org/jira/browse/CASSANDRA-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496749#comment-16496749 ] Ariel Weisberg commented on CASSANDRA-14467: I'm a little late thinking of this, but why

[jira] [Commented] (CASSANDRA-14467) Add option to sanity check tombstones on reads/compaction

[ https://issues.apache.org/jira/browse/CASSANDRA-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496542#comment-16496542 ] Marcus Eriksson commented on CASSANDRA-14467: - pushed a new commit which throws

[jira] [Commented] (CASSANDRA-14467) Add option to sanity check tombstones on reads/compaction

[ https://issues.apache.org/jira/browse/CASSANDRA-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496392#comment-16496392 ] Marcus Eriksson commented on CASSANDRA-14467: - Pushed a dtest branch

[jira] [Commented] (CASSANDRA-14467) Add option to sanity check tombstones on reads/compaction

[ https://issues.apache.org/jira/browse/CASSANDRA-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495476#comment-16495476 ] Ariel Weisberg commented on CASSANDRA-14467: Created a pull request with review comments

[jira] [Commented] (CASSANDRA-14467) Add option to sanity check tombstones on reads/compaction

[ https://issues.apache.org/jira/browse/CASSANDRA-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490666#comment-16490666 ] Marcus Eriksson commented on CASSANDRA-14467: - [~cscotta] yes, correct, it also checks if

[jira] [Commented] (CASSANDRA-14467) Add option to sanity check tombstones on reads/compaction

[ https://issues.apache.org/jira/browse/CASSANDRA-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489734#comment-16489734 ] C. Scott Andreas commented on CASSANDRA-14467: -- Thanks Marcus! To confirm my