[jira] [Commented] (CASSANDRA-15059) Gossiper#markAlive can race with Gossiper#markDead

2019-04-22 Thread Ariel Weisberg (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823472#comment-16823472 ] Ariel Weisberg commented on CASSANDRA-15059: +1 with one nit. For NoSpamLogger use the

[jira] [Commented] (CASSANDRA-15059) Gossiper#markAlive can race with Gossiper#markDead

2019-04-22 Thread Blake Eggleston (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823466#comment-16823466 ] Blake Eggleston commented on CASSANDRA-15059: - bq. quarantineEndpoint and

[jira] [Commented] (CASSANDRA-15059) Gossiper#markAlive can race with Gossiper#markDead

2019-04-22 Thread Ariel Weisberg (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823419#comment-16823419 ] Ariel Weisberg commented on CASSANDRA-15059: Oops, hit add early. {{applyNewStates}} is

[jira] [Commented] (CASSANDRA-15059) Gossiper#markAlive can race with Gossiper#markDead

2019-04-22 Thread Ariel Weisberg (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823408#comment-16823408 ] Ariel Weisberg commented on CASSANDRA-15059: Great! {{quarantineEndpoint}} and

[jira] [Commented] (CASSANDRA-15059) Gossiper#markAlive can race with Gossiper#markDead

2019-04-22 Thread Blake Eggleston (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823290#comment-16823290 ] Blake Eggleston commented on CASSANDRA-15059: - I opened CASSANDRA-15095 as a follow on

[jira] [Commented] (CASSANDRA-15059) Gossiper#markAlive can race with Gossiper#markDead

2019-04-18 Thread Blake Eggleston (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821569#comment-16821569 ] Blake Eggleston commented on CASSANDRA-15059: - I've updated my branches with the runtime

[jira] [Commented] (CASSANDRA-15059) Gossiper#markAlive can race with Gossiper#markDead

2019-04-12 Thread Ariel Weisberg (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816665#comment-16816665 ] Ariel Weisberg commented on CASSANDRA-15059: I think that's a good way to resolve the

[jira] [Commented] (CASSANDRA-15059) Gossiper#markAlive can race with Gossiper#markDead

2019-04-11 Thread Blake Eggleston (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815537#comment-16815537 ] Blake Eggleston commented on CASSANDRA-15059: - Maybe we could compromise a bit here.

[jira] [Commented] (CASSANDRA-15059) Gossiper#markAlive can race with Gossiper#markDead

2019-04-09 Thread Blake Eggleston (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813615#comment-16813615 ] Blake Eggleston commented on CASSANDRA-15059: - I think both of these changes are worth

[jira] [Commented] (CASSANDRA-15059) Gossiper#markAlive can race with Gossiper#markDead

2019-04-08 Thread Ariel Weisberg (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812971#comment-16812971 ] Ariel Weisberg commented on CASSANDRA-15059: It will and it won't fix it. We will know

[jira] [Commented] (CASSANDRA-15059) Gossiper#markAlive can race with Gossiper#markDead

2019-04-08 Thread Blake Eggleston (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812769#comment-16812769 ] Blake Eggleston commented on CASSANDRA-15059: - {quote} Future wise this doesn't do

[jira] [Commented] (CASSANDRA-15059) Gossiper#markAlive can race with Gossiper#markDead

2019-03-27 Thread Ariel Weisberg (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803221#comment-16803221 ] Ariel Weisberg commented on CASSANDRA-15059: Well as part of this ticket. There is a

[jira] [Commented] (CASSANDRA-15059) Gossiper#markAlive can race with Gossiper#markDead

2019-03-27 Thread Blake Eggleston (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803112#comment-16803112 ] Blake Eggleston commented on CASSANDRA-15059: - {quote} Future wise this doesn't do

[jira] [Commented] (CASSANDRA-15059) Gossiper#markAlive can race with Gossiper#markDead

2019-03-27 Thread Ariel Weisberg (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802986#comment-16802986 ] Ariel Weisberg commented on CASSANDRA-15059: Finished my review. I can't tell what

[jira] [Commented] (CASSANDRA-15059) Gossiper#markAlive can race with Gossiper#markDead

2019-03-25 Thread Ariel Weisberg (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801210#comment-16801210 ] Ariel Weisberg commented on CASSANDRA-15059: Also if these methods are supposed to be

[jira] [Commented] (CASSANDRA-15059) Gossiper#markAlive can race with Gossiper#markDead

2019-03-25 Thread Ariel Weisberg (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801208#comment-16801208 ] Ariel Weisberg commented on CASSANDRA-15059: [You don't need to create a