[ https://issues.apache.org/jira/browse/CASSANDRA-15143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849604#comment-16849604 ]
Stefan Podkowinski commented on CASSANDRA-15143: ------------------------------------------------ * [CASSANDRA-15143|https://github.com/spodkowinski/cassandra/tree/CASSANDRA-15143] * [Tests|https://circleci.com/gh/spodkowinski/workflows/cassandra/tree/CASSANDRA-15143] > Remove assertion on file deletion to trigger failure policy > ----------------------------------------------------------- > > Key: CASSANDRA-15143 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15143 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable > Reporter: Stefan Podkowinski > Assignee: Stefan Podkowinski > Priority: Normal > > Deleting any files by using FileUtils.deleteWithConfirm() will involve > checking for file existence using an assertion. If the assertion passes, any > errors from the actual Files.delete() operation will get handled as a > FSWriteError and invoke the DiskFailurePolicy. This will get us to a > situation where only some cases of bad FS or disk issues will be handed by > the DFP, while FS issues that may already cause the file.exists() assertion > to fail, will only manifest as AssertionErrors. We should invoke DFP for the > later as well and remove the assertion altogether. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org