[
https://issues.apache.org/jira/browse/CASSANDRA-15202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1689#comment-1689
]
Marcus Eriksson commented on CASSANDRA-15202:
-
+1
> Deserialize merkle trees off-heap
>
[
https://issues.apache.org/jira/browse/CASSANDRA-15202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898884#comment-16898884
]
Aleksey Yeschenko commented on CASSANDRA-15202:
---
bq. One micro-nit: It would be nice
[
https://issues.apache.org/jira/browse/CASSANDRA-15202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898705#comment-16898705
]
Marcus Eriksson commented on CASSANDRA-15202:
-
we also need to release the trees after
[
https://issues.apache.org/jira/browse/CASSANDRA-15202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898182#comment-16898182
]
Benedict commented on CASSANDRA-15202:
--
One micro-nit: It would be nice to statically import
[
https://issues.apache.org/jira/browse/CASSANDRA-15202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895071#comment-16895071
]
Marcus Eriksson commented on CASSANDRA-15202:
-
* I think we need a null check
[
https://issues.apache.org/jira/browse/CASSANDRA-15202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891761#comment-16891761
]
Aleksey Yeschenko commented on CASSANDRA-15202:
---
Cheers. Addressed most in a separate
[
https://issues.apache.org/jira/browse/CASSANDRA-15202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885370#comment-16885370
]
Benedict commented on CASSANDRA-15202:
--
LGTM. Some minor suggestions:
* Use
[
https://issues.apache.org/jira/browse/CASSANDRA-15202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879413#comment-16879413
]
Jeff Jirsa commented on CASSANDRA-15202:
Perf testing of this patch, using JMX toggling to
