[
https://issues.apache.org/jira/browse/CASSANDRA-15445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993322#comment-16993322
]
Jordan West commented on CASSANDRA-15445:
-----------------------------------------
+1. LGTM. The unit tests failures look unrelated and likely flaky. It could be
worth running the jdk11 tests as well. One minor suggestion, totally optional:
for future readers, it might be nice to have some comments in
{{testDisableSTCSInL0}}. E.g. "setup some sstables in L1 that should be the
first compaction candidates after STCS in L0 is disabled" and "create a bunch
of sstables in L0 so it looks behind".
> Make it possible to disable STCS-in-L0 during runtime
> -----------------------------------------------------
>
> Key: CASSANDRA-15445
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15445
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Compaction
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Normal
> Fix For: 4.x
>
>
> It should be possible for operators to disable STCS-in-L0 without bouncing
> the node.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
