[jira] [Commented] (CASSANDRA-18283) Enhance diagnostic nodetool tablestats output

2023-03-24 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704615#comment-17704615 ] Brandon Williams commented on CASSANDRA-18283: -- I'm not sure we can do that in minors

[jira] [Commented] (CASSANDRA-18283) Enhance diagnostic nodetool tablestats output

2023-03-24 Thread Brad Schoening (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704613#comment-17704613 ] Brad Schoening commented on CASSANDRA-18283: [~smiklosovic] would it be possible to port

[jira] [Commented] (CASSANDRA-18283) Enhance diagnostic nodetool tablestats output

2023-03-06 Thread Brad Schoening (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697048#comment-17697048 ] Brad Schoening commented on CASSANDRA-18283: LGTM, +1 > Enhance diagnostic nodetool

[jira] [Commented] (CASSANDRA-18283) Enhance diagnostic nodetool tablestats output

2023-03-06 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697022#comment-17697022 ] Brandon Williams commented on CASSANDRA-18283: -- LGTM, +1. This probably worthy of a

[jira] [Commented] (CASSANDRA-18283) Enhance diagnostic nodetool tablestats output

2023-03-02 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695894#comment-17695894 ] Stefan Miklosovic commented on CASSANDRA-18283: --- j11 pre-commit

[jira] [Commented] (CASSANDRA-18283) Enhance diagnostic nodetool tablestats output

2023-03-02 Thread Brad Schoening (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695821#comment-17695821 ] Brad Schoening commented on CASSANDRA-18283: [~smiklosovic] Compression Ratio not

[jira] [Commented] (CASSANDRA-18283) Enhance diagnostic nodetool tablestats output

2023-03-02 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695685#comment-17695685 ] Stefan Miklosovic commented on CASSANDRA-18283: --- Ok. I also noticed some minor

[jira] [Commented] (CASSANDRA-18283) Enhance diagnostic nodetool tablestats output

2023-03-02 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695667#comment-17695667 ] Brandon Williams commented on CASSANDRA-18283: -- I think doing it here is fine. >

[jira] [Commented] (CASSANDRA-18283) Enhance diagnostic nodetool tablestats output

2023-03-02 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695651#comment-17695651 ] Stefan Miklosovic commented on CASSANDRA-18283: --- I have also added sorting by this

[jira] [Commented] (CASSANDRA-18283) Enhance diagnostic nodetool tablestats output

2023-03-01 Thread Brad Schoening (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695332#comment-17695332 ] Brad Schoening commented on CASSANDRA-18283: Look great +1 > Enhance diagnostic

[jira] [Commented] (CASSANDRA-18283) Enhance diagnostic nodetool tablestats output

2023-03-01 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695309#comment-17695309 ] Stefan Miklosovic commented on CASSANDRA-18283: --- sureĀ  {code:java} $ ./bin/nodetool

[jira] [Commented] (CASSANDRA-18283) Enhance diagnostic nodetool tablestats output

2023-03-01 Thread Brad Schoening (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695283#comment-17695283 ] Brad Schoening commented on CASSANDRA-18283: [~smiklosovic] the PR looks good to me, is

[jira] [Commented] (CASSANDRA-18283) Enhance diagnostic nodetool tablestats output

2023-02-28 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694749#comment-17694749 ] Stefan Miklosovic commented on CASSANDRA-18283: --- Interesting. So on tables without

[jira] [Commented] (CASSANDRA-18283) Enhance diagnostic nodetool tablestats output

2023-02-28 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694747#comment-17694747 ] Brandon Williams commented on CASSANDRA-18283: -- That's the default epoch, I'm sure

[jira] [Commented] (CASSANDRA-18283) Enhance diagnostic nodetool tablestats output

2023-02-28 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694742#comment-17694742 ] Stefan Miklosovic commented on CASSANDRA-18283: --- I will not look there upon for

[jira] [Commented] (CASSANDRA-18283) Enhance diagnostic nodetool tablestats output

2023-02-28 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694740#comment-17694740 ] Brandon Williams commented on CASSANDRA-18283: -- Why are you looking at system tables

[jira] [Commented] (CASSANDRA-18283) Enhance diagnostic nodetool tablestats output

2023-02-28 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694738#comment-17694738 ] Stefan Miklosovic commented on CASSANDRA-18283: --- {code:java} $ $

[jira] [Commented] (CASSANDRA-18283) Enhance diagnostic nodetool tablestats output

2023-02-28 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694737#comment-17694737 ] Stefan Miklosovic commented on CASSANDRA-18283: --- [~bschoeni] That is all fine but try

[jira] [Commented] (CASSANDRA-18283) Enhance diagnostic nodetool tablestats output

2023-02-28 Thread Brad Schoening (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694636#comment-17694636 ] Brad Schoening commented on CASSANDRA-18283: The Instaclustr code uses this to compute

[jira] [Commented] (CASSANDRA-18283) Enhance diagnostic nodetool tablestats output

2023-02-28 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694628#comment-17694628 ] Stefan Miklosovic commented on CASSANDRA-18283: --- I am stuck, it is not so easy to