[jira] [Commented] (CASSANDRA-18742) Remove deprecated options in CompressionParams

2023-10-16 Thread Maxim Muzafarov (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775809#comment-17775809 ] Maxim Muzafarov commented on CASSANDRA-18742: - +1 from me, I've checked the changes

[jira] [Commented] (CASSANDRA-18742) Remove deprecated options in CompressionParams

2023-09-29 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770434#comment-17770434 ] Stefan Miklosovic commented on CASSANDRA-18742: --- to be extra sure, more tests, j11

[jira] [Commented] (CASSANDRA-18742) Remove deprecated options in CompressionParams

2023-09-28 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770068#comment-17770068 ] Brandon Williams commented on CASSANDRA-18742: -- +1 from me :) > Remove deprecated

[jira] [Commented] (CASSANDRA-18742) Remove deprecated options in CompressionParams

2023-09-28 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770066#comment-17770066 ] Stefan Miklosovic commented on CASSANDRA-18742: --- OK, so I think we are done.

[jira] [Commented] (CASSANDRA-18742) Remove deprecated options in CompressionParams

2023-09-28 Thread Maxim Muzafarov (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770029#comment-17770029 ] Maxim Muzafarov commented on CASSANDRA-18742: - went through all the changes and the code

[jira] [Commented] (CASSANDRA-18742) Remove deprecated options in CompressionParams

2023-09-28 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769940#comment-17769940 ] Stefan Miklosovic commented on CASSANDRA-18742: ---

[jira] [Commented] (CASSANDRA-18742) Remove deprecated options in CompressionParams

2023-09-27 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769833#comment-17769833 ] Brandon Williams commented on CASSANDRA-18742: -- The upgrade tests passed, which is a

[jira] [Commented] (CASSANDRA-18742) Remove deprecated options in CompressionParams

2023-09-27 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769785#comment-17769785 ] Brandon Williams commented on CASSANDRA-18742: -- Started [upgrade

[jira] [Commented] (CASSANDRA-18742) Remove deprecated options in CompressionParams

2023-09-27 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769777#comment-17769777 ] Stefan Miklosovic commented on CASSANDRA-18742: --- the flaky one is this one

[jira] [Commented] (CASSANDRA-18742) Remove deprecated options in CompressionParams

2023-09-27 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769775#comment-17769775 ] Brandon Williams commented on CASSANDRA-18742: -- I see, that makes sense. We should

[jira] [Commented] (CASSANDRA-18742) Remove deprecated options in CompressionParams

2023-09-27 Thread Stefan Miklosovic (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769773#comment-17769773 ] Stefan Miklosovic commented on CASSANDRA-18742: --- The flaky test is a test method in

[jira] [Commented] (CASSANDRA-18742) Remove deprecated options in CompressionParams

2023-09-27 Thread Brandon Williams (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769764#comment-17769764 ] Brandon Williams commented on CASSANDRA-18742: -- Looks good to me, but I'm not sure we