[
https://issues.apache.org/jira/browse/CASSANDRA-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14217927#comment-14217927
]
Benjamin Lerer commented on CASSANDRA-8286:
---
I like the new unit tests.
+1
[
https://issues.apache.org/jira/browse/CASSANDRA-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216755#comment-14216755
]
Tyler Hobbs commented on CASSANDRA-8286:
v2 patches are attached. I also have
[
https://issues.apache.org/jira/browse/CASSANDRA-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14214917#comment-14214917
]
Benjamin Lerer commented on CASSANDRA-8286:
---
Just a few nits:
* The patch
[
https://issues.apache.org/jira/browse/CASSANDRA-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14208873#comment-14208873
]
Tyler Hobbs commented on CASSANDRA-8286:
[~blerer] can you review?
[
https://issues.apache.org/jira/browse/CASSANDRA-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14205312#comment-14205312
]
Philip Thompson commented on CASSANDRA-8286:
The test
[
https://issues.apache.org/jira/browse/CASSANDRA-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14205331#comment-14205331
]
Philip Thompson commented on CASSANDRA-8286:
However, in the 2.1 test
[
https://issues.apache.org/jira/browse/CASSANDRA-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14205322#comment-14205322
]
Philip Thompson commented on CASSANDRA-8286:
Despite the commit being in