[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted

2015-12-08 Thread Carl Yeksigian (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047215#comment-15047215 ] Carl Yeksigian commented on CASSANDRA-8805: --- [~krummas] just pushed rebased branches. >

[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted

2015-11-25 Thread Marcus Eriksson (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026972#comment-15026972 ] Marcus Eriksson commented on CASSANDRA-8805: ok, +1 could you rebase the branches? >

[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted

2015-11-24 Thread Carl Yeksigian (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15024796#comment-15024796 ] Carl Yeksigian commented on CASSANDRA-8805: --- Pushed a commit which checks the sstables and

[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted

2015-11-16 Thread Marcus Eriksson (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006393#comment-15006393 ] Marcus Eriksson commented on CASSANDRA-8805: Patch looks good to me, but in the new test,

[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted

2015-11-13 Thread Joshua McKenzie (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004507#comment-15004507 ] Joshua McKenzie commented on CASSANDRA-8805: Swapped reviewer to [~krummas] for the

[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted

2015-11-13 Thread Carl Yeksigian (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004473#comment-15004473 ] Carl Yeksigian commented on CASSANDRA-8805: --- I've pushed a rebased and squashed version, and

[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted

2015-09-14 Thread Carl Yeksigian (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14743887#comment-14743887 ] Carl Yeksigian commented on CASSANDRA-8805: --- Sorry, I missed that you had moved it up --

[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted

2015-09-14 Thread Carl Yeksigian (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14743872#comment-14743872 ] Carl Yeksigian commented on CASSANDRA-8805: --- I think you need to add the {{newSSTables.add}}

[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted

2015-09-14 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14743881#comment-14743881 ] Benedict commented on CASSANDRA-8805: - There wasn't a finally clause before, and it's currently

[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted

2015-09-14 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14743949#comment-14743949 ] Benedict commented on CASSANDRA-8805: - OK, great. Could you post upstream branch merges? >

[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted

2015-09-13 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14742717#comment-14742717 ] Benedict commented on CASSANDRA-8805: - Thanks. I've pushed a version

[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted

2015-06-02 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569384#comment-14569384 ] Benedict commented on CASSANDRA-8805: - The rollback logic in the event of CIE is,

[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted

2015-06-01 Thread Carl Yeksigian (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14567402#comment-14567402 ] Carl Yeksigian commented on CASSANDRA-8805: --- I pushed up an

[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted

2015-05-22 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555778#comment-14555778 ] Benedict commented on CASSANDRA-8805: - [~carlyeks]: The general approach looks

[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted

2015-02-18 Thread Tyler Hobbs (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326263#comment-14326263 ] Tyler Hobbs commented on CASSANDRA-8805: Are the changes to make

[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted

2015-02-18 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326284#comment-14326284 ] Benedict commented on CASSANDRA-8805: - Pretty much. I think the best thing to do

[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted

2015-02-18 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326378#comment-14326378 ] Benedict commented on CASSANDRA-8805: - Not sure how I keep accidentally changing

[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted

2015-02-16 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322704#comment-14322704 ] Benedict commented on CASSANDRA-8805: - /cc [~thobbs] runWithCompactionsDisabled