[
https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047215#comment-15047215
]
Carl Yeksigian commented on CASSANDRA-8805:
---
[~krummas] just pushed rebased branches.
>
[
https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026972#comment-15026972
]
Marcus Eriksson commented on CASSANDRA-8805:
ok, +1
could you rebase the branches?
>
[
https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15024796#comment-15024796
]
Carl Yeksigian commented on CASSANDRA-8805:
---
Pushed a commit which checks the sstables and
[
https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006393#comment-15006393
]
Marcus Eriksson commented on CASSANDRA-8805:
Patch looks good to me, but in the new test,
[
https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004507#comment-15004507
]
Joshua McKenzie commented on CASSANDRA-8805:
Swapped reviewer to [~krummas] for the
[
https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004473#comment-15004473
]
Carl Yeksigian commented on CASSANDRA-8805:
---
I've pushed a rebased and squashed version, and
[
https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14743887#comment-14743887
]
Carl Yeksigian commented on CASSANDRA-8805:
---
Sorry, I missed that you had moved it up --
[
https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14743872#comment-14743872
]
Carl Yeksigian commented on CASSANDRA-8805:
---
I think you need to add the {{newSSTables.add}}
[
https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14743881#comment-14743881
]
Benedict commented on CASSANDRA-8805:
-
There wasn't a finally clause before, and it's currently
[
https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14743949#comment-14743949
]
Benedict commented on CASSANDRA-8805:
-
OK, great. Could you post upstream branch merges?
>
[
https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14742717#comment-14742717
]
Benedict commented on CASSANDRA-8805:
-
Thanks. I've pushed a version
[
https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569384#comment-14569384
]
Benedict commented on CASSANDRA-8805:
-
The rollback logic in the event of CIE is,
[
https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14567402#comment-14567402
]
Carl Yeksigian commented on CASSANDRA-8805:
---
I pushed up an
[
https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555778#comment-14555778
]
Benedict commented on CASSANDRA-8805:
-
[~carlyeks]: The general approach looks
[
https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326263#comment-14326263
]
Tyler Hobbs commented on CASSANDRA-8805:
Are the changes to make
[
https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326284#comment-14326284
]
Benedict commented on CASSANDRA-8805:
-
Pretty much. I think the best thing to do
[
https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326378#comment-14326378
]
Benedict commented on CASSANDRA-8805:
-
Not sure how I keep accidentally changing
[
https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322704#comment-14322704
]
Benedict commented on CASSANDRA-8805:
-
/cc [~thobbs]
runWithCompactionsDisabled
18 matches
Mail list logo