[jira] [Commented] (CASSANDRA-9908) Potential race caused by async cleanup of transaction log files

2015-08-10 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680208#comment-14680208 ] Benedict commented on CASSANDRA-9908: - I've committed this as

[jira] [Commented] (CASSANDRA-9908) Potential race caused by async cleanup of transaction log files

2015-08-10 Thread Stefania (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680969#comment-14680969 ] Stefania commented on CASSANDRA-9908: - If the listing of files happened before

[jira] [Commented] (CASSANDRA-9908) Potential race caused by async cleanup of transaction log files

2015-08-10 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14679665#comment-14679665 ] Benedict commented on CASSANDRA-9908: - bq. Done. However, waitForCessasion is not

[jira] [Commented] (CASSANDRA-9908) Potential race caused by async cleanup of transaction log files

2015-08-09 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14663311#comment-14663311 ] Benedict commented on CASSANDRA-9908: - (It's also worth noting this race condition

[jira] [Commented] (CASSANDRA-9908) Potential race caused by async cleanup of transaction log files

2015-08-09 Thread Stefania (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14679517#comment-14679517 ] Stefania commented on CASSANDRA-9908: - bq. Thinking about it, we need to replicate

[jira] [Commented] (CASSANDRA-9908) Potential race caused by async cleanup of transaction log files

2015-08-08 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662981#comment-14662981 ] Benedict commented on CASSANDRA-9908: - Thinking about it, we need to replicate a

[jira] [Commented] (CASSANDRA-9908) Potential race caused by async cleanup of transaction log files

2015-08-03 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14651564#comment-14651564 ] Benedict commented on CASSANDRA-9908: - Yep, that all looks good. bq. Isn't this

[jira] [Commented] (CASSANDRA-9908) Potential race caused by async cleanup of transaction log files

2015-07-30 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647351#comment-14647351 ] Benedict commented on CASSANDRA-9908: - Take a look in {{Keyspace.dropCf}} for

[jira] [Commented] (CASSANDRA-9908) Potential race caused by async cleanup of transaction log files

2015-07-30 Thread Stefania (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647488#comment-14647488 ] Stefania commented on CASSANDRA-9908: - So something like this then: {code} public

[jira] [Commented] (CASSANDRA-9908) Potential race caused by async cleanup of transaction log files

2015-07-29 Thread Stefania (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14646991#comment-14646991 ] Stefania commented on CASSANDRA-9908: - Thank you for checking Sam. So if we cannot

[jira] [Commented] (CASSANDRA-9908) Potential race caused by async cleanup of transaction log files

2015-07-29 Thread Sam Tunnicliffe (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645687#comment-14645687 ] Sam Tunnicliffe commented on CASSANDRA-9908: The patch narrows the window

[jira] [Commented] (CASSANDRA-9908) Potential race caused by async cleanup of transaction log files

2015-07-29 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645925#comment-14645925 ] Benedict commented on CASSANDRA-9908: - Probably we should at least introduce a

[jira] [Commented] (CASSANDRA-9908) Potential race caused by async cleanup of transaction log files

2015-07-28 Thread Stefania (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645277#comment-14645277 ] Stefania commented on CASSANDRA-9908: - Regardless of indexes, I think it should be

[jira] [Commented] (CASSANDRA-9908) Potential race caused by async cleanup of transaction log files

2015-07-28 Thread Sam Tunnicliffe (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14644519#comment-14644519 ] Sam Tunnicliffe commented on CASSANDRA-9908: No, an index cfs doesn't have

[jira] [Commented] (CASSANDRA-9908) Potential race caused by async cleanup of transaction log files

2015-07-28 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14644500#comment-14644500 ] Benedict commented on CASSANDRA-9908: - Hmm. So our secondary index files don't use

[jira] [Commented] (CASSANDRA-9908) Potential race caused by async cleanup of transaction log files

2015-07-28 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14644539#comment-14644539 ] Benedict commented on CASSANDRA-9908: - Doesn't that sort of obviate much of the