ZhaoYang created CASSANDRA-15900:
------------------------------------

             Summary: Close channel and reduce buffer allocation during entire 
sstable streaming with SSL
                 Key: CASSANDRA-15900
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15900
             Project: Cassandra
          Issue Type: Bug
          Components: Legacy/Streaming and Messaging
            Reporter: ZhaoYang
            Assignee: ZhaoYang


CASSANDRA-15740 added the ability to stream entire sstable by loading on-disk 
file into user-space off-heap buffer when SSL is enabled, because netty doesn't 
support zero-copy with SSL.

But there are two issues:
# file channel is not closed.
# 1mb batch size is used. 1mb exceeds buffer pool's max allocation size, thus 
it's all allocated outside the pool and will cause large amount of allocations.
 
[Patch|https://github.com/apache/cassandra/pull/651]:
# close file channel when the last batch is loaded into off-heap bytebuffer.
# reduce the batch to 64kb which is more buffer pool friendly when streaming 
entire sstable with SSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to