Tyler Hobbs created CASSANDRA-6984:
--------------------------------------

             Summary: NullPointerException in Streaming During Repair
                 Key: CASSANDRA-6984
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6984
             Project: Cassandra
          Issue Type: Bug
          Components: Core
            Reporter: Tyler Hobbs
            Assignee: Yuki Morishita


In cassandra-2.0, I can trigger a NullPointerException with a repair.  These 
steps should reproduce the issue:
* create a three node ccm cluster (with vnodes)
* start a stress write (I'm using {{tools/bin/cassandra-stress 
--replication-factor=3 -n 10000000 -k -t 1}})
* stop node3 while stress is running, then wait a minute
* start node 3
* run "ccm node3 repair"

In the logs for node1, I see this:
{noformat}


ERROR [STREAM-OUT-/127.0.0.3] 2014-04-04 17:40:08,547 CassandraDaemon.java 
(line 198) Exception in thread Thread[STREAM-OUT-/127.0.0.3,5,main]
java.lang.NullPointerException
        at 
org.apache.cassandra.streaming.ConnectionHandler$MessageHandler.signalCloseDone(ConnectionHandler.java:249)
        at 
org.apache.cassandra.streaming.ConnectionHandler$OutgoingMessageHandler.run(ConnectionHandler.java:375)
        at java.lang.Thread.run(Thread.java:724)
{noformat}

After applying Yuki's suggested patch:
{noformat}
diff --git a/src/java/org/apache/cassandra/streaming/ConnectionHandler.java 
b/src/java/org/apache/cassandra/streaming/ConnectionHandler.java
index 356138b..b06a818 100644
--- a/src/java/org/apache/cassandra/streaming/ConnectionHandler.java
+++ b/src/java/org/apache/cassandra/streaming/ConnectionHandler.java
@@ -366,7 +366,7 @@ public class ConnectionHandler
             {
                 throw new AssertionError(e);
             }
-            catch (IOException e)
+            catch (Throwable e)
             {
                 session.onError(e);
             }
{noformat}

I see a new NPE:
{noformat}
ERROR [STREAM-OUT-/127.0.0.3] 2014-04-04 18:12:35,912 StreamSession.java (line 
420) [Stream #9b592af0-bc4e-11e3-a6f9-43eb3a328df9] Streaming error occurred
java.lang.NullPointerException
        at 
org.apache.cassandra.streaming.StreamSession.fileSent(StreamSession.java:465)
        at 
org.apache.cassandra.streaming.messages.OutgoingFileMessage$1.serialize(OutgoingFileMessage.java:60)
        at 
org.apache.cassandra.streaming.messages.OutgoingFileMessage$1.serialize(OutgoingFileMessage.java:42)
        at 
org.apache.cassandra.streaming.messages.StreamMessage.serialize(StreamMessage.java:45)
        at 
org.apache.cassandra.streaming.ConnectionHandler$OutgoingMessageHandler.sendMessage(ConnectionHandler.java:383)
        at 
org.apache.cassandra.streaming.ConnectionHandler$OutgoingMessageHandler.run(ConnectionHandler.java:355)
        at java.lang.Thread.run(Thread.java:724)
{noformat}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to