[ https://issues.apache.org/jira/browse/CASSANDRA-14628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Yeschenko reopened CASSANDRA-14628: ------------------------------------------- As spotted by [~krummas], the final version broke a couple nodetool dtests. I ran full CI suite on the initial patch, but only unit tests for the revised version, and did not notice that {{CassandraMetricsRegistry.registerMBean()}} needed a minor change for {{Metered}} to be properly accepted. The fix is [here|https://github.com/iamaleksey/cassandra/commits/14628-fix-jmx], its CI [here|https://circleci.com/workflow-run/2846f7e8-10a9-4499-bec6-327cc05e2a04] - there is one unrelated nodetool failure, but the issue with this patch is gone. > Clean up cache-related metrics > ------------------------------ > > Key: CASSANDRA-14628 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14628 > Project: Cassandra > Issue Type: Improvement > Reporter: Aleksey Yeschenko > Assignee: Aleksey Yeschenko > Priority: Minor > Labels: virtual-tables > Fix For: 4.0 > > > {{ChunkCache}} added {{CacheMissMetrics}} which is an almost exact duplicate > of pre-existing {{CacheMetrics}}. I believe it was done initially because the > authors thought there was no way to register hits with {{Caffeine}}, only > misses, but that's not quite true. All we need is to provide a > {{StatsCounter}} object when building the cache and update our metrics from > there. > The patch removes the redundant code and streamlines chunk cache metrics to > use more idiomatic tracking. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org