[ 
https://issues.apache.org/jira/browse/CASSANDRA-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sylvain Lebresne updated CASSANDRA-3262:
----------------------------------------

    Attachment: 3262.patch

Note that I refactor a bit the code because it felt weird to have 
compareEndpoint being concrete in AbstractEndpointSnitch but sortByProximity 
being abstract. It seems more natural to have compareEndpoint being the 
abstract method and sortByProximity being defined from it in AES.
                
> SimpleSnitch.compareEndpoints doesn't respect the intent of the snitch
> ----------------------------------------------------------------------
>
>                 Key: CASSANDRA-3262
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3262
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.8.6
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 0.8.7, 1.0.0
>
>         Attachments: 3262.patch
>
>
> SimpleSnitch is supposed to not sort the input addresses, thus respecting the 
> order of the partitioner. However, it's compareEndpoints instead uses IP 
> addresses comparison. Note that this matter when the dynamicSnitch fall back 
> to the wrapped snitch since it uses the compareEndpoint method then.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to