Re: [PR] CAY-2842 Prevent duplicate select columns when using distinct with order by [cayenne]

2024-02-14 Thread via GitHub
stariy95 commented on PR #605: URL: https://github.com/apache/cayenne/pull/605#issuecomment-1944189731 Yep, filtering by `DbAttribute` should make sense. It should filter out almost everything in most cases. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] CAY-2842 Prevent duplicate select columns when using distinct with order by [cayenne]

2024-02-14 Thread via GitHub
Jugen commented on PR #605: URL: https://github.com/apache/cayenne/pull/605#issuecomment-1944099714 I like how it's turned out as well, thanks so much for your guidance. I can filter using DbAttribute, before doing the SQL compare, to save a millisecond or two

Re: [PR] CAY-2842 Prevent duplicate select columns when using distinct with order by [cayenne]

2024-02-14 Thread via GitHub
stariy95 commented on PR #605: URL: https://github.com/apache/cayenne/pull/605#issuecomment-1943371860 @Jugen Great! I like how it's turned out overall. The last think that seems off is performance of the duplicate check. But I don't have a better idea how to optimize that. If you got