Re: [PR] Add macro documentation comments to AC_DEFINE for FTS and OpenSSL option [cloudberry]

2025-06-11 Thread via GitHub
yjhjstz commented on PR #1153: URL: https://github.com/apache/cloudberry/pull/1153#issuecomment-2964775598 > > > Could you help take a look again? Thanks! > > > > > > pg_config.h.in is automatically generated by autoheader, which dynamically creates comment templates based on the

Re: [PR] Add macro documentation comments to AC_DEFINE for FTS and OpenSSL option [cloudberry]

2025-06-11 Thread via GitHub
tuhaihe commented on PR #1153: URL: https://github.com/apache/cloudberry/pull/1153#issuecomment-2964738736 > > Could you help take a look again? Thanks! > > pg_config.h.in is automatically generated by autoheader, which dynamically creates comment templates based on the macro definiti

Re: [I] [Bug] Rename greenplum_path.sh and generate-greenplum-path.sh to remove trademarked references [cloudberry]

2025-06-11 Thread via GitHub
yjhjstz commented on issue #1149: URL: https://github.com/apache/cloudberry/issues/1149#issuecomment-2964314138 how about `ln -s cloudberry-env.sh greenplum_path.sh` in post-install scripts ? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[PR] Improve reloptions validation for partitioned tables using non-default AMs [cloudberry]

2025-06-11 Thread via GitHub
yjhjstz opened a new pull request, #1155: URL: https://github.com/apache/cloudberry/pull/1155 Previously, when creating a partitioned table without an explicit `USING` clause, the reloptions (such as minmax_columns) were validated with the assumption that the default_table_access_method

Re: [PR] Add macro documentation comments to AC_DEFINE for FTS and OpenSSL option [cloudberry]

2025-06-11 Thread via GitHub
yjhjstz commented on PR #1153: URL: https://github.com/apache/cloudberry/pull/1153#issuecomment-2963205787 > Hey @yjhjstz thanks! > > During my test, after running `autoreconf -i`, the file `pg_config.h.in` also had some related updates: > > ``` > Changes not staged for comm

[PR] Update master to coordinator and brand name [cloudberry-bootcamp]

2025-06-11 Thread via GitHub
tuhaihe opened a new pull request, #46: URL: https://github.com/apache/cloudberry-bootcamp/pull/46 In this PR, these changes are made: - Update the word `master` to `coordinator` to match the source code changes - Update the old brand name `cloudberrydb` or `cloudberry database` to

Re: [PR] Add configure-time check for protobuf when --enable-pax is specified [cloudberry]

2025-06-11 Thread via GitHub
yjhjstz commented on PR #1151: URL: https://github.com/apache/cloudberry/pull/1151#issuecomment-2962501200 > Hey @yjhjstz, Just curious if there's any chance we could implement the function ourselves, instead of introducing the new file `config/ax_compare_version.m4`? you can see con

Re: [PR] Add macro documentation comments to AC_DEFINE for FTS and OpenSSL option [cloudberry]

2025-06-11 Thread via GitHub
yjhjstz commented on code in PR #1153: URL: https://github.com/apache/cloudberry/pull/1153#discussion_r2140004109 ## configure: ## @@ -15267,7 +15268,8 @@ if test "$enable_openssl_redirect" = yes; then as_fn_error $? "--enable-openssl-redirect must specify --with-ssl" "$LI

Re: [PR] TRY_CONVERT [cloudberry]

2025-06-11 Thread via GitHub
robozmey commented on code in PR #901: URL: https://github.com/apache/cloudberry/pull/901#discussion_r2139996123 ## contrib/try_convert/try_convert.c: ## @@ -0,0 +1,446 @@ +#include "postgres.h" + +#include "catalog/pg_cast.h" +#include "utils/syscache.h" +#include "utils/lsysca

Re: [PR] Cherry pick NodeSummary in EXPLAIN ANALYZE [cloudberry]

2025-06-11 Thread via GitHub
avamingli commented on code in PR #1114: URL: https://github.com/apache/cloudberry/pull/1114#discussion_r2139593180 ## src/backend/commands/explain_gp.c: ## @@ -1473,6 +1473,44 @@ cdbexplain_formatSeg(char *outbuf, int bufsize, int segindex, int nInst) }

Re: [PR] TRY_CONVERT [cloudberry]

2025-06-11 Thread via GitHub
robozmey commented on code in PR #901: URL: https://github.com/apache/cloudberry/pull/901#discussion_r2139748116 ## contrib/try_convert/try_convert.c: ## @@ -0,0 +1,446 @@ +#include "postgres.h" + +#include "catalog/pg_cast.h" +#include "utils/syscache.h" +#include "utils/lsysca

Re: [PR] Cherry pick NodeSummary in EXPLAIN ANALYZE [cloudberry]

2025-06-11 Thread via GitHub
robozmey commented on code in PR #1114: URL: https://github.com/apache/cloudberry/pull/1114#discussion_r2139571388 ## src/backend/commands/explain_gp.c: ## @@ -1545,6 +1583,131 @@ nodeSupportWorkfileCaching(PlanState *planstate) IsA(planstate, MaterialSta

Re: [PR] TRY_CONVERT [cloudberry]

2025-06-11 Thread via GitHub
robozmey commented on code in PR #901: URL: https://github.com/apache/cloudberry/pull/901#discussion_r2139643233 ## contrib/try_convert/try_convert.c: ## @@ -0,0 +1,446 @@ +#include "postgres.h" + +#include "catalog/pg_cast.h" +#include "utils/syscache.h" +#include "utils/lsysca

Re: [PR] Cherry pick NodeSummary in EXPLAIN ANALYZE [cloudberry]

2025-06-11 Thread via GitHub
robozmey commented on PR #1114: URL: https://github.com/apache/cloudberry/pull/1114#issuecomment-2961783967 > And a quick question: In what cases is NodeSummary primarily used? It useful to debug plans and queries, with this feature you can just see stats of every Node without need to

Re: [PR] Cherry pick NodeSummary in EXPLAIN ANALYZE [cloudberry]

2025-06-11 Thread via GitHub
avamingli commented on PR #1114: URL: https://github.com/apache/cloudberry/pull/1114#issuecomment-2961811446 > > And a quick question: In what cases is NodeSummary primarily used? > > It useful to debug plans and queries, with this feature you can just see stats of every Node without

Re: [PR] Cherry pick NodeSummary in EXPLAIN ANALYZE [cloudberry]

2025-06-11 Thread via GitHub
robozmey commented on code in PR #1114: URL: https://github.com/apache/cloudberry/pull/1114#discussion_r2139567966 ## src/backend/commands/explain_gp.c: ## @@ -1473,6 +1473,44 @@ cdbexplain_formatSeg(char *outbuf, int bufsize, int segindex, int nInst) }

Re: [PR] Add macro documentation comments to AC_DEFINE for FTS and OpenSSL option [cloudberry]

2025-06-11 Thread via GitHub
my-ship-it commented on code in PR #1153: URL: https://github.com/apache/cloudberry/pull/1153#discussion_r2139382329 ## configure: ## @@ -15267,7 +15268,8 @@ if test "$enable_openssl_redirect" = yes; then as_fn_error $? "--enable-openssl-redirect must specify --with-ssl" "

[PR] Fix unordered GUC names. [cloudberry]

2025-06-11 Thread via GitHub
avamingli opened a new pull request, #1154: URL: https://github.com/apache/cloudberry/pull/1154 As the comments said: items in this file should be ordered. Authored-by: Zhang Mingli avamin...@gmail.com Fixes #ISSUE_Number ### What does this PR do? ### T

Re: [PR] Add configure-time check for protobuf when --enable-pax is specified [cloudberry]

2025-06-11 Thread via GitHub
tuhaihe commented on PR #1151: URL: https://github.com/apache/cloudberry/pull/1151#issuecomment-2961578704 Hey @yjhjstz, Just curious if there's any chance we could implement the function ourselves, instead of introducing the new file `config/ax_compare_version.m4`? -- This is an automat

Re: [PR] Cherry pick hot standby commits from gpdb [cloudberry]

2025-06-11 Thread via GitHub
my-ship-it commented on PR #1152: URL: https://github.com/apache/cloudberry/pull/1152#issuecomment-2961488589 > > > due to increased size of wal, that make tpcc performance degradation. > > > > > > Yes, It will indeed increase the size of the wal-log. Does it impact performance du

Re: [PR] Cherry pick hot standby commits from gpdb [cloudberry]

2025-06-11 Thread via GitHub
my-ship-it commented on PR #1152: URL: https://github.com/apache/cloudberry/pull/1152#issuecomment-2961476062 > > due to increased size of wal, that make tpcc performance degradation. > > Yes, It will indeed increase the size of the wal-log. Does it impact performance due to increasin