[GitHub] jayapalu commented on a change in pull request #1990: CLOUDSTACK-9674: Baremetal deployment improvements

2017-05-25 Thread git
jayapalu commented on a change in pull request #1990: CLOUDSTACK-9674: Baremetal deployment improvements URL: https://github.com/apache/cloudstack/pull/1990#discussion_r118639494 ## File path: systemvm/patches/debian/config/opt/cloud/bin/baremetal_snat.sh ## @@ -22,6 +22,1

[GitHub] sureshanaparti commented on issue #2092: CLOUDSTACK-8599: [VMware] Successful migration was reported as failure when vCenter session timed out

2017-05-25 Thread git
sureshanaparti commented on issue #2092: CLOUDSTACK-8599: [VMware] Successful migration was reported as failure when vCenter session timed out URL: https://github.com/apache/cloudstack/pull/2092#issuecomment-304196156 Above test failures are not related to this PR. ---

[GitHub] cloudmonger commented on issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request to check file size from a URL

2017-05-25 Thread git
cloudmonger commented on issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request to check file size from a URL URL: https://github.com/apache/cloudstack/pull/1934#issuecomment-304192166 ### ACS CI BVT Run **Sumarry:** Build Number 752 Hypervisor xenserver NetworkType

[GitHub] niteshsarda commented on issue #1987: CLOUDSTACK-9814 : Unable to edit a Sub domain, which has the same name in different domains

2017-05-25 Thread git
niteshsarda commented on issue #1987: CLOUDSTACK-9814 : Unable to edit a Sub domain, which has the same name in different domains URL: https://github.com/apache/cloudstack/pull/1987#issuecomment-304180860 tag:This is Ready to Merge Test cases which are failing are not related to my c

[GitHub] niteshsarda commented on issue #1987: CLOUDSTACK-9814 : Unable to edit a Sub domain, which has the same name in different domains

2017-05-25 Thread git
niteshsarda commented on issue #1987: CLOUDSTACK-9814 : Unable to edit a Sub domain, which has the same name in different domains URL: https://github.com/apache/cloudstack/pull/1987#issuecomment-284315105 tag:This is Ready to Merge -

[GitHub] abhinandanprateek commented on issue #2026: CLOUDSTACK-9861: Expire VM snapshots after configured duration

2017-05-25 Thread git
abhinandanprateek commented on issue #2026: CLOUDSTACK-9861: Expire VM snapshots after configured duration URL: https://github.com/apache/cloudstack/pull/2026#issuecomment-304179466 @borisstoyanov rebased. This is an automat

[GitHub] borisstoyanov commented on issue #2026: CLOUDSTACK-9861: Expire VM snapshots after configured duration

2017-05-25 Thread git
borisstoyanov commented on issue #2026: CLOUDSTACK-9861: Expire VM snapshots after configured duration URL: https://github.com/apache/cloudstack/pull/2026#issuecomment-304107519 @abhinandanprateek can you please resolve the merge conflicts on this branch? ---

[GitHub] sureshanaparti commented on issue #862: CLOUDSTACK-7151: Support multiple physical networks at cluster level for guest traffic over VMware deployments.

2017-05-25 Thread git
sureshanaparti commented on issue #862: CLOUDSTACK-7151: Support multiple physical networks at cluster level for guest traffic over VMware deployments. URL: https://github.com/apache/cloudstack/pull/862#issuecomment-304071489 @borisstoyanov Can you kick off tests on VMware env as this PR ch

[GitHub] cloudmonger commented on issue #1930: CLOUDSTACK-9687: if the allocated amount is 0 the capacity updates ar?

2017-05-25 Thread git
cloudmonger commented on issue #1930: CLOUDSTACK-9687: if the allocated amount is 0 the capacity updates ar? URL: https://github.com/apache/cloudstack/pull/1930#issuecomment-304057081 ### ACS CI BVT Run **Sumarry:** Build Number 750 Hypervisor xenserver NetworkType Advanced

[GitHub] blueorangutan commented on issue #2116: CLOUDSTACK-8959: Option to attach the config drive

2017-05-25 Thread git
blueorangutan commented on issue #2116: CLOUDSTACK-8959: Option to attach the config drive URL: https://github.com/apache/cloudstack/pull/2116#issuecomment-304035337 Trillian test result (tid-1131) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken:

[GitHub] rafaelweingartner commented on issue #837: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

2017-05-25 Thread git
rafaelweingartner commented on issue #837: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/837#issuecomment-304032623 @bvbharat if other people are ok with this, I cannot complain much (if it is a community d

[GitHub] rafaelweingartner commented on a change in pull request #837: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

2017-05-25 Thread git
rafaelweingartner commented on a change in pull request #837: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/837#discussion_r118504187 ## File path: engine/components-api/src/com/cloud/agent/AgentMana

[GitHub] rafaelweingartner commented on a change in pull request #837: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

2017-05-25 Thread git
rafaelweingartner commented on a change in pull request #837: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/837#discussion_r118504046 ## File path: api/src/com/cloud/resource/ResourceService.java ##

[GitHub] jayapalu commented on a change in pull request #2100: CLOUDSTACK-9907 Physical size of snapshot is considered for usage

2017-05-25 Thread git
jayapalu commented on a change in pull request #2100: CLOUDSTACK-9907 Physical size of snapshot is considered for usage URL: https://github.com/apache/cloudstack/pull/2100#discussion_r118493768 ## File path: usage/src/com/cloud/usage/UsageManagerImpl.java ## @@ -208,6 +209

[GitHub] blueorangutan commented on issue #862: CLOUDSTACK-7151: Support multiple physical networks at cluster level for guest traffic over VMware deployments.

2017-05-25 Thread git
blueorangutan commented on issue #862: CLOUDSTACK-7151: Support multiple physical networks at cluster level for guest traffic over VMware deployments. URL: https://github.com/apache/cloudstack/pull/862#issuecomment-304014617 Trillian test result (tid-1130) Environment: kvm-centos7 (x2),

[GitHub] rhtyd commented on a change in pull request #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-25 Thread git
rhtyd commented on a change in pull request #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided URL: https://github.com/apache/cloudstack/pull/2108#discussion_r118470765 ## File path: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Cit

[GitHub] PranaliM commented on a change in pull request #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-25 Thread git
PranaliM commented on a change in pull request #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided URL: https://github.com/apache/cloudstack/pull/2108#discussion_r118468844 ## File path: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/

[GitHub] rhtyd opened a new pull request #2129: CLOUDSTACK-9928: Allow native CloudStack users to change password in UI

2017-05-25 Thread git
rhtyd opened a new pull request #2129: CLOUDSTACK-9928: Allow native CloudStack users to change password in UI URL: https://github.com/apache/cloudstack/pull/2129 This allows native CloudStack users to change password in UI when LDAP is enabled. Overall changes: - A new usersource ret

[GitHub] jayapalu opened a new pull request #2128: CLOUDSTACK-9885: VPCVR: Updated to the private the traffic_type

2017-05-25 Thread git
jayapalu opened a new pull request #2128: CLOUDSTACK-9885: VPCVR: Updated to the private the traffic_type URL: https://github.com/apache/cloudstack/pull/2128 Updated the traffic_type to PrivateGw to avoid configuring keepalied on the private gateway interface. For more details about the

[GitHub] yvsubhash commented on issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unremoved

2017-05-25 Thread git
yvsubhash commented on issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unremoved URL: https://github.com/apache/cloudstack/pull/1726#issuecomment-303964912 @karuturi / @koushik-das Please merge this This is an a

[GitHub] yvsubhash commented on issue #1725: CLOUDSTACK-9559 Why allow deleting zone without deleting the seconda?

2017-05-25 Thread git
yvsubhash commented on issue #1725: CLOUDSTACK-9559 Why allow deleting zone without deleting the seconda? URL: https://github.com/apache/cloudstack/pull/1725#issuecomment-303964317 @karuturi / @koushik-das Please merge this ---

[GitHub] SowjanyaPatha commented on issue #2100: CLOUDSTACK-9907 Physical size of snapshot is considered for usage

2017-05-25 Thread git
SowjanyaPatha commented on issue #2100: CLOUDSTACK-9907 Physical size of snapshot is considered for usage URL: https://github.com/apache/cloudstack/pull/2100#issuecomment-303964199 tag:MergeReady This is an automated message

[GitHub] jayakarteek commented on issue #2104: CLOUDSTACK-9908 : Primary Storage allocated capacity goes very high after VM snapshot

2017-05-25 Thread git
jayakarteek commented on issue #2104: CLOUDSTACK-9908 : Primary Storage allocated capacity goes very high after VM snapshot URL: https://github.com/apache/cloudstack/pull/2104#issuecomment-303963636 tag:MergeReady This is an

[GitHub] cloudmonger commented on issue #1987: CLOUDSTACK-9814 : Unable to edit a Sub domain, which has the same name in different domains

2017-05-25 Thread git
cloudmonger commented on issue #1987: CLOUDSTACK-9814 : Unable to edit a Sub domain, which has the same name in different domains URL: https://github.com/apache/cloudstack/pull/1987#issuecomment-303960684 ### ACS CI BVT Run **Sumarry:** Build Number 748 Hypervisor xenserver

[GitHub] koushik-das commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-25 Thread git
koushik-das commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided URL: https://github.com/apache/cloudstack/pull/2108#issuecomment-303957216 Thanks @rhtyd. Code changes LGTM This is an a

[GitHub] rhtyd commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-25 Thread git
rhtyd commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided URL: https://github.com/apache/cloudstack/pull/2108#issuecomment-303941418 Test LGTM. This is ready for merge, has enough test results, a new marvin test, reviews, LGTMs. /cc @karuturi