[GitHub] blueorangutan commented on issue #2218: CLOUDSTACK-9782: New Background Polling Task Manager

2017-08-02 Thread git
blueorangutan commented on issue #2218: CLOUDSTACK-9782: New Background Polling Task Manager URL: https://github.com/apache/cloudstack/pull/2218#issuecomment-319841991 Trillian test result (tid-1306) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] blueorangutan commented on issue #1919: CLOUDSTACK-9763: set ssh public key when creating vm data

2017-08-02 Thread git
blueorangutan commented on issue #1919: CLOUDSTACK-9763: set ssh public key when creating vm data URL: https://github.com/apache/cloudstack/pull/1919#issuecomment-319833649 Packaging result: ?centos6 ?centos7 ?debian. JID-907

[GitHub] blueorangutan commented on issue #1912: CLOUDSTACK-9749: Disable password service on ilb systemvm

2017-08-02 Thread git
blueorangutan commented on issue #1912: CLOUDSTACK-9749: Disable password service on ilb systemvm URL: https://github.com/apache/cloudstack/pull/1912#issuecomment-319832809 Packaging result: ?centos6 ?centos7 ?debian. JID-906

[GitHub] blueorangutan commented on issue #2138: CLOUDSTACK-9944 In Cluster Management Server, Sometimes hosts stays i?

2017-08-02 Thread git
blueorangutan commented on issue #2138: CLOUDSTACK-9944 In Cluster Management Server, Sometimes hosts stays i? URL: https://github.com/apache/cloudstack/pull/2138#issuecomment-319832169 Packaging result: ?centos6 ?centos7 ?debian. JID-905

[GitHub] blueorangutan commented on issue #2013: Bug-ID: CLOUDSTACK-9734 Destroy VM Fails sometimes

2017-08-02 Thread git
blueorangutan commented on issue #2013: Bug-ID: CLOUDSTACK-9734 Destroy VM Fails sometimes URL: https://github.com/apache/cloudstack/pull/2013#issuecomment-319832147 Packaging result: ?centos6 ?centos7 ?debian. JID-904 This

[GitHub] blueorangutan commented on issue #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events

2017-08-02 Thread git
blueorangutan commented on issue #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events URL: https://github.com/apache/cloudstack/pull/2058#issuecomment-319822489 Packaging result: ?centos6 ?centos7 ?debian. JID-903

[GitHub] rhtyd commented on issue #1919: CLOUDSTACK-9763: set ssh public key when creating vm data

2017-08-02 Thread git
rhtyd commented on issue #1919: CLOUDSTACK-9763: set ssh public key when creating vm data URL: https://github.com/apache/cloudstack/pull/1919#issuecomment-319821162 @blueorangutan package This is an automated message from

[GitHub] blueorangutan commented on issue #1919: CLOUDSTACK-9763: set ssh public key when creating vm data

2017-08-02 Thread git
blueorangutan commented on issue #1919: CLOUDSTACK-9763: set ssh public key when creating vm data URL: https://github.com/apache/cloudstack/pull/1919#issuecomment-319821293 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] blueorangutan commented on issue #1912: CLOUDSTACK-9749: Disable password service on ilb systemvm

2017-08-02 Thread git
blueorangutan commented on issue #1912: CLOUDSTACK-9749: Disable password service on ilb systemvm URL: https://github.com/apache/cloudstack/pull/1912#issuecomment-319821136 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #1912: CLOUDSTACK-9749: Disable password service on ilb systemvm

2017-08-02 Thread git
rhtyd commented on issue #1912: CLOUDSTACK-9749: Disable password service on ilb systemvm URL: https://github.com/apache/cloudstack/pull/1912#issuecomment-319821023 @blueorangutan package This is an automated message from

[GitHub] rhtyd commented on issue #1912: [4.8] CLOUDSTACK-9749: Disable password service on ilb systemvm

2017-08-02 Thread git
rhtyd commented on issue #1912: [4.8] CLOUDSTACK-9749: Disable password service on ilb systemvm URL: https://github.com/apache/cloudstack/pull/1912#issuecomment-319820824 @fmaximus can you rebase against 4.9, or master branch?

[GitHub] rhtyd commented on issue #1912: [4.8] CLOUDSTACK-9749: Disable password service on ilb systemvm

2017-08-02 Thread git
rhtyd commented on issue #1912: [4.8] CLOUDSTACK-9749: Disable password service on ilb systemvm URL: https://github.com/apache/cloudstack/pull/1912#issuecomment-319820824 @fmaximus can you rebase against 4.9, or master branch?

[cloudstack] branch master updated: CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotated on xenserver (#883)

2017-08-02 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 5397106 CLOUDSTACK-8906: /var/log/cloud/

[GitHub] rhtyd commented on issue #883: CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotated on xenserver

2017-08-02 Thread git
rhtyd commented on issue #883: CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotated on xenserver URL: https://github.com/apache/cloudstack/pull/883#issuecomment-319820522 Merging based on CI results, no regressions seen and manual test confirmation on the PR.

[GitHub] rhtyd closed pull request #883: CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotated on xenserver

2017-08-02 Thread git
rhtyd closed pull request #883: CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotated on xenserver URL: https://github.com/apache/cloudstack/pull/883 This is an automated message from the Apache Git Service. To respond

[GitHub] rhtyd closed pull request #2119: CLOUDSTACK-9925: Quota memory tariff value is for 1MB of RAM used per month (not hour)

2017-08-02 Thread git
rhtyd closed pull request #2119: CLOUDSTACK-9925: Quota memory tariff value is for 1MB of RAM used per month (not hour) URL: https://github.com/apache/cloudstack/pull/2119 This is an automated message from the Apache Git

[cloudstack] branch master updated: CLOUDSTACK-9925: Quota memory tariff value is for 1MB of RAM used per month (not hour) (#2119)

2017-08-02 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new e0b6dcb CLOUDSTACK-9925: Quota memory

[GitHub] rhtyd commented on issue #2119: CLOUDSTACK-9925: Quota memory tariff value is for 1MB of RAM used per month (not hour)

2017-08-02 Thread git
rhtyd commented on issue #2119: CLOUDSTACK-9925: Quota memory tariff value is for 1MB of RAM used per month (not hour) URL: https://github.com/apache/cloudstack/pull/2119#issuecomment-319819787 LGTM. This is an automated

[GitHub] rhtyd closed pull request #2145: CLOUDSTACK-9697: Added better error message user if tries to shrink

2017-08-02 Thread git
rhtyd closed pull request #2145: CLOUDSTACK-9697: Added better error message user if tries to shrink URL: https://github.com/apache/cloudstack/pull/2145 This is an automated message from the Apache Git Service. To respond

[cloudstack] branch master updated: CLOUDSTACK-9697: Added better error message user if tries to shrink (#2145)

2017-08-02 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new e43a4b9 CLOUDSTACK-9697: Added better

[GitHub] rhtyd commented on issue #2145: CLOUDSTACK-9697: Added better error message user if tries to shrink

2017-08-02 Thread git
rhtyd commented on issue #2145: CLOUDSTACK-9697: Added better error message user if tries to shrink URL: https://github.com/apache/cloudstack/pull/2145#issuecomment-319819443 LGTM This is an automated message from the

[GitHub] rhtyd commented on issue #2138: CLOUDSTACK-9944 In Cluster Management Server, Sometimes hosts stays i?

2017-08-02 Thread git
rhtyd commented on issue #2138: CLOUDSTACK-9944 In Cluster Management Server, Sometimes hosts stays i? URL: https://github.com/apache/cloudstack/pull/2138#issuecomment-319819256 LGTM. This is an automated message from the

[GitHub] blueorangutan commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should respect pagination

2017-08-02 Thread git
blueorangutan commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should respect pagination URL: https://github.com/apache/cloudstack/pull/2073#issuecomment-319819358 Packaging result: ?centos6 ?centos7 ?debian. JID-902

[GitHub] blueorangutan commented on issue #2138: CLOUDSTACK-9944 In Cluster Management Server, Sometimes hosts stays i?

2017-08-02 Thread git
blueorangutan commented on issue #2138: CLOUDSTACK-9944 In Cluster Management Server, Sometimes hosts stays i? URL: https://github.com/apache/cloudstack/pull/2138#issuecomment-319818917 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2138: CLOUDSTACK-9944 In Cluster Management Server, Sometimes hosts stays i?

2017-08-02 Thread git
rhtyd commented on issue #2138: CLOUDSTACK-9944 In Cluster Management Server, Sometimes hosts stays i? URL: https://github.com/apache/cloudstack/pull/2138#issuecomment-319818760 @blueorangutan package This is an automated

[GitHub] rhtyd commented on issue #2137: CLOUDSTACK-9950:listUsageRecords doesnt return required fields

2017-08-02 Thread git
rhtyd commented on issue #2137: CLOUDSTACK-9950:listUsageRecords doesnt return required fields URL: https://github.com/apache/cloudstack/pull/2137#issuecomment-319818643 Merging based on Travis checks and code review, explicit Trillian tests are not necessary.

[GitHub] rhtyd closed pull request #2137: CLOUDSTACK-9950:listUsageRecords doesnt return required fields

2017-08-02 Thread git
rhtyd closed pull request #2137: CLOUDSTACK-9950:listUsageRecords doesnt return required fields URL: https://github.com/apache/cloudstack/pull/2137 This is an automated message from the Apache Git Service. To respond to

[cloudstack] branch master updated: CLOUDSTACK-9950:listUsageRecords doesnt return required fields (#2137)

2017-08-02 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new b936feb CLOUDSTACK-9950:listUsageRecords

[GitHub] rhtyd commented on issue #2137: CLOUDSTACK-9950:listUsageRecords doesnt return required fields

2017-08-02 Thread git
rhtyd commented on issue #2137: CLOUDSTACK-9950:listUsageRecords doesnt return required fields URL: https://github.com/apache/cloudstack/pull/2137#issuecomment-319818530 LGTM. This is an automated message from the Apache

[GitHub] rhtyd commented on a change in pull request #2122: CLOUDSTACK-9909: Logrotate config for tomcat needs to be updated for ?

2017-08-02 Thread git
rhtyd commented on a change in pull request #2122: CLOUDSTACK-9909: Logrotate config for tomcat needs to be updated for ? URL: https://github.com/apache/cloudstack/pull/2122#discussion_r131015092 ## File path: server/conf/cloudstack-catalina7.logrotate ## @@ -0,0 +1,27 @@

[GitHub] rhtyd commented on issue #2013: Bug-ID: CLOUDSTACK-9734 Destroy VM Fails sometimes

2017-08-02 Thread git
rhtyd commented on issue #2013: Bug-ID: CLOUDSTACK-9734 Destroy VM Fails sometimes URL: https://github.com/apache/cloudstack/pull/2013#issuecomment-319818050 LGTM (code) @blueorangutan package This is an automated

[GitHub] blueorangutan commented on issue #2013: Bug-ID: CLOUDSTACK-9734 Destroy VM Fails sometimes

2017-08-02 Thread git
blueorangutan commented on issue #2013: Bug-ID: CLOUDSTACK-9734 Destroy VM Fails sometimes URL: https://github.com/apache/cloudstack/pull/2013#issuecomment-319818083 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] blueorangutan commented on issue #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events

2017-08-02 Thread git
blueorangutan commented on issue #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events URL: https://github.com/apache/cloudstack/pull/2058#issuecomment-319817883 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events

2017-08-02 Thread git
rhtyd commented on issue #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events URL: https://github.com/apache/cloudstack/pull/2058#issuecomment-319817865 @blueorangutan package This is an automated message

[GitHub] rhtyd commented on issue #1470: Make the generated json files unique to prevent concurrency issues

2017-08-02 Thread git
rhtyd commented on issue #1470: Make the generated json files unique to prevent concurrency issues URL: https://github.com/apache/cloudstack/pull/1470#issuecomment-319817759 ping @remibergsma This is an automated message

[cloudstack] branch master updated: CLOUDSTACK-9840: Fix datetime format of snapshots events (#2008)

2017-08-02 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 43ae8e3 CLOUDSTACK-9840: Fix datetime

[GitHub] rhtyd closed pull request #2008: [CLOUDSTACK-9840] Fix datetime format of snapshots events

2017-08-02 Thread git
rhtyd closed pull request #2008: [CLOUDSTACK-9840] Fix datetime format of snapshots events URL: https://github.com/apache/cloudstack/pull/2008 This is an automated message from the Apache Git Service. To respond to the

[cloudstack] branch master updated (7fea069 -> 1d95cbb)

2017-08-02 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 7fea069 CLOUDSTACK-9954 Unable to create service offering with networkrate=0 (#2142) add 974e01e

[GitHub] rhtyd commented on issue #2008: [CLOUDSTACK-9840] Fix datetime format of snapshots events

2017-08-02 Thread git
rhtyd commented on issue #2008: [CLOUDSTACK-9840] Fix datetime format of snapshots events URL: https://github.com/apache/cloudstack/pull/2008#issuecomment-319816919 LGTM. This is an automated message from the Apache Git

[cloudstack] 01/01: Merge branch '4.10'

2017-08-02 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 1d95cbbfed4107b8e3be74a066442531e183be2f Merge: 7fea069 b60e173 Author: Rohit Yadav

[GitHub] rhtyd commented on a change in pull request #2050: CLOUDSTACK-9865: improper os types for xenserver 6.5

2017-08-02 Thread git
rhtyd commented on a change in pull request #2050: CLOUDSTACK-9865: improper os types for xenserver 6.5 URL: https://github.com/apache/cloudstack/pull/2050#discussion_r131013646 ## File path: setup/db/db/schema-4920to41000.sql ## @@ -48,7 +48,7 @@ INSERT IGNORE INTO

[cloudstack] 01/01: Merge branch '4.9' into 4.10

2017-08-02 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch 4.10 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit b60e173c5c14e0a5539d0391d4724f4807efb9bd Merge: d53f500 974e01e Author: Rohit Yadav

[cloudstack] branch 4.10 updated (d53f500 -> b60e173)

2017-08-02 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a change to branch 4.10 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from d53f500 Merge branch '4.9' into 4.10 add 974e01e CLOUDSTACK-10011: Fix Agent logrotation (#2094) new

[cloudstack] branch 4.9 updated: CLOUDSTACK-10011: Fix Agent logrotation (#2094)

2017-08-02 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch 4.9 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.9 by this push: new 974e01e CLOUDSTACK-10011: Fix Agent

[GitHub] rhtyd closed pull request #2094: Agent logrotation

2017-08-02 Thread git
rhtyd closed pull request #2094: Agent logrotation URL: https://github.com/apache/cloudstack/pull/2094 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] rhtyd commented on issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after vRouter reboot or recreate

2017-08-02 Thread git
rhtyd commented on issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after vRouter reboot or recreate URL: https://github.com/apache/cloudstack/pull/1966#issuecomment-319815845 Ping, any discussions/reviews? This is an

[GitHub] blueorangutan commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should respect pagination

2017-08-02 Thread git
blueorangutan commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should respect pagination URL: https://github.com/apache/cloudstack/pull/2073#issuecomment-319815292 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should respect pagination

2017-08-02 Thread git
rhtyd commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should respect pagination URL: https://github.com/apache/cloudstack/pull/2073#issuecomment-319815128 @blueorangutan package This is an automated message

[GitHub] rhtyd commented on issue #2078: CLOUDSTACK-9902: add consoleproxy.sslEnable toggle

2017-08-02 Thread git
rhtyd commented on issue #2078: CLOUDSTACK-9902: add consoleproxy.sslEnable toggle URL: https://github.com/apache/cloudstack/pull/2078#issuecomment-319814980 @nathanejohnson can you move the schema changes to 4.10->4.11 db upgrade path

[cloudstack] branch master updated: CLOUDSTACK-9954 Unable to create service offering with networkrate=0 (#2142)

2017-08-02 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 7fea069 CLOUDSTACK-9954 Unable to create

[GitHub] rhtyd closed pull request #2142: CLOUDSTACK-9954 Unable to create service offering with networkrate=0

2017-08-02 Thread git
rhtyd closed pull request #2142: CLOUDSTACK-9954 Unable to create service offering with networkrate=0 URL: https://github.com/apache/cloudstack/pull/2142 This is an automated message from the Apache Git Service. To respond

[GitHub] rhtyd commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections

2017-08-02 Thread git
rhtyd commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-319814210 @swill tests still seem to fail This is an automated

[GitHub] rhtyd commented on issue #1255: Cloudstack-8961: Changes related to the UI of VPN Users management.

2017-08-02 Thread git
rhtyd commented on issue #1255: Cloudstack-8961: Changes related to the UI of VPN Users management. URL: https://github.com/apache/cloudstack/pull/1255#issuecomment-319814047 Closed with https://github.com/apache/cloudstack/pull/2130 merged.

[cloudstack] branch master updated: CLOUDSTACK-8961: Changes related to the UI of VPN Users management. (#2130)

2017-08-02 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 1b898d6 CLOUDSTACK-8961: Changes related

[GitHub] rhtyd closed pull request #2130: CLOUDSTACK-8961: Changes related to the UI of VPN Users management.

2017-08-02 Thread git
rhtyd closed pull request #2130: CLOUDSTACK-8961: Changes related to the UI of VPN Users management. URL: https://github.com/apache/cloudstack/pull/2130 This is an automated message from the Apache Git Service. To respond

[GitHub] rhtyd closed pull request #1255: Cloudstack-8961: Changes related to the UI of VPN Users management.

2017-08-02 Thread git
rhtyd closed pull request #1255: Cloudstack-8961: Changes related to the UI of VPN Users management. URL: https://github.com/apache/cloudstack/pull/1255 This is an automated message from the Apache Git Service. To respond

[GitHub] rhtyd commented on issue #2130: CLOUDSTACK-8961: Changes related to the UI of VPN Users management.

2017-08-02 Thread git
rhtyd commented on issue #2130: CLOUDSTACK-8961: Changes related to the UI of VPN Users management. URL: https://github.com/apache/cloudstack/pull/2130#issuecomment-319813790 LGTM, merging based on manual test reviews by @remibergsma and Travis regression tests. This is purely UI change,

[GitHub] rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations

2017-08-02 Thread git
rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations URL: https://github.com/apache/cloudstack/pull/2181#discussion_r131009939 ## File path: api/src/org/apache/cloudstack/api/command/admin/annotation/RemoveAnnotationCmd.java ## @@ -0,0 +1,66 @@

[GitHub] rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations

2017-08-02 Thread git
rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations URL: https://github.com/apache/cloudstack/pull/2181#discussion_r131010010 ## File path: api/src/org/apache/cloudstack/api/response/AnnotationResponse.java ## @@ -0,0 +1,121 @@ +// Licensed to

[GitHub] rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations

2017-08-02 Thread git
rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations URL: https://github.com/apache/cloudstack/pull/2181#discussion_r131010070 ## File path: engine/schema/src/org/apache/cloudstack/annotation/AnnotationVO.java ## @@ -0,0 +1,154 @@ +// Licensed to

[GitHub] rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations

2017-08-02 Thread git
rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations URL: https://github.com/apache/cloudstack/pull/2181#discussion_r131010097 ## File path: engine/schema/src/org/apache/cloudstack/annotation/dao/AnnotationDao.java ## @@ -0,0 +1,30 @@ +//

[GitHub] rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations

2017-08-02 Thread git
rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations URL: https://github.com/apache/cloudstack/pull/2181#discussion_r131009905 ## File path: api/src/org/apache/cloudstack/api/command/admin/annotation/ListAnnotationsCmd.java ## @@ -0,0 +1,81 @@

[GitHub] rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations

2017-08-02 Thread git
rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations URL: https://github.com/apache/cloudstack/pull/2181#discussion_r131009819 ## File path: api/src/org/apache/cloudstack/api/command/admin/annotation/AddAnnotationCmd.java ## @@ -0,0 +1,83 @@ +//

[GitHub] rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations

2017-08-02 Thread git
rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations URL: https://github.com/apache/cloudstack/pull/2181#discussion_r131009770 ## File path: api/src/org/apache/cloudstack/api/command/admin/annotation/AddAnnotationCmd.java ## @@ -0,0 +1,81 @@ +//

[GitHub] rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations

2017-08-02 Thread git
rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations URL: https://github.com/apache/cloudstack/pull/2181#discussion_r131010147 ## File path: engine/schema/src/org/apache/cloudstack/annotation/dao/AnnotationDaoImpl.java ## @@ -0,0 +1,59 @@ +//

[GitHub] rhtyd commented on issue #2217: [4.9] Smoketest health checkrun

2017-08-02 Thread git
rhtyd commented on issue #2217: [4.9] Smoketest health checkrun URL: https://github.com/apache/cloudstack/pull/2217#issuecomment-319811798 @borisstoyanov can you help go through the list of failures and identify if they are ignorable or we need to fix them, or revert some of the backported

[GitHub] nitin-maharana commented on issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack.

2017-08-02 Thread git
nitin-maharana commented on issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack. URL: https://github.com/apache/cloudstack/pull/1859#issuecomment-297402316 Hi @rafaelweingartner : I have created one more PR with reduced number of commits. Please find this PR #2031 .

[GitHub] nitin-maharana commented on issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack.

2017-08-02 Thread git
nitin-maharana commented on issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack. URL: https://github.com/apache/cloudstack/pull/1859#issuecomment-319722471 TEST This is an automated message from the Apache Git

[GitHub] nitin-maharana commented on issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack.

2017-08-02 Thread git
nitin-maharana commented on issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack. URL: https://github.com/apache/cloudstack/pull/1859#issuecomment-319722471 TEST This is an automated message from the Apache Git

[GitHub] blueorangutan commented on issue #2217: [4.9] Smoketest health checkrun

2017-08-02 Thread git
blueorangutan commented on issue #2217: [4.9] Smoketest health checkrun URL: https://github.com/apache/cloudstack/pull/2217#issuecomment-319706261 Trillian test result (tid-1303) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 54181 seconds

[GitHub] borisstoyanov opened a new pull request #2219: CLOUDSTACK-9989: Extend smoketests suite

2017-08-02 Thread git
borisstoyanov opened a new pull request #2219: CLOUDSTACK-9989: Extend smoketests suite URL: https://github.com/apache/cloudstack/pull/2219 This is an automated message from the Apache Git Service. To respond to the

[GitHub] blueorangutan commented on issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a network for exte?

2017-08-02 Thread git
blueorangutan commented on issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a network for exte? URL: https://github.com/apache/cloudstack/pull/1246#issuecomment-319698199 Packaging result: ?centos6 ?centos7 ?debian. JID-901

[GitHub] borisstoyanov commented on issue #2209: CLOUDSTACK-10017: Adding 'quick-test' attribute to list of smoketests?

2017-08-02 Thread git
borisstoyanov commented on issue #2209: CLOUDSTACK-10017: Adding 'quick-test' attribute to list of smoketests? URL: https://github.com/apache/cloudstack/pull/2209#issuecomment-319692039 Thanks @rhtyd, I've rebased and squashed all the commits

[GitHub] blueorangutan commented on issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a network for exte?

2017-08-02 Thread git
blueorangutan commented on issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a network for exte? URL: https://github.com/apache/cloudstack/pull/1246#issuecomment-319679083 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a network for exte?

2017-08-02 Thread git
rhtyd commented on issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a network for exte? URL: https://github.com/apache/cloudstack/pull/1246#issuecomment-319678785 @blueorangutan package This is an automated

[GitHub] blueorangutan commented on issue #2217: [4.9] Smoketest health checkrun

2017-08-02 Thread git
blueorangutan commented on issue #2217: [4.9] Smoketest health checkrun URL: https://github.com/apache/cloudstack/pull/2217#issuecomment-319676741 Trillian test result (tid-1301) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6 Total time taken: 62466 seconds

[GitHub] rhtyd commented on issue #2209: CLOUDSTACK-10017: Adding 'quick-test' attribute to list of smoketests?

2017-08-02 Thread git
rhtyd commented on issue #2209: CLOUDSTACK-10017: Adding 'quick-test' attribute to list of smoketests? URL: https://github.com/apache/cloudstack/pull/2209#issuecomment-319671507 Good effort, @borisstoyanov can you rebase Github is such a complainer :)

[GitHub] blueorangutan commented on issue #2218: CLOUDSTACK-9782: New Background Polling Task Manager

2017-08-02 Thread git
blueorangutan commented on issue #2218: CLOUDSTACK-9782: New Background Polling Task Manager URL: https://github.com/apache/cloudstack/pull/2218#issuecomment-319659778 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] borisstoyanov commented on issue #2218: CLOUDSTACK-9782: New Background Polling Task Manager

2017-08-02 Thread git
borisstoyanov commented on issue #2218: CLOUDSTACK-9782: New Background Polling Task Manager URL: https://github.com/apache/cloudstack/pull/2218#issuecomment-319659709 @blueorangutan test This is an automated message from

[GitHub] syed commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM

2017-08-02 Thread git
syed commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM URL: https://github.com/apache/cloudstack/pull/2204#issuecomment-319658897 @sachinnitw1317 Can you also have a look at

[GitHub] rhtyd commented on issue #2218: CLOUDSTACK-9782: New Background Polling Task Manager

2017-08-02 Thread git
rhtyd commented on issue #2218: CLOUDSTACK-9782: New Background Polling Task Manager URL: https://github.com/apache/cloudstack/pull/2218#issuecomment-319623377 @borisstoyanov @DaanHoogland and others - please review. This

[GitHub] borisstoyanov commented on issue #2203: All private, public, and guest interfaceses are marked as untagged ca?

2017-08-02 Thread git
borisstoyanov commented on issue #2203: All private, public, and guest interfaceses are marked as untagged ca? URL: https://github.com/apache/cloudstack/pull/2203#issuecomment-319591440 Hi @konstantintrushin, you can create a ticket describing your improvement/bugfix in the community