[GitHub] blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type

2017-08-23 Thread git
blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-324550168 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke te

[GitHub] DaanHoogland commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type

2017-08-23 Thread git
DaanHoogland commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-324549949 @blueorangutan test This is an automa

[GitHub] blueorangutan commented on issue #1733: CLOUDSTACK-9563 ExtractTemplate returns malformed URL after migrating?

2017-08-23 Thread git
blueorangutan commented on issue #1733: CLOUDSTACK-9563 ExtractTemplate returns malformed URL after migrating? URL: https://github.com/apache/cloudstack/pull/1733#issuecomment-324548909 Packaging result: ?centos6 ?centos7 ?debian. JID-1017 -

[GitHub] blueorangutan commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
blueorangutan commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#issuecomment-324545007 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests --

[GitHub] blueorangutan commented on issue #1733: CLOUDSTACK-9563 ExtractTemplate returns malformed URL after migrating?

2017-08-23 Thread git
blueorangutan commented on issue #1733: CLOUDSTACK-9563 ExtractTemplate returns malformed URL after migrating? URL: https://github.com/apache/cloudstack/pull/1733#issuecomment-324544827 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] rhtyd commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#issuecomment-324544888 @blueorangutan test centos7 xenserver-65sp1 This is an automated messa

[GitHub] blueorangutan commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id

2017-08-23 Thread git
blueorangutan commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id URL: https://github.com/apache/cloudstack/pull/2243#issuecomment-324544673 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests

[GitHub] rhtyd commented on issue #1733: CLOUDSTACK-9563 ExtractTemplate returns malformed URL after migrating?

2017-08-23 Thread git
rhtyd commented on issue #1733: CLOUDSTACK-9563 ExtractTemplate returns malformed URL after migrating? URL: https://github.com/apache/cloudstack/pull/1733#issuecomment-324544744 @blueorangutan package This is an automated me

[GitHub] rhtyd commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id

2017-08-23 Thread git
rhtyd commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id URL: https://github.com/apache/cloudstack/pull/2243#issuecomment-324544552 @mrunalinikankariya can you check and fix the errors, are issues around iso permissions (public or not) should not happen, the te

[GitHub] mrunalinikankariya commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id

2017-08-23 Thread git
mrunalinikankariya commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id URL: https://github.com/apache/cloudstack/pull/2243#issuecomment-324537219 Test failure doesn't seem to be relevant to the change for this ticket

[GitHub] SudharmaJain commented on issue #876: CLOUDSTACK-8865: Adding SR doesn't create Storage_pool_host_ref entry?

2017-08-23 Thread git
SudharmaJain commented on issue #876: CLOUDSTACK-8865: Adding SR doesn't create Storage_pool_host_ref entry? URL: https://github.com/apache/cloudstack/pull/876#issuecomment-324538684 tag:mergeready This is an automated messa

[GitHub] SudharmaJain commented on issue #1733: CLOUDSTACK-9563 ExtractTemplate returns malformed URL after migrating?

2017-08-23 Thread git
SudharmaJain commented on issue #1733: CLOUDSTACK-9563 ExtractTemplate returns malformed URL after migrating? URL: https://github.com/apache/cloudstack/pull/1733#issuecomment-324537402 @jburwell Do we have the ability to execute s3 specific marvin tests? -

[GitHub] mrunalinikankariya commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id

2017-08-23 Thread git
mrunalinikankariya commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id URL: https://github.com/apache/cloudstack/pull/2243#issuecomment-324537219 Test failure doesn't seem to be relevant to the change for this change

[GitHub] SudharmaJain commented on issue #1733: CLOUDSTACK-9563 ExtractTemplate returns malformed URL after migrating?

2017-08-23 Thread git
SudharmaJain commented on issue #1733: CLOUDSTACK-9563 ExtractTemplate returns malformed URL after migrating? URL: https://github.com/apache/cloudstack/pull/1733#issuecomment-324536874 Here are some manual test results. Before applying the fix for template download I see following ur

[GitHub] blueorangutan commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id

2017-08-23 Thread git
blueorangutan commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id URL: https://github.com/apache/cloudstack/pull/2243#issuecomment-324528686 Trillian test result (tid-1413) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time tak

[GitHub] cloudmonger commented on issue #2214: Speed-up VR initialisation/configuration

2017-08-23 Thread git
cloudmonger commented on issue #2214: Speed-up VR initialisation/configuration URL: https://github.com/apache/cloudstack/pull/2214#issuecomment-323870070 ### ACS CI BVT Run **Sumarry:** Build Number 1124 Hypervisor xenserver NetworkType Advanced Passed=110 Failed=4

[GitHub] cloudmonger commented on issue #2214: Speed-up VR initialisation/configuration

2017-08-23 Thread git
cloudmonger commented on issue #2214: Speed-up VR initialisation/configuration URL: https://github.com/apache/cloudstack/pull/2214#issuecomment-324528552 ### ACS CI BVT Run **Sumarry:** Build Number 1137 Hypervisor xenserver NetworkType Advanced Passed=105 Failed=5

[GitHub] rhtyd closed pull request #2123: CLOUDSTACK-9914: update Quota plugin to support currency values up to 5 decimal places

2017-08-23 Thread git
rhtyd closed pull request #2123: CLOUDSTACK-9914: update Quota plugin to support currency values up to 5 decimal places URL: https://github.com/apache/cloudstack/pull/2123 This is an automated message from the Apache Git Se

[GitHub] rhtyd commented on issue #2123: CLOUDSTACK-9914: update Quota plugin to support currency values up to 5 decimal places

2017-08-23 Thread git
rhtyd commented on issue #2123: CLOUDSTACK-9914: update Quota plugin to support currency values up to 5 decimal places URL: https://github.com/apache/cloudstack/pull/2123#issuecomment-324441049 LGTM, a db change validated with Travis and BVT is okay. --

[cloudstack] branch master updated: CLOUDSTACK-9914: Update Quota plugin to support currency values up to 5 decimal places (#2123)

2017-08-23 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 57255ac CLOUDSTACK-9914: Update Quota plu

[GitHub] blueorangutan commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id

2017-08-23 Thread git
blueorangutan commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id URL: https://github.com/apache/cloudstack/pull/2243#issuecomment-324441005 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] blueorangutan commented on issue #2206: [CLOUDSTACK-10020] Changes to make marvin work with projects and VPCs

2017-08-23 Thread git
blueorangutan commented on issue #2206: [CLOUDSTACK-10020] Changes to make marvin work with projects and VPCs URL: https://github.com/apache/cloudstack/pull/2206#issuecomment-324441010 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] rhtyd commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id

2017-08-23 Thread git
rhtyd commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id URL: https://github.com/apache/cloudstack/pull/2243#issuecomment-324440907 @blueorangutan test This is an automated message from the Apach

[GitHub] rhtyd commented on issue #2206: [CLOUDSTACK-10020] Changes to make marvin work with projects and VPCs

2017-08-23 Thread git
rhtyd commented on issue #2206: [CLOUDSTACK-10020] Changes to make marvin work with projects and VPCs URL: https://github.com/apache/cloudstack/pull/2206#issuecomment-324440857 @blueorangutan test This is an automated messag

[GitHub] rafaelweingartner commented on issue #2123: CLOUDSTACK-9914: update Quota plugin to support currency values up to 5 decimal places

2017-08-23 Thread git
rafaelweingartner commented on issue #2123: CLOUDSTACK-9914: update Quota plugin to support currency values up to 5 decimal places URL: https://github.com/apache/cloudstack/pull/2123#issuecomment-324398815 @DaanHoogland or @swill can one of will merge this one? Everything seems to be ok,

[GitHub] blueorangutan commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id

2017-08-23 Thread git
blueorangutan commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id URL: https://github.com/apache/cloudstack/pull/2243#issuecomment-324392571 Packaging result: ?centos6 ?centos7 ?debian. JID-1016 T

[GitHub] blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type

2017-08-23 Thread git
blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-324392344 Packaging result: ?centos6 ?centos7 ?debian. JID-1015 ---

[GitHub] blueorangutan commented on issue #2206: [CLOUDSTACK-10020] Changes to make marvin work with projects and VPCs

2017-08-23 Thread git
blueorangutan commented on issue #2206: [CLOUDSTACK-10020] Changes to make marvin work with projects and VPCs URL: https://github.com/apache/cloudstack/pull/2206#issuecomment-324387645 Packaging result: ?centos6 ?centos7 ?debian. JID-1014 --

[GitHub] blueorangutan commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
blueorangutan commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#issuecomment-324387473 Packaging result: ?centos6 ?centos7 ?debian. JID-1012 This is

[GitHub] blueorangutan commented on issue #2217: [4.9] Smoketest health checkrun

2017-08-23 Thread git
blueorangutan commented on issue #2217: [4.9] Smoketest health checkrun URL: https://github.com/apache/cloudstack/pull/2217#issuecomment-324387480 Packaging result: ?centos6 ?centos7 ?debian. JID-1013 This is an automated mes

[GitHub] blueorangutan commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id

2017-08-23 Thread git
blueorangutan commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id URL: https://github.com/apache/cloudstack/pull/2243#issuecomment-324378070 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] rhtyd commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id

2017-08-23 Thread git
rhtyd commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id URL: https://github.com/apache/cloudstack/pull/2243#issuecomment-324378008 @blueorangutan package This is an automated message from the Ap

[GitHub] rhtyd commented on a change in pull request #1985: CLOUDSTACK-9812:Update "updatePortForwardingRule" api to include additional parameter to update the end port in case of port range

2017-08-23 Thread git
rhtyd commented on a change in pull request #1985: CLOUDSTACK-9812:Update "updatePortForwardingRule" api to include additional parameter to update the end port in case of port range URL: https://github.com/apache/cloudstack/pull/1985#discussion_r134791577 ## File path: test/integra

[GitHub] blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type

2017-08-23 Thread git
blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-324377424 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] rhtyd commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type

2017-08-23 Thread git
rhtyd commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-324377210 @blueorangutan package This is an automated

[GitHub] blueorangutan commented on issue #2206: [CLOUDSTACK-10020] Changes to make marvin work with projects and VPCs

2017-08-23 Thread git
blueorangutan commented on issue #2206: [CLOUDSTACK-10020] Changes to make marvin work with projects and VPCs URL: https://github.com/apache/cloudstack/pull/2206#issuecomment-324377145 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] rhtyd commented on issue #2206: [CLOUDSTACK-10020] Changes to make marvin work with projects and VPCs

2017-08-23 Thread git
rhtyd commented on issue #2206: [CLOUDSTACK-10020] Changes to make marvin work with projects and VPCs URL: https://github.com/apache/cloudstack/pull/2206#issuecomment-324376904 @blueorangutan package This is an automated mes

[GitHub] blueorangutan commented on issue #2217: [4.9] Smoketest health checkrun

2017-08-23 Thread git
blueorangutan commented on issue #2217: [4.9] Smoketest health checkrun URL: https://github.com/apache/cloudstack/pull/2217#issuecomment-324375924 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] rhtyd commented on issue #2217: [4.9] Smoketest health checkrun

2017-08-23 Thread git
rhtyd commented on issue #2217: [4.9] Smoketest health checkrun URL: https://github.com/apache/cloudstack/pull/2217#issuecomment-324375881 @blueorangutan package This is an automated message from the Apache Git Service. To re

[GitHub] rhtyd commented on issue #2217: [4.9] Smoketest health checkrun

2017-08-23 Thread git
rhtyd commented on issue #2217: [4.9] Smoketest health checkrun URL: https://github.com/apache/cloudstack/pull/2217#issuecomment-324375819 @borisstoyanov I debugged, rp_filter is set by `CsAddress.py` and it's not the root cause. However, in all cases the backup router worked okay as soon a

[GitHub] blueorangutan commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
blueorangutan commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#issuecomment-324374439 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on issue #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#issuecomment-324374398 @blueorangutan package This is an automated message from the Apache Gi

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134777167 ## File path: utils/src/main/java/org/apache/cloudstack/utils/security/KeyStoreUtils.java ## @@ -0,

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134777152 ## File path: utils/src/main/java/org/apache/cloudstack/utils/security/KeyStoreUtils.java ## @@ -0,

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134776909 ## File path: utils/pom.xml ## @@ -72,6 +77,10 @@ bcprov-jdk15on + org.bounc

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134776749 ## File path: setup/db/server-setup.sql ## @@ -27,3 +27,6 @@ INSERT INTO `cloud`.`configuration` (ca

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134776690 ## File path: services/secondary-storage/controller/src/org/apache/cloudstack/secondarystorage/SecondaryStora

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134776431 ## File path: server/src/org/apache/cloudstack/ca/CAManagerImpl.java ## @@ -0,0 +1,427 @@ +// Licens

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134775466 ## File path: server/src/org/apache/cloudstack/ca/CAManagerImpl.java ## @@ -0,0 +1,427 @@ +// Licens

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134775294 ## File path: server/src/org/apache/cloudstack/ca/CAManagerImpl.java ## @@ -0,0 +1,427 @@ +// Licens

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134774970 ## File path: server/src/org/apache/cloudstack/ca/CAManagerImpl.java ## @@ -0,0 +1,427 @@ +// Licens

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134774674 ## File path: server/src/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java ## @@ -12

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134774587 ## File path: plugins/ca/root-ca/src/org/apache/cloudstack/ca/provider/RootCAProvider.java ## @@ -0

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134774348 ## File path: plugins/ca/root-ca/src/org/apache/cloudstack/ca/provider/RootCAProvider.java ## @@ -0

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134774309 ## File path: plugins/ca/root-ca/src/org/apache/cloudstack/ca/provider/RootCAProvider.java ## @@ -0

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134773904 ## File path: plugins/ca/root-ca/src/org/apache/cloudstack/ca/provider/RootCAProvider.java ## @@ -0

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134773821 ## File path: framework/ca/src/org/apache/cloudstack/framework/ca/Certificate.java ## @@ -0,0 +1,46

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134773695 ## File path: framework/ca/src/org/apache/cloudstack/framework/ca/CAService.java ## @@ -0,0 +1,36 @@

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134773185 ## File path: framework/ca/src/org/apache/cloudstack/framework/ca/CAProvider.java ## @@ -0,0 +1,93 @

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134773144 ## File path: framework/ca/src/org/apache/cloudstack/framework/ca/CAProvider.java ## @@ -0,0 +1,93 @

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134773126 ## File path: framework/ca/src/org/apache/cloudstack/framework/ca/CAProvider.java ## @@ -0,0 +1,93 @

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134773048 ## File path: framework/ca/src/org/apache/cloudstack/framework/ca/CAProvider.java ## @@ -0,0 +1,93 @

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134772656 ## File path: framework/ca/src/org/apache/cloudstack/framework/ca/CAProvider.java ## @@ -0,0 +1,93 @

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134772485 ## File path: engine/schema/src/com/cloud/certificate/dao/CrlDaoImpl.java ## @@ -0,0 +1,57 @@ +// Li

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134772018 ## File path: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ## @@ -1073,6 +10

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134771492 ## File path: engine/orchestration/src/com/cloud/agent/manager/ClusteredAgentManagerImpl.java ## @@

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134771334 ## File path: core/src/com/cloud/agent/api/routing/NetworkElementCommand.java ## @@ -46,6 +47,18 @@

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134771110 ## File path: api/src/org/apache/cloudstack/api/response/CertificateResponse.java ## @@ -0,0 +1,58 @

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134770785 ## File path: api/src/org/apache/cloudstack/api/command/admin/ca/IssueCertificateCmd.java ## @@ -0,

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134770614 ## File path: api/src/org/apache/cloudstack/api/command/admin/ca/IssueCertificateCmd.java ## @@ -0,

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134770495 ## File path: api/src/org/apache/cloudstack/api/command/admin/ca/IssueCertificateCmd.java ## @@ -0,

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134770453 ## File path: api/src/org/apache/cloudstack/api/command/admin/ca/IssueCertificateCmd.java ## @@ -0,

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134770166 ## File path: api/src/org/apache/cloudstack/alert/AlertService.java ## @@ -67,6 +67,7 @@ private Ale

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134770194 ## File path: api/src/org/apache/cloudstack/alert/AlertService.java ## @@ -67,6 +67,7 @@ private Ale

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134770033 ## File path: agent/src/com/cloud/agent/dao/impl/PropertiesStorage.java ## @@ -51,6 +51,9 @@ public

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134769420 ## File path: agent/test/com/cloud/agent/AgentShellTest.java ## @@ -44,4 +48,15 @@ public void loadP

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134769242 ## File path: agent/src/com/cloud/agent/AgentShell.java ## @@ -107,7 +108,16 @@ public String getPod

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134769071 ## File path: agent/src/com/cloud/agent/AgentShell.java ## @@ -107,7 +108,16 @@ public String getPod

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134768766 ## File path: agent/src/com/cloud/agent/Agent.java ## @@ -464,7 +493,7 @@ protected void processRequ

[GitHub] rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
rhtyd commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134768488 ## File path: agent/src/com/cloud/agent/Agent.java ## @@ -166,7 +178,8 @@ public Agent(final IAgentS

[GitHub] rhtyd commented on issue #2245: increased jetty timeout

2017-08-23 Thread git
rhtyd commented on issue #2245: increased jetty timeout URL: https://github.com/apache/cloudstack/pull/2245#issuecomment-324352471 Actually, this is fixing the symptom and not the problem itself. I've addressed this part of the PR #2239, jetty takes time in scanning annotations that are no

[GitHub] rhtyd commented on a change in pull request #2216: CLOUDSTACK-10027 Repeating the same list for Internal LB in VPC

2017-08-23 Thread git
rhtyd commented on a change in pull request #2216: CLOUDSTACK-10027 Repeating the same list for Internal LB in VPC URL: https://github.com/apache/cloudstack/pull/2216#discussion_r134766814 ## File path: ui/scripts/vpc.js ## @@ -745,12 +745,24 @@ }

[GitHub] rhtyd commented on a change in pull request #2216: CLOUDSTACK-10027 Repeating the same list for Internal LB in VPC

2017-08-23 Thread git
rhtyd commented on a change in pull request #2216: CLOUDSTACK-10027 Repeating the same list for Internal LB in VPC URL: https://github.com/apache/cloudstack/pull/2216#discussion_r134763805 ## File path: ui/scripts/vpc.js ## @@ -745,12 +745,24 @@ }

[GitHub] DaanHoogland opened a new pull request #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type

2017-08-23 Thread git
DaanHoogland opened a new pull request #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type URL: https://github.com/apache/cloudstack/pull/2246 This fixes a very old regression where the checksum wouldn't be checked on downloaded templates. It checks again

[GitHub] blueorangutan commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider

2017-08-23 Thread git
blueorangutan commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider URL: https://github.com/apache/cloudstack/pull/1960#issuecomment-324329059 Trillian test result (tid-1412) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total tim

[GitHub] vedulasantosh commented on a change in pull request #2216: CLOUDSTACK-10027 Repeating the same list for Internal LB in VPC

2017-08-23 Thread git
vedulasantosh commented on a change in pull request #2216: CLOUDSTACK-10027 Repeating the same list for Internal LB in VPC URL: https://github.com/apache/cloudstack/pull/2216#discussion_r134726488 ## File path: ui/scripts/vpc.js ## @@ -745,12 +745,24 @@

[GitHub] blueorangutan commented on issue #2214: Speed-up VR initialisation/configuration

2017-08-23 Thread git
blueorangutan commented on issue #2214: Speed-up VR initialisation/configuration URL: https://github.com/apache/cloudstack/pull/2214#issuecomment-324295242 Packaging result: ?centos6 ?centos7 ?debian. JID-1011 This is an auto

[GitHub] cloudmonger commented on issue #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts

2017-08-23 Thread git
cloudmonger commented on issue #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts URL: https://github.com/apache/cloudstack/pull/2054#issuecomment-324293478 ### ACS CI BVT Run **Sumarry:** Build Number 1132 Hypervisor xenserver N

[GitHub] blueorangutan commented on issue #2214: Speed-up VR initialisation/configuration

2017-08-23 Thread git
blueorangutan commented on issue #2214: Speed-up VR initialisation/configuration URL: https://github.com/apache/cloudstack/pull/2214#issuecomment-324290676 @DagSonsteboSB a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] DagSonsteboSB commented on issue #2214: Speed-up VR initialisation/configuration

2017-08-23 Thread git
DagSonsteboSB commented on issue #2214: Speed-up VR initialisation/configuration URL: https://github.com/apache/cloudstack/pull/2214#issuecomment-324290551 @blueorangutan package This is an automated message from the Apache G

[GitHub] DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134705330 ## File path: server/src/org/apache/cloudstack/ca/CAManagerImpl.java ## @@ -0,0 +1,427 @@ +//

[GitHub] DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134695744 ## File path: plugins/ca/root-ca/src/org/apache/cloudstack/ca/provider/RootCAProvider.java ##

[GitHub] DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134409796 ## File path: api/src/org/apache/cloudstack/alert/AlertService.java ## @@ -67,6 +67,7 @@ priv

[GitHub] DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134431321 ## File path: engine/orchestration/src/com/cloud/agent/manager/ClusteredAgentManagerImpl.java ###

[GitHub] DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134696200 ## File path: plugins/ca/root-ca/src/org/apache/cloudstack/ca/provider/RootCAProvider.java ##

[GitHub] DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134686114 ## File path: framework/ca/src/org/apache/cloudstack/framework/ca/Certificate.java ## @@ -0,0

[GitHub] DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134685640 ## File path: framework/ca/src/org/apache/cloudstack/framework/ca/CAProvider.java ## @@ -0,0

[GitHub] DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134688213 ## File path: plugins/ca/root-ca/src/org/apache/cloudstack/ca/provider/RootCAProvider.java ##

[GitHub] DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134705103 ## File path: server/src/org/apache/cloudstack/ca/CAManagerImpl.java ## @@ -0,0 +1,427 @@ +//

[GitHub] DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications

2017-08-23 Thread git
DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993: Securing Agents Communications URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134711534 ## File path: utils/src/main/java/org/apache/cloudstack/utils/security/KeyStoreUtils.java ##

  1   2   >