rhtyd commented on a change in pull request #1707: CLOUDSTACK-9397: Add
Watchdog timer to KVM Instance
URL: https://github.com/apache/cloudstack/pull/1707#discussion_r141537257
##
File path:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
blueorangutan commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed
login message to a configurable URL
URL: https://github.com/apache/cloudstack/pull/2185#issuecomment-332741242
Packaging result: ?centos6 ?centos7 ?debian. JID-1117
-
blueorangutan commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed
login message to a configurable URL
URL: https://github.com/apache/cloudstack/pull/2185#issuecomment-332738063
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted
as I make progress.
-
rhtyd commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login
message to a configurable URL
URL: https://github.com/apache/cloudstack/pull/2185#issuecomment-332737869
@blueorangutan package
This is an auto
blueorangutan commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed
login message to a configurable URL
URL: https://github.com/apache/cloudstack/pull/2185#issuecomment-332734286
Packaging result: ?centos6 ?centos7 ?debian. JID-1116
-
blueorangutan commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed
login message to a configurable URL
URL: https://github.com/apache/cloudstack/pull/2185#issuecomment-332731455
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted
as I make progress.
-
rhtyd commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login
message to a configurable URL
URL: https://github.com/apache/cloudstack/pull/2185#issuecomment-332731324
@blueorangutan package
This is an automate
rhtyd commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in
listTemplate API to improve performance
URL: https://github.com/apache/cloudstack/pull/2260#issuecomment-332731130
@PranaliM I've left some code review comments, please have a look. Can you
also attempt to add some u
rhtyd commented on a change in pull request #2260: CLOUDSTACK-10065: Optimize
SQL queries in listTemplate API to improve performance
URL: https://github.com/apache/cloudstack/pull/2260#discussion_r141528435
##
File path: framework/db/src/com/cloud/utils/db/SqlGenerator.java
###
rhtyd commented on a change in pull request #2260: CLOUDSTACK-10065: Optimize
SQL queries in listTemplate API to improve performance
URL: https://github.com/apache/cloudstack/pull/2260#discussion_r141528329
##
File path: framework/db/src/com/cloud/utils/db/GenericDaoBase.java
#
rhtyd commented on a change in pull request #2260: CLOUDSTACK-10065: Optimize
SQL queries in listTemplate API to improve performance
URL: https://github.com/apache/cloudstack/pull/2260#discussion_r141528300
##
File path: framework/db/src/com/cloud/utils/db/GenericDaoBase.java
#
rhtyd commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning
URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-332730455
@blueorangutan test
This is an automated message from the Apache Git S
blueorangutan commented on issue #2266: CLOUDSTACK-10073: KVM host RAM
overprovisioning
URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-332730472
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
--
rhtyd commented on a change in pull request #2258: Cloudstack 10064: Secondary
storage Usage for uploadedVolume is not collected
URL: https://github.com/apache/cloudstack/pull/2258#discussion_r141528068
##
File path: test/integration/component/Upload_Volume_test_case.py
##
PranaliM commented on a change in pull request #2258: Cloudstack 10064:
Secondary storage Usage for uploadedVolume is not collected
URL: https://github.com/apache/cloudstack/pull/2258#discussion_r141527527
##
File path: test/integration/testpaths/Upload_Volume_test_case.py
PranaliM commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in
listTemplate API to improve performance
URL: https://github.com/apache/cloudstack/pull/2260#issuecomment-332729267
@rhtyd : Could you please merge this change ? There are 2 Test LGTM and a
Code LGTM, and no outsta
blueorangutan commented on issue #2266: CLOUDSTACK-10073: KVM host RAM
overprovisioning
URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-332726498
Packaging result: ?centos6 ?centos7 ?debian. JID-1115
This is
rhtyd commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables
instead of UUID.
URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-332726534
@jayantpatil1234 I've some general feedback:
- Good work and initiative on refactoring the event/log output to expor
blueorangutan commented on issue #2263: CLOUDSTACK-10070: Fixing some component
tests and adding them in travis
URL: https://github.com/apache/cloudstack/pull/2263#issuecomment-332725118
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
--
rhtyd commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests
and adding them in travis
URL: https://github.com/apache/cloudstack/pull/2263#issuecomment-332724992
@borisstoyanov we'll have to re-run the tests, I fixed the issue the
additional tests need to be space separate
blueorangutan commented on issue #2266: CLOUDSTACK-10073: KVM host RAM
overprovisioning
URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-332723686
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted
as I make progress.
rhtyd commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning
URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-332723647
@blueorangutan package
This is an automated message from the Apache Gi
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-332723588
Ignoring test failures on centos6, LGTM. @borisstoyanov @wido @kiwiflyer
what do you think, should we merge this PR?
blueorangutan commented on issue #2249: CLOUDSTACK-10007 Isolation method claim
URL: https://github.com/apache/cloudstack/pull/2249#issuecomment-332670587
Trillian test result (tid-1541)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39653 secon
blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to
KVM Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-332642799
Trillian test result (tid-1539)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken
DaanHoogland commented on issue #2208: CLOUDSTACK-9542 make listNics and
ListUserVms return uniform NIC data
URL: https://github.com/apache/cloudstack/pull/2208#issuecomment-325261313
@blueorangutan test
This is an automate
DaanHoogland commented on issue #2208: CLOUDSTACK-9542 make listNics and
ListUserVms return uniform NIC data
URL: https://github.com/apache/cloudstack/pull/2208#issuecomment-332578949
@blueorangutan test
This is an automated
blueorangutan commented on issue #2208: CLOUDSTACK-9542 make listNics and
ListUserVms return uniform NIC data
URL: https://github.com/apache/cloudstack/pull/2208#issuecomment-332579115
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has
been kicked to run smoke tests
DaanHoogland commented on issue #2074: CLOUDSTACK-9899 Url validation disabling
URL: https://github.com/apache/cloudstack/pull/2074#issuecomment-332578454
@blueorangutan test
This is an automated message from the Apache Git S
blueorangutan commented on issue #2074: CLOUDSTACK-9899 Url validation disabling
URL: https://github.com/apache/cloudstack/pull/2074#issuecomment-332578596
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has
been kicked to run smoke tests
---
PranaliM commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in
listTemplate API to improve performance
URL: https://github.com/apache/cloudstack/pull/2260#issuecomment-332544636
tag:mergeready
This is an automa
blueorangutan commented on issue #2074: CLOUDSTACK-9899 Url validation disabling
URL: https://github.com/apache/cloudstack/pull/2074#issuecomment-332541887
Packaging result: ?centos6 ?centos7 ?debian. JID-1114
This is an auto
blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation
for any java supported Digests-type
URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-332534093
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has
been kicked to run smoke te
DaanHoogland commented on issue #2246: CLOUDSTACK-10046 checksum validation for
any java supported Digests-type
URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-332533747
@blueorangutan test
This is an automa
blueorangutan commented on issue #2074: CLOUDSTACK-9899 Url validation disabling
URL: https://github.com/apache/cloudstack/pull/2074#issuecomment-332533424
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
-
DaanHoogland commented on issue #2074: CLOUDSTACK-9899 Url validation disabling
URL: https://github.com/apache/cloudstack/pull/2074#issuecomment-332533178
@blueorangutan package
This is an automated message from the Apache Gi
DaanHoogland commented on issue #2232: CLOUDSTACK-10040 Upload volume fails
when management server can not r?
URL: https://github.com/apache/cloudstack/pull/2232#issuecomment-332526126
@yvsubhash sorry to say I do not get github notifications anymore. I will
that. I have done the exact sam
DaanHoogland commented on issue #2232: CLOUDSTACK-10040 Upload volume fails
when management server can not r?
URL: https://github.com/apache/cloudstack/pull/2232#issuecomment-332524300
seen this seems to do the same thing. give me some time. I am not biased on
which solution to use but wan
blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation
for any java supported Digests-type
URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-332522535
Packaging result: ?centos6 ?centos7 ?debian. JID-1113
---
blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation
for any java supported Digests-type
URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-332519891
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress
DaanHoogland commented on issue #2246: CLOUDSTACK-10046 checksum validation for
any java supported Digests-type
URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-332519671
@rhtyd these were requested off-line not by you. I've added the extra commit
now and am re-spawning pac
GabrielBrascher commented on a change in pull request #1448: CLOUDSTACK-9315:
Removed unused Classes
URL: https://github.com/apache/cloudstack/pull/1448#discussion_r141315427
##
File path: server/src/com/cloud/configuration/Config.java
##
@@ -1900,9 +1900,9 @@
GabrielBrascher commented on issue #2185: CLOUDSTACK-9976: Redirect saml2
failed login message to a configurable URL
URL: https://github.com/apache/cloudstack/pull/2185#issuecomment-332481936
Refactored using ConfigKey, as you suggested @rhtyd. Thanks for all the
feedback!
--
yvsubhash commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in
listTemplate API to improve performance
URL: https://github.com/apache/cloudstack/pull/2260#issuecomment-332481225
Reviewed the code LGTM
This is
blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to
KVM Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-332478817
Trillian test result (tid-1538)
Environment: kvm-centos6 (x2), Advanced Networking with Mgmt server 7
Total time taken
GabrielBrascher opened a new pull request #2185: CLOUDSTACK-9976: Redirect
saml2 failed login message to a configurable URL
URL: https://github.com/apache/cloudstack/pull/2185
When a user fails to authenticate with SAML2, it returns an error page
showing the content of the following imag
rhtyd commented on issue #2246: CLOUDSTACK-10046 checksum validation for any
java supported Digests-type
URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-332469827
@DaanHoogland I've not requested for any further change, I've already shared
my LGTM on this. I'm not sure if
DaanHoogland commented on issue #2061: CLOUDSTACK-8308 automation test for
Delta Snapshot
URL: https://github.com/apache/cloudstack/pull/2061#issuecomment-332460062
@borisstoyanov can you run with this?
This is an automated
DaanHoogland commented on issue #2246: CLOUDSTACK-10046 checksum validation for
any java supported Digests-type
URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-33238
@rhtyd on request i'll improve the API doc strings and then we can merge.
thanks
blueorangutan commented on issue #2249: WIP CLOUDSTACK-10007 Isolation method
claim
URL: https://github.com/apache/cloudstack/pull/2249#issuecomment-332444136
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has
been kicked to run smoke tests
---
DaanHoogland opened a new pull request #2276: WIP: CLOUDSTACK-10089 log4j
update to version 2
URL: https://github.com/apache/cloudstack/pull/2276
This is an automated message from the Apache Git Service.
To respond to the m
DaanHoogland commented on issue #2249: WIP CLOUDSTACK-10007 Isolation method
claim
URL: https://github.com/apache/cloudstack/pull/2249#issuecomment-332443840
@blueorangutan test
This is an automated message from the Apache G
52 matches
Mail list logo
