[GitHub] wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-28 Thread git
wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-332746879 I personally think we can merge it. But hey, it's my PR, I can't make that decision. -

[GitHub] wido commented on issue #2275: CLOUDSTACK-9975: Allow customizing system VM templates for SSVM and Console Proxy

2017-09-28 Thread git
wido commented on issue #2275: CLOUDSTACK-9975: Allow customizing system VM templates for SSVM and Console Proxy URL: https://github.com/apache/cloudstack/pull/2275#issuecomment-332747433 Very nice and interesting! It might even be that in the future we should leverage this even more. This

[GitHub] wido commented on issue #2269: CLOUDSTACK-10083: Allow ModifySshKeys to be forwarded to the agent in?

2017-09-28 Thread git
wido commented on issue #2269: CLOUDSTACK-10083: Allow ModifySshKeys to be forwarded to the agent in? URL: https://github.com/apache/cloudstack/pull/2269#issuecomment-332747599 LGTM based on the code This is an automated mes

[GitHub] rhtyd closed pull request #2269: CLOUDSTACK-10083: Allow ModifySshKeys to be forwarded to the agent in?

2017-09-28 Thread git
rhtyd closed pull request #2269: CLOUDSTACK-10083: Allow ModifySshKeys to be forwarded to the agent in? URL: https://github.com/apache/cloudstack/pull/2269 This is an automated message from the Apache Git Service. To respon

[cloudstack] branch master updated: CLOUDSTACK-10083: Allow ModifySshKeys to be forwarded to the agent in maintenance mode (#2269)

2017-09-28 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new e1cff7d CLOUDSTACK-10083: Allow ModifySsh

[GitHub] rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-28 Thread git
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-332748420 @wido can you comment on the potential NPE issue, see the code/comment? --

[GitHub] wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-28 Thread git
wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-332750768 @rhtyd: I already did? I added a if-statement around the check in case libvirt doesn't return anything. Which is highly unlikely -

[GitHub] blueorangutan commented on issue #2074: CLOUDSTACK-9899 Url validation disabling

2017-09-28 Thread git
blueorangutan commented on issue #2074: CLOUDSTACK-9899 Url validation disabling URL: https://github.com/apache/cloudstack/pull/2074#issuecomment-332755500 Trillian test result (tid-1543) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40675 seco

[GitHub] rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-28 Thread git
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-332765820 Alright based on test results and LGTMs presented on this PR, I'll merge this. If we hit regressions or error reports, we might rev

[GitHub] rhtyd closed pull request #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

2017-09-28 Thread git
rhtyd closed pull request #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707 This is an automated message from the Apache Git Service. To respond to the message, p

[cloudstack] branch master updated: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance (#1707)

2017-09-28 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new b130e55 CLOUDSTACK-9397: Add Watchdog tim

[GitHub] DaanHoogland closed pull request #2249: CLOUDSTACK-10007 Isolation method claim

2017-09-28 Thread git
DaanHoogland closed pull request #2249: CLOUDSTACK-10007 Isolation method claim URL: https://github.com/apache/cloudstack/pull/2249 This is an automated message from the Apache Git Service. To respond to the message, please

[cloudstack] branch master updated: CLOUDSTACK-10007 Isolation method claim (#2249)

2017-09-28 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new a06530d CLOUDSTACK-10007 Isolation method cla

[GitHub] blueorangutan commented on issue #2208: CLOUDSTACK-9542 make listNics and ListUserVms return uniform NIC data

2017-09-28 Thread git
blueorangutan commented on issue #2208: CLOUDSTACK-9542 make listNics and ListUserVms return uniform NIC data URL: https://github.com/apache/cloudstack/pull/2208#issuecomment-332782541 Trillian test result (tid-1544) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7

[GitHub] mrunalinikankariya commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts

2017-09-28 Thread git
mrunalinikankariya commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts URL: https://github.com/apache/cloudstack/pull/2054#discussion_r141574717 ## File path: engine/schema/src/com/cloud/host/dao/Host

[GitHub] mrunalinikankariya commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts

2017-09-28 Thread git
mrunalinikankariya commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts URL: https://github.com/apache/cloudstack/pull/2054#discussion_r141576059 ## File path: test/integration/component/test_host.py

[GitHub] rafaelweingartner commented on issue #1446: CLOUDSTACK-9313: Remove unused code from CloudZoneStartupProcessor

2017-09-28 Thread git
rafaelweingartner commented on issue #1446: CLOUDSTACK-9313: Remove unused code from CloudZoneStartupProcessor URL: https://github.com/apache/cloudstack/pull/1446#issuecomment-332807712 I took the liberty and fixed the conflicts of this PR. Now everything seems ok to go ---

[GitHub] PranaliM commented on a change in pull request #2258: Cloudstack 10064: Secondary storage Usage for uploadedVolume is not collected

2017-09-28 Thread git
PranaliM commented on a change in pull request #2258: Cloudstack 10064: Secondary storage Usage for uploadedVolume is not collected URL: https://github.com/apache/cloudstack/pull/2258#discussion_r141649765 ## File path: test/integration/component/Upload_Volume_test_case.py

[GitHub] blueorangutan commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning

2017-09-28 Thread git
blueorangutan commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-332934363 Trillian test result (tid-1546) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 36

[GitHub] blueorangutan commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis

2017-09-28 Thread git
blueorangutan commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis URL: https://github.com/apache/cloudstack/pull/2263#issuecomment-332964656 Trillian test result (tid-1545) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7

[GitHub] mike-tutkowski opened a new pull request #2277: CLOUDSTACK-10099

2017-09-28 Thread git
mike-tutkowski opened a new pull request #2277: CLOUDSTACK-10099 URL: https://github.com/apache/cloudstack/pull/2277 Fix for CLOUDSTACK-10099, which concerns the GUI not invoking the migrateVirtualMachineWithVolume API command when it should. --

[cloudstack] branch master updated: CLOUDSTACK-10073: KVM host RAM overprovisioning (#2266)

2017-09-28 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 3381c38 CLOUDSTACK-10073: KVM host RAM ov

[GitHub] rhtyd closed pull request #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning

2017-09-28 Thread git
rhtyd closed pull request #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning URL: https://github.com/apache/cloudstack/pull/2266 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] rhtyd commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning

2017-09-28 Thread git
rhtyd commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-333040410 LGTM, merging This is an automated message from the Apache Git Service

[GitHub] rhtyd commented on issue #2258: Cloudstack 10064: Secondary storage Usage for uploadedVolume is not collected

2017-09-28 Thread git
rhtyd commented on issue #2258: Cloudstack 10064: Secondary storage Usage for uploadedVolume is not collected URL: https://github.com/apache/cloudstack/pull/2258#issuecomment-333040561 @blueorangutan package This is an autom

[GitHub] blueorangutan commented on issue #2258: Cloudstack 10064: Secondary storage Usage for uploadedVolume is not collected

2017-09-28 Thread git
blueorangutan commented on issue #2258: Cloudstack 10064: Secondary storage Usage for uploadedVolume is not collected URL: https://github.com/apache/cloudstack/pull/2258#issuecomment-333040595 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] karuturi commented on issue #2277: CLOUDSTACK-10099

2017-09-28 Thread git
karuturi commented on issue #2277: CLOUDSTACK-10099 URL: https://github.com/apache/cloudstack/pull/2277#issuecomment-333042021 LGTM This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] rhtyd commented on issue #2277: CLOUDSTACK-10099

2017-09-28 Thread git
rhtyd commented on issue #2277: CLOUDSTACK-10099 URL: https://github.com/apache/cloudstack/pull/2277#issuecomment-333042375 LGTM, can we have some screenshots or UI confirmations (like before/after fix)? This is an automated

[GitHub] rhtyd commented on issue #2268: CLOUDSTACK-10081: getDevInfo now returns correct value

2017-09-28 Thread git
rhtyd commented on issue #2268: CLOUDSTACK-10081: getDevInfo now returns correct value URL: https://github.com/apache/cloudstack/pull/2268#issuecomment-333042452 @blueorangutan package This is an automated message from the A

[GitHub] blueorangutan commented on issue #2268: CLOUDSTACK-10081: getDevInfo now returns correct value

2017-09-28 Thread git
blueorangutan commented on issue #2268: CLOUDSTACK-10081: getDevInfo now returns correct value URL: https://github.com/apache/cloudstack/pull/2268#issuecomment-333042600 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] rhtyd commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis

2017-09-28 Thread git
rhtyd commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis URL: https://github.com/apache/cloudstack/pull/2263#issuecomment-333042888 @borisstoyanov please see/fix failing component test failures

[GitHub] blueorangutan commented on issue #2258: Cloudstack 10064: Secondary storage Usage for uploadedVolume is not collected

2017-09-28 Thread git
blueorangutan commented on issue #2258: Cloudstack 10064: Secondary storage Usage for uploadedVolume is not collected URL: https://github.com/apache/cloudstack/pull/2258#issuecomment-333044905 Packaging result: ?centos6 ?centos7 ?debian. JID-1118 --

[GitHub] nitin-maharana commented on issue #2277: CLOUDSTACK-10099

2017-09-28 Thread git
nitin-maharana commented on issue #2277: CLOUDSTACK-10099 URL: https://github.com/apache/cloudstack/pull/2277#issuecomment-333045305 LGTM This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] blueorangutan commented on issue #2268: CLOUDSTACK-10081: getDevInfo now returns correct value

2017-09-28 Thread git
blueorangutan commented on issue #2268: CLOUDSTACK-10081: getDevInfo now returns correct value URL: https://github.com/apache/cloudstack/pull/2268#issuecomment-333046733 Packaging result: ?centos6 ?centos7 ?debian. JID-1119

[GitHub] mike-tutkowski commented on issue #2277: CLOUDSTACK-10099

2017-09-28 Thread git
mike-tutkowski commented on issue #2277: CLOUDSTACK-10099 URL: https://github.com/apache/cloudstack/pull/2277#issuecomment-333046747 The GUI looks identical. From a behavioral standpoint, an error message is no longer displayed after the migration attempt because the migration report

[GitHub] rhtyd opened a new pull request #2278: CLOUDSTACK-9993: With auth strictness stop SSL handshake for rogue clients

2017-09-28 Thread git
rhtyd opened a new pull request #2278: CLOUDSTACK-9993: With auth strictness stop SSL handshake for rogue clients URL: https://github.com/apache/cloudstack/pull/2278 When auth strictness is set to true, terminate SSH handshake for clients that do not present valid or any certificates.

[GitHub] rhtyd commented on issue #2278: CLOUDSTACK-9993: With auth strictness stop SSL handshake for rogue clients

2017-09-28 Thread git
rhtyd commented on issue #2278: CLOUDSTACK-9993: With auth strictness stop SSL handshake for rogue clients URL: https://github.com/apache/cloudstack/pull/2278#issuecomment-333047139 @blueorangutan package This is an automate