[GitHub] yvsubhash commented on issue #1762: CLOUDSTACK-9595 Transactions are not getting retried in case of datab?

2017-11-29 Thread GitBox
yvsubhash commented on issue #1762: CLOUDSTACK-9595 Transactions are not getting retried in case of datab? URL: https://github.com/apache/cloudstack/pull/1762#issuecomment-348091947 @serg38 @rafaelweingartner @rhtyd @karuturi @koushik-das please review -

[GitHub] yvsubhash commented on issue #2312: CLOUDSTACK-7793 Create Snaphot with quiesce option set to true fails ?

2017-11-29 Thread GitBox
yvsubhash commented on issue #2312: CLOUDSTACK-7793 Create Snaphot with quiesce option set to true fails ? URL: https://github.com/apache/cloudstack/pull/2312#issuecomment-348091739 @rhtyd there is a test lgtm already from @jahnaviboddu ---

[GitHub] yvsubhash commented on a change in pull request #2102: CLOUDSTACK-9889 Dedication of guest vlan range to a domain

2017-11-29 Thread GitBox
yvsubhash commented on a change in pull request #2102: CLOUDSTACK-9889 Dedication of guest vlan range to a domain URL: https://github.com/apache/cloudstack/pull/2102#discussion_r153992366 ## File path: server/src/com/cloud/api/dispatch/ParamProcessWorker.java ## @@ -145,7

[GitHub] PaulAngus commented on issue #2346: WIP - Add XenServer 7.1 and 7.2 interoperablility

2017-11-29 Thread GitBox
PaulAngus commented on issue #2346: WIP - Add XenServer 7.1 and 7.2 interoperablility URL: https://github.com/apache/cloudstack/pull/2346#issuecomment-348091226 results of test run against XenServer 7.1 Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py Interm

[GitHub] khos2ow commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper

2017-11-29 Thread GitBox
khos2ow commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper URL: https://github.com/apache/cloudstack/pull/2343#issuecomment-348077470 @rafaelweingartner that defeats the whole point of using `mvnw`. And I totally agree we should never check in jar files but this is the only

[GitHub] khos2ow commented on issue #2347: CLOUDSTACK-10166: Get accountId and domainId from VPC when tagging a NetworkACL as a user

2017-11-29 Thread GitBox
khos2ow commented on issue #2347: CLOUDSTACK-10166: Get accountId and domainId from VPC when tagging a NetworkACL as a user URL: https://github.com/apache/cloudstack/pull/2347#issuecomment-348072957 @rafaelweingartner sure will do it tomorrow. Thanks. --

[GitHub] rafaelweingartner commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper

2017-11-29 Thread GitBox
rafaelweingartner commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper URL: https://github.com/apache/cloudstack/pull/2343#issuecomment-348038175 Can't we download that binary (jar file) in the script execution? I agree with @rhtyd, it is not common to version binary files

[GitHub] rafaelweingartner commented on issue #2345: CLOUDSTACK-10164: bugfix allow users to create a VPC through the UI.

2017-11-29 Thread GitBox
rafaelweingartner commented on issue #2345: CLOUDSTACK-10164: bugfix allow users to create a VPC through the UI. URL: https://github.com/apache/cloudstack/pull/2345#issuecomment-348026420 @sgoeminn can you provide a bit more details regarding the problem? Does it only affect 4.10? Specific

[GitHub] rafaelweingartner commented on issue #2347: CLOUDSTACK-10166: Get accountId and domainId from VPC when tagging a NetworkACL as a user

2017-11-29 Thread GitBox
rafaelweingartner commented on issue #2347: CLOUDSTACK-10166: Get accountId and domainId from VPC when tagging a NetworkACL as a user URL: https://github.com/apache/cloudstack/pull/2347#issuecomment-348025504 @khos2ow The only suggestion I would have is the addition of ticket identifier "C

[GitHub] mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage

2017-11-29 Thread GitBox
mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-347985999 Hi @rhtyd - This is essentially ready to go minus a small bit of VMware work around iSCSI dynamic discovery that I've been a

[GitHub] khos2ow opened a new pull request #2347: Get accountId and domainId from VPC when tagging a NetworkACL as a user

2017-11-29 Thread GitBox
khos2ow opened a new pull request #2347: Get accountId and domainId from VPC when tagging a NetworkACL as a user URL: https://github.com/apache/cloudstack/pull/2347 This fixes the issue that a non-root user cannot tag a network ACL item and after the fix a non-root user still cannot tag

[GitHub] blueorangutan commented on issue #2346: WIP - Add XenServer 7.1 and 7.2 interoperablility

2017-11-29 Thread GitBox
blueorangutan commented on issue #2346: WIP - Add XenServer 7.1 and 7.2 interoperablility URL: https://github.com/apache/cloudstack/pull/2346#issuecomment-347939005 Packaging result: ?centos6 ?centos7 ?debian. JID-1322 This i

[GitHub] blueorangutan commented on issue #2346: WIP - Add XenServer 7.1 and 7.2 interoperablility

2017-11-29 Thread GitBox
blueorangutan commented on issue #2346: WIP - Add XenServer 7.1 and 7.2 interoperablility URL: https://github.com/apache/cloudstack/pull/2346#issuecomment-347927464 @PaulAngus a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] PaulAngus commented on issue #2346: WIP - Add XenServer 7.1 and 7.2 interoperablility

2017-11-29 Thread GitBox
PaulAngus commented on issue #2346: WIP - Add XenServer 7.1 and 7.2 interoperablility URL: https://github.com/apache/cloudstack/pull/2346#issuecomment-347927346 @blueorangutan package This is an automated message from the Apa

[GitHub] PaulAngus opened a new pull request #2346: WIP - Add XenServer 7.1 and 7.2 interoperablility

2017-11-29 Thread GitBox
PaulAngus opened a new pull request #2346: WIP - Add XenServer 7.1 and 7.2 interoperablility URL: https://github.com/apache/cloudstack/pull/2346 Add XenServer 7.1 and 7.2 interoperablility - pt 1 add hypervisor to capabilities list and add guest OS mappings (copied from 7.0.0 mappings i

[GitHub] marcaurele commented on issue #2247: CLOUDSTACK-10012: Load SQL schema scripts from JAR

2017-11-29 Thread GitBox
marcaurele commented on issue #2247: CLOUDSTACK-10012: Load SQL schema scripts from JAR URL: https://github.com/apache/cloudstack/pull/2247#issuecomment-347923336 @rhtyd `cloud-setup-databases` is good to go as it is since I left the SQL files in `setup/db` directory to create the schema.

[cloudstack] branch master updated: Revert "add XenServer base 7.1 and 7.2 capabilities to database"

2017-11-29 Thread paul_a
This is an automated email from the ASF dual-hosted git repository. paul_a pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new e2aee99 Revert "add XenServer base 7.1 and

[cloudstack] branch master updated: add XenServer base 7.1 and 7.2 capabilities to database

2017-11-29 Thread paul_a
This is an automated email from the ASF dual-hosted git repository. paul_a pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 1421a6e add XenServer base 7.1 and 7.2 capa

[GitHub] sgoeminn opened a new pull request #2345: CLOUDSTACK-10164: allow users to create a VPC through the UI.

2017-11-29 Thread GitBox
sgoeminn opened a new pull request #2345: CLOUDSTACK-10164: allow users to create a VPC through the UI. URL: https://github.com/apache/cloudstack/pull/2345 https://issues.apache.org/jira/browse/CLOUDSTACK-10164 This is an

[GitHub] khos2ow commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper

2017-11-29 Thread GitBox
khos2ow commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper URL: https://github.com/apache/cloudstack/pull/2343#issuecomment-347904651 IMO It's not just replacing one tool with another, it: - requires less dependency to packages installed on ones machine, given that t

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-11-29 Thread GitBox
blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-347898519 Packaging result: ?centos6 ?centos7 ?debian. JID-1321 Th

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-11-29 Thread GitBox
rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r153797429 ## File path: tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.sh ## @@

[cloudstack] branch debian9-systemvmtemplate updated (f449c77 -> d4ad866)

2017-11-29 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a change to branch debian9-systemvmtemplate in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from f449c77 remove inserv, rearrange pkgs new ff94807 remove old dead code/files new

[cloudstack] 02/02: refactor files, remove old cruft

2017-11-29 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch debian9-systemvmtemplate in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit d4ad8663d435b45c43d1d052dbb97fa251496bef Author: Rohit Yadav AuthorDate: Wed Nov 29 18:37:56 201

[cloudstack] 01/02: remove old dead code/files

2017-11-29 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch debian9-systemvmtemplate in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit ff948079b04fb3e9a9a4c19d57190982e160d3e8 Author: Rohit Yadav AuthorDate: Wed Nov 29 18:01:36 201

[GitHub] resmo commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

2017-11-29 Thread GitBox
resmo commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r153780314 ## File path: tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.sh ## @@

[cloudstack] branch debian9-systemvmtemplate updated: remove inserv, rearrange pkgs

2017-11-29 Thread bhaisaab
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch debian9-systemvmtemplate in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/debian9-systemvmtemplate by this push: new f449c

[GitHub] blueorangutan commented on issue #2342: CLOUDSTACK-9586: Adding local storage test

2017-11-29 Thread GitBox
blueorangutan commented on issue #2342: CLOUDSTACK-9586: Adding local storage test URL: https://github.com/apache/cloudstack/pull/2342#issuecomment-347810372 Packaging result: ?centos6 ?centos7 ?debian. JID-1320 This is an au

[GitHub] blueorangutan commented on issue #2344: CLOUDSTACK-10163: Component tests sanity

2017-11-29 Thread GitBox
blueorangutan commented on issue #2344: CLOUDSTACK-10163: Component tests sanity URL: https://github.com/apache/cloudstack/pull/2344#issuecomment-347805484 @borisstoyanov I understand these words: "help", "hello", "thanks", "package", "test" Test command usage: test [mgmt os] [hypervisor

[GitHub] borisstoyanov commented on issue #2344: CLOUDSTACK-10163: Component tests sanity

2017-11-29 Thread GitBox
borisstoyanov commented on issue #2344: CLOUDSTACK-10163: Component tests sanity URL: https://github.com/apache/cloudstack/pull/2344#issuecomment-347805307 @blueorangutan help This is an automated message from the Apache G

[GitHub] blueorangutan commented on issue #2342: CLOUDSTACK-9586: Adding local storage test

2017-11-29 Thread GitBox
blueorangutan commented on issue #2342: CLOUDSTACK-9586: Adding local storage test URL: https://github.com/apache/cloudstack/pull/2342#issuecomment-347801021 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] borisstoyanov commented on issue #2342: CLOUDSTACK-9586: Adding local storage test

2017-11-29 Thread GitBox
borisstoyanov commented on issue #2342: CLOUDSTACK-9586: Adding local storage test URL: https://github.com/apache/cloudstack/pull/2342#issuecomment-347800821 @blueorangutan package This is an automated message from the Apache

[GitHub] blueorangutan commented on issue #2344: CLOUDSTACK-10163: Component tests sanity

2017-11-29 Thread GitBox
blueorangutan commented on issue #2344: CLOUDSTACK-10163: Component tests sanity URL: https://github.com/apache/cloudstack/pull/2344#issuecomment-347799915 Packaging result: ?centos6 ?centos7 ?debian. JID-1319 This is an autom

[GitHub] marcaurele commented on issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request to check file size from a URL

2017-11-29 Thread GitBox
marcaurele commented on issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request to check file size from a URL URL: https://github.com/apache/cloudstack/pull/1934#issuecomment-347795482 @wido improvement added on `GET`

[GitHub] borisstoyanov commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis

2017-11-29 Thread GitBox
borisstoyanov commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis URL: https://github.com/apache/cloudstack/pull/2263#issuecomment-347792103 yes, allocation_state is failing, looking at it now.. -

[GitHub] rhtyd commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis

2017-11-29 Thread GitBox
rhtyd commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis URL: https://github.com/apache/cloudstack/pull/2263#issuecomment-347790427 @borisstoyanov fair enough, can you look at one of the Travis job failures? ---

[GitHub] rhtyd commented on a change in pull request #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis

2017-11-29 Thread GitBox
rhtyd commented on a change in pull request #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis URL: https://github.com/apache/cloudstack/pull/2263#discussion_r153719450 ## File path: test/integration/component/test_organization_states.py ## @@ -

[GitHub] rhtyd commented on issue #2342: CLOUDSTACK-9586: Adding local storage test

2017-11-29 Thread GitBox
rhtyd commented on issue #2342: CLOUDSTACK-9586: Adding local storage test URL: https://github.com/apache/cloudstack/pull/2342#issuecomment-347787680 Thanks, changes requested @borisstoyanov. Also see if this test case may be clubbed with any existing storagepool related component/smoke tes

[GitHub] rhtyd commented on a change in pull request #2342: CLOUDSTACK-9586: Adding local storage test

2017-11-29 Thread GitBox
rhtyd commented on a change in pull request #2342: CLOUDSTACK-9586: Adding local storage test URL: https://github.com/apache/cloudstack/pull/2342#discussion_r153718234 ## File path: test/integration/component/test_secsr_mount.py ## @@ -0,0 +1,170 @@ +# Licensed to the Apac

[GitHub] blueorangutan commented on issue #2344: CLOUDSTACK-10163: Component tests sanity

2017-11-29 Thread GitBox
blueorangutan commented on issue #2344: CLOUDSTACK-10163: Component tests sanity URL: https://github.com/apache/cloudstack/pull/2344#issuecomment-347787199 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] borisstoyanov commented on issue #2344: CLOUDSTACK-10163: Component tests sanity

2017-11-29 Thread GitBox
borisstoyanov commented on issue #2344: CLOUDSTACK-10163: Component tests sanity URL: https://github.com/apache/cloudstack/pull/2344#issuecomment-347787103 @blueorangutan package This is an automated message from the Apache Gi

[GitHub] rhtyd commented on a change in pull request #2342: CLOUDSTACK-9586: Adding local storage test

2017-11-29 Thread GitBox
rhtyd commented on a change in pull request #2342: CLOUDSTACK-9586: Adding local storage test URL: https://github.com/apache/cloudstack/pull/2342#discussion_r153718109 ## File path: test/integration/component/test_secsr_mount.py ## @@ -0,0 +1,170 @@ +# Licensed to the Apac

[GitHub] borisstoyanov opened a new pull request #2344: CLOUDSTACK-10163: Component tests sanity

2017-11-29 Thread GitBox
borisstoyanov opened a new pull request #2344: CLOUDSTACK-10163: Component tests sanity URL: https://github.com/apache/cloudstack/pull/2344 I've fixed quite a few component tests, most of them should pass now. This is an aut

[GitHub] rhtyd commented on a change in pull request #2342: CLOUDSTACK-9586: Adding local storage test

2017-11-29 Thread GitBox
rhtyd commented on a change in pull request #2342: CLOUDSTACK-9586: Adding local storage test URL: https://github.com/apache/cloudstack/pull/2342#discussion_r153717941 ## File path: test/integration/component/test_secsr_mount.py ## @@ -0,0 +1,170 @@ +# Licensed to the Apac

[GitHub] rhtyd commented on a change in pull request #2342: CLOUDSTACK-9586: Adding local storage test

2017-11-29 Thread GitBox
rhtyd commented on a change in pull request #2342: CLOUDSTACK-9586: Adding local storage test URL: https://github.com/apache/cloudstack/pull/2342#discussion_r153717879 ## File path: test/integration/component/test_secsr_mount.py ## @@ -0,0 +1,170 @@ +# Licensed to the Apac

[GitHub] rhtyd commented on a change in pull request #2342: CLOUDSTACK-9586: Adding local storage test

2017-11-29 Thread GitBox
rhtyd commented on a change in pull request #2342: CLOUDSTACK-9586: Adding local storage test URL: https://github.com/apache/cloudstack/pull/2342#discussion_r153717628 ## File path: test/integration/component/test_secsr_mount.py ## @@ -0,0 +1,170 @@ +# Licensed to the Apac

[GitHub] rhtyd commented on a change in pull request #2342: CLOUDSTACK-9586: Adding local storage test

2017-11-29 Thread GitBox
rhtyd commented on a change in pull request #2342: CLOUDSTACK-9586: Adding local storage test URL: https://github.com/apache/cloudstack/pull/2342#discussion_r153717468 ## File path: test/integration/component/test_secsr_mount.py ## @@ -0,0 +1,170 @@ +# Licensed to the Apac

[GitHub] rhtyd commented on a change in pull request #2342: CLOUDSTACK-9586: Adding local storage test

2017-11-29 Thread GitBox
rhtyd commented on a change in pull request #2342: CLOUDSTACK-9586: Adding local storage test URL: https://github.com/apache/cloudstack/pull/2342#discussion_r153717272 ## File path: test/integration/component/test_secsr_mount.py ## @@ -0,0 +1,170 @@ +# Licensed to the Apac

[GitHub] rhtyd commented on a change in pull request #2342: CLOUDSTACK-9586: Adding local storage test

2017-11-29 Thread GitBox
rhtyd commented on a change in pull request #2342: CLOUDSTACK-9586: Adding local storage test URL: https://github.com/apache/cloudstack/pull/2342#discussion_r153717272 ## File path: test/integration/component/test_secsr_mount.py ## @@ -0,0 +1,170 @@ +# Licensed to the Apac

[GitHub] rhtyd commented on a change in pull request #2342: CLOUDSTACK-9586: Adding local storage test

2017-11-29 Thread GitBox
rhtyd commented on a change in pull request #2342: CLOUDSTACK-9586: Adding local storage test URL: https://github.com/apache/cloudstack/pull/2342#discussion_r153717132 ## File path: test/integration/component/test_secsr_mount.py ## @@ -0,0 +1,170 @@ +# Licensed to the Apac

[GitHub] marcaurele commented on issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request to check file size from a URL

2017-11-29 Thread GitBox
marcaurele commented on issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request to check file size from a URL URL: https://github.com/apache/cloudstack/pull/1934#issuecomment-347785481 @wido ok, then I'll improve it to calculate the content size in case of a GET request based on th

[GitHub] wido commented on issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request to check file size from a URL

2017-11-29 Thread GitBox
wido commented on issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request to check file size from a URL URL: https://github.com/apache/cloudstack/pull/1934#issuecomment-347784289 Code LGTM With one side-note though. I still see a lot of webservers not sending Content-Length

[GitHub] borisstoyanov commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis

2017-11-29 Thread GitBox
borisstoyanov commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis URL: https://github.com/apache/cloudstack/pull/2263#issuecomment-347783762 @rhtyd it's the allocation_state.py that it's failing, let have a quick look. As far as organization_st