[GitHub] blueorangutan commented on issue #2426: CLOUDSTACK-10236: Enable dynamic roles for missing props file

2018-01-23 Thread GitBox
blueorangutan commented on issue #2426: CLOUDSTACK-10236: Enable dynamic roles for missing props file URL: https://github.com/apache/cloudstack/pull/2426#issuecomment-360049690 Trillian test result (tid-2185) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total

[GitHub] marcaurele commented on issue #2422: checkstyle: add package name declaration validation

2018-01-23 Thread GitBox
marcaurele commented on issue #2422: checkstyle: add package name declaration validation URL: https://github.com/apache/cloudstack/pull/2422#issuecomment-360049879 Relating to #2417 too This is an automated message from the

[GitHub] resmo commented on issue #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on restart

2018-01-23 Thread GitBox
resmo commented on issue #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on restart URL: https://github.com/apache/cloudstack/pull/2427#issuecomment-360049628 I am skeptical, at the first view, are the "old" valid entries rewritten?

[GitHub] resmo commented on issue #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on restart

2018-01-23 Thread GitBox
resmo commented on issue #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on restart URL: https://github.com/apache/cloudstack/pull/2427#issuecomment-360049628 I am skeptical, at the first view, are the "old" entries rewritten?

[GitHub] resmo commented on a change in pull request #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on restart

2018-01-23 Thread GitBox
resmo commented on a change in pull request #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on restart URL: https://github.com/apache/cloudstack/pull/2427#discussion_r163473116 ## File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py ## @@ -49,15 +49,21 @@ def

[GitHub] yvsubhash commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules

2018-01-23 Thread GitBox
yvsubhash commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-360038640 @rhtyd can you please re-run tests on this as there is a test LGTM already

[GitHub] blueorangutan commented on issue #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on restart

2018-01-23 Thread GitBox
blueorangutan commented on issue #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on restart URL: https://github.com/apache/cloudstack/pull/2427#issuecomment-360023078 Trillian test result (tid-2186) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] nvazquez commented on issue #2420: CLOUDSTACK-10247: L2 network not shared on projects

2018-01-23 Thread GitBox
nvazquez commented on issue #2420: CLOUDSTACK-10247: L2 network not shared on projects URL: https://github.com/apache/cloudstack/pull/2420#issuecomment-359877998 Thanks @borisstoyanov! @DaanHoogland @rhtyd can you review?

[GitHub] blueorangutan commented on issue #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on restart

2018-01-23 Thread GitBox
blueorangutan commented on issue #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on restart URL: https://github.com/apache/cloudstack/pull/2427#issuecomment-359932309 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] rhtyd commented on issue #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on restart

2018-01-23 Thread GitBox
rhtyd commented on issue #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on restart URL: https://github.com/apache/cloudstack/pull/2427#issuecomment-359932021 @blueorangutan test This is an automated message from the

[GitHub] blueorangutan commented on issue #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on restart

2018-01-23 Thread GitBox
blueorangutan commented on issue #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on restart URL: https://github.com/apache/cloudstack/pull/2427#issuecomment-359931711 Packaging result: ?centos6 ?centos7 ?debian. JID-1674

[GitHub] rhtyd commented on issue #2426: CLOUDSTACK-10236: Enable dynamic roles for missing props file

2018-01-23 Thread GitBox
rhtyd commented on issue #2426: CLOUDSTACK-10236: Enable dynamic roles for missing props file URL: https://github.com/apache/cloudstack/pull/2426#issuecomment-359926620 @blueorangutan test This is an automated message from

[GitHub] blueorangutan commented on issue #2426: CLOUDSTACK-10236: Enable dynamic roles for missing props file

2018-01-23 Thread GitBox
blueorangutan commented on issue #2426: CLOUDSTACK-10236: Enable dynamic roles for missing props file URL: https://github.com/apache/cloudstack/pull/2426#issuecomment-359926699 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] blueorangutan commented on issue #2426: CLOUDSTACK-10236: Enable dynamic roles for missing props file

2018-01-23 Thread GitBox
blueorangutan commented on issue #2426: CLOUDSTACK-10236: Enable dynamic roles for missing props file URL: https://github.com/apache/cloudstack/pull/2426#issuecomment-359926497 Packaging result: ?centos6 ?centos7 ?debian. JID-1673

[GitHub] blueorangutan commented on issue #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on restart

2018-01-23 Thread GitBox
blueorangutan commented on issue #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on restart URL: https://github.com/apache/cloudstack/pull/2427#issuecomment-359924245 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd opened a new pull request #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on restart

2018-01-23 Thread GitBox
rhtyd opened a new pull request #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on restart URL: https://github.com/apache/cloudstack/pull/2427 Delete dnsmasq's leases file when dnsmasq is restarted to avoid it use old ip-mac-address-vm mapping leases. Pinging for review -

[GitHub] blueorangutan commented on issue #2426: CLOUDSTACK-10236: Enable dynamic roles for missing props file

2018-01-23 Thread GitBox
blueorangutan commented on issue #2426: CLOUDSTACK-10236: Enable dynamic roles for missing props file URL: https://github.com/apache/cloudstack/pull/2426#issuecomment-359918394 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd opened a new pull request #2426: CLOUDSTACK-10236: Enable dynamic roles for missing props file

2018-01-23 Thread GitBox
rhtyd opened a new pull request #2426: CLOUDSTACK-10236: Enable dynamic roles for missing props file URL: https://github.com/apache/cloudstack/pull/2426 - In case commands.properties file is missing, enables dynamic roles. - Adds a new -D or --default flag to migrate-dynamicroles.py

[GitHub] rafaelweingartner opened a new pull request #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

2018-01-23 Thread GitBox
rafaelweingartner opened a new pull request #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage URL: https://github.com/apache/cloudstack/pull/2425 CloudStack is logically restricting the migration of local storages to shared storage and vice versa. This

[GitHub] rhtyd commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

2018-01-23 Thread GitBox
rhtyd commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group URL: https://github.com/apache/cloudstack/pull/2418#issuecomment-359900516 LGTM, merging based on test results and reviews. The failing tests were caused by a failure in test_public_ip_range.py

[cloudstack] branch 4.11 updated: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group (#2418)

2018-01-23 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.11 by this push: new f80f00e CLOUDSTACK-10242: Properly parse

[GitHub] rhtyd closed pull request #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

2018-01-23 Thread GitBox
rhtyd closed pull request #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group URL: https://github.com/apache/cloudstack/pull/2418 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] nvazquez commented on issue #2424: CLOUDSTACK-10251: HTTPS downloader for Direct Download templates failure

2018-01-23 Thread GitBox
nvazquez commented on issue #2424: CLOUDSTACK-10251: HTTPS downloader for Direct Download templates failure URL: https://github.com/apache/cloudstack/pull/2424#issuecomment-359892263 Ping for review @borisstoyanov @DaanHoogland @rhtyd

[GitHub] nvazquez opened a new pull request #2424: CLOUDSTACK-10251: HTTPS downloader for Direct Download templates failure

2018-01-23 Thread GitBox
nvazquez opened a new pull request #2424: CLOUDSTACK-10251: HTTPS downloader for Direct Download templates failure URL: https://github.com/apache/cloudstack/pull/2424 JIRA Ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-10251 Failure on HTTPS downloader for Direct Download

[GitHub] blueorangutan commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

2018-01-23 Thread GitBox
blueorangutan commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group URL: https://github.com/apache/cloudstack/pull/2418#issuecomment-359884477 Trillian test result (tid-2184) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total

[GitHub] nvazquez commented on issue #2420: CLOUDSTACK-10247: L2 network not shared on projects

2018-01-23 Thread GitBox
nvazquez commented on issue #2420: CLOUDSTACK-10247: L2 network not shared on projects URL: https://github.com/apache/cloudstack/pull/2420#issuecomment-359877998 Thanks @borisstoyanov! @DaanHoogland @rhtyd can you review?

[GitHub] blueorangutan commented on issue #2405: CLOUDSTACK-10146 checksum in java instead of script

2018-01-23 Thread GitBox
blueorangutan commented on issue #2405: CLOUDSTACK-10146 checksum in java instead of script URL: https://github.com/apache/cloudstack/pull/2405#issuecomment-359869863 Trillian test result (tid-2181) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] blueorangutan commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess

2018-01-23 Thread GitBox
blueorangutan commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess URL: https://github.com/apache/cloudstack/pull/2421#issuecomment-359861520 Trillian test result (tid-2182) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] rhtyd closed pull request #2419: CLOUDSTACK-10245: Fix password server

2018-01-23 Thread GitBox
rhtyd closed pull request #2419: CLOUDSTACK-10245: Fix password server URL: https://github.com/apache/cloudstack/pull/2419 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] rhtyd commented on issue #2419: CLOUDSTACK-10245: Fix password server

2018-01-23 Thread GitBox
rhtyd commented on issue #2419: CLOUDSTACK-10245: Fix password server URL: https://github.com/apache/cloudstack/pull/2419#issuecomment-359844161 Merging this based on test results and code reviews. This is an automated

[GitHub] blueorangutan commented on issue #2419: CLOUDSTACK-10245: Fix password server

2018-01-23 Thread GitBox
blueorangutan commented on issue #2419: CLOUDSTACK-10245: Fix password server URL: https://github.com/apache/cloudstack/pull/2419#issuecomment-359837725 Trillian test result (tid-2183) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 20587

[GitHub] blueorangutan commented on issue #2420: CLOUDSTACK-10247: L2 network not shared on projects

2018-01-23 Thread GitBox
blueorangutan commented on issue #2420: CLOUDSTACK-10247: L2 network not shared on projects URL: https://github.com/apache/cloudstack/pull/2420#issuecomment-359829464 Trillian test result (tid-2180) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] nvazquez opened a new pull request #2423: CLOUDSTACK-10250: Reinstall VM from bypassed registered template

2018-01-23 Thread GitBox
nvazquez opened a new pull request #2423: CLOUDSTACK-10250: Reinstall VM from bypassed registered template URL: https://github.com/apache/cloudstack/pull/2423 JIRA Ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-10250 This fix allows users to restore a VM from a previously

[GitHub] wido commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess

2018-01-23 Thread GitBox
wido commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess URL: https://github.com/apache/cloudstack/pull/2421#issuecomment-359765838 Fine with me @rhtyd ! This is an automated message from the

[GitHub] rhtyd commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess

2018-01-23 Thread GitBox
rhtyd commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess URL: https://github.com/apache/cloudstack/pull/2421#issuecomment-359760381 Thanks for the explanation @wido given this is not a blocker, and we cannot accept this in 4.11.0.0-rc2 based on speculative

[GitHub] rhtyd commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess

2018-01-23 Thread GitBox
rhtyd commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess URL: https://github.com/apache/cloudstack/pull/2421#issuecomment-359760381 Thanks for the explanation @wido given this is not a blocker, and we cannot accept this in 4.11.0.0-rc2 based on speculative

[GitHub] rhtyd closed pull request #2417: [CLOUDSTACK-10248] Fix errors that appeared after #2283

2018-01-23 Thread GitBox
rhtyd closed pull request #2417: [CLOUDSTACK-10248] Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[cloudstack] branch master updated: CLOUDSTACK-10248: Fix errors that appeared after #2283 (#2417)

2018-01-23 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new c591c5a CLOUDSTACK-10248: Fix errors that

[GitHub] rafaelweingartner commented on issue #2417: [CLOUDSTACK-10248] Fix errors that appeared after #2283

2018-01-23 Thread GitBox
rafaelweingartner commented on issue #2417: [CLOUDSTACK-10248] Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359758982 Danke! This is an automated message from the

[GitHub] rhtyd commented on issue #2417: [CLOUDSTACK-10248] Fix errors that appeared after #2283

2018-01-23 Thread GitBox
rhtyd commented on issue #2417: [CLOUDSTACK-10248] Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359758347 Merging this based on code reviews and test results. LGTM. Will merge as soon as Travis is green.

[GitHub] rhtyd commented on issue #2417: [CLOUDSTACK-10248] Fix errors that appeared after #2283

2018-01-23 Thread GitBox
rhtyd commented on issue #2417: [CLOUDSTACK-10248] Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359758347 Merging this based on code reviews and test results. LGTM.

[GitHub] rafaelweingartner commented on issue #2417: [CLOUDSTACK-10248] Fix errors that appeared after #2283

2018-01-23 Thread GitBox
rafaelweingartner commented on issue #2417: [CLOUDSTACK-10248] Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359750258 @rhtyd done. The Jira ticket is: CLOUDSTACK-10248

[GitHub] rafaelweingartner commented on issue #2417: [CLOUDSTACK-10248] Fix errors that appeared after #2283

2018-01-23 Thread GitBox
rafaelweingartner commented on issue #2417: [CLOUDSTACK-10248] Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359750258 @rhtyd done This is an automated message from the

[GitHub] wido commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess

2018-01-23 Thread GitBox
wido commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess URL: https://github.com/apache/cloudstack/pull/2421#issuecomment-359750351 Ok @rhtyd ! The problem is that this doesn't happen on small scale, you need to spawn multiple VMs to run into the issue.

[GitHub] rhtyd commented on issue #2417: Fix errors that appeared after #2283

2018-01-23 Thread GitBox
rhtyd commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359748892 @rafaelweingartner can you share a JIRA id? This is an automated message from the

[GitHub] rhtyd commented on issue #2417: Fix errors that appeared after #2283

2018-01-23 Thread GitBox
rhtyd commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359747635 @rafaelweingartner can we get a JIRA id for this? This is an automated message

[GitHub] rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283

2018-01-23 Thread GitBox
rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359748015 Sure, do you wait before merging? This is an automated message from

[GitHub] rhtyd commented on issue #2417: Fix errors that appeared after #2283

2018-01-23 Thread GitBox
rhtyd commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359747635 @rafaelweingartner can we get a JIRA id for this, or reuse the one used in the previous PR?

[GitHub] rhtyd commented on issue #2417: Fix errors that appeared after #2283

2018-01-23 Thread GitBox
rhtyd commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359747635 LGTM, merging this based on test results and code reviews. Test lgtm, ignorable issue.

[GitHub] blueorangutan commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

2018-01-23 Thread GitBox
blueorangutan commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group URL: https://github.com/apache/cloudstack/pull/2418#issuecomment-359747212 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] rhtyd commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

2018-01-23 Thread GitBox
rhtyd commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group URL: https://github.com/apache/cloudstack/pull/2418#issuecomment-359747181 @blueorangutan test This is an automated message from

[GitHub] rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283

2018-01-23 Thread GitBox
rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359746549 @rhtyd, @DaanHoogland is this one ready to be merge? Or is the error that is presented here is something that I should take a look at?

[GitHub] rhtyd commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess

2018-01-23 Thread GitBox
rhtyd commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess URL: https://github.com/apache/cloudstack/pull/2421#issuecomment-359744736 Thanks @wido I tried to reproduce it, but could n't reproduce the cpu consumption issue. Between 4.10 and 4.11, the

[GitHub] rhtyd commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess

2018-01-23 Thread GitBox
rhtyd commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess URL: https://github.com/apache/cloudstack/pull/2421#issuecomment-359744736 Thanks @wido I tried to reproduce it, but could n't reproduce the cpu consumption issue. Between 4.10 and 4.11, the

[GitHub] blueorangutan commented on issue #2419: CLOUDSTACK-10245: Fix password server

2018-01-23 Thread GitBox
blueorangutan commented on issue #2419: CLOUDSTACK-10245: Fix password server URL: https://github.com/apache/cloudstack/pull/2419#issuecomment-359744687 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] rhtyd commented on issue #2419: CLOUDSTACK-10245: Fix password server

2018-01-23 Thread GitBox
rhtyd commented on issue #2419: CLOUDSTACK-10245: Fix password server URL: https://github.com/apache/cloudstack/pull/2419#issuecomment-359744424 @blueorangutan test This is an automated message from the Apache Git Service. To

[GitHub] blueorangutan commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess

2018-01-23 Thread GitBox
blueorangutan commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess URL: https://github.com/apache/cloudstack/pull/2421#issuecomment-359737691 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] blueorangutan commented on issue #2405: CLOUDSTACK-10146 checksum in java instead of script

2018-01-23 Thread GitBox
blueorangutan commented on issue #2405: CLOUDSTACK-10146 checksum in java instead of script URL: https://github.com/apache/cloudstack/pull/2405#issuecomment-359737407 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] borisstoyanov commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess

2018-01-23 Thread GitBox
borisstoyanov commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess URL: https://github.com/apache/cloudstack/pull/2421#issuecomment-359737358 @blueorangutan test This is an automated message

[GitHub] borisstoyanov commented on issue #2405: CLOUDSTACK-10146 checksum in java instead of script

2018-01-23 Thread GitBox
borisstoyanov commented on issue #2405: CLOUDSTACK-10146 checksum in java instead of script URL: https://github.com/apache/cloudstack/pull/2405#issuecomment-359737256 @blueorangutan test This is an automated message from the

[GitHub] blueorangutan commented on issue #2405: CLOUDSTACK-10146 checksum in java instead of script

2018-01-23 Thread GitBox
blueorangutan commented on issue #2405: CLOUDSTACK-10146 checksum in java instead of script URL: https://github.com/apache/cloudstack/pull/2405#issuecomment-359734329 Packaging result: ?centos6 ?centos7 ?debian. JID-1672

[GitHub] blueorangutan commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess

2018-01-23 Thread GitBox
blueorangutan commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess URL: https://github.com/apache/cloudstack/pull/2421#issuecomment-359731499 Packaging result: ?centos6 ?centos7 ?debian. JID-1671

[GitHub] blueorangutan commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

2018-01-23 Thread GitBox
blueorangutan commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group URL: https://github.com/apache/cloudstack/pull/2418#issuecomment-359730042 Packaging result: ?centos6 ?centos7 ?debian. JID-1670

[GitHub] blueorangutan commented on issue #2419: CLOUDSTACK-10245: Fix password server

2018-01-23 Thread GitBox
blueorangutan commented on issue #2419: CLOUDSTACK-10245: Fix password server URL: https://github.com/apache/cloudstack/pull/2419#issuecomment-359729415 Packaging result: ?centos6 ?centos7 ?debian. JID-1669 This is an

[GitHub] blueorangutan commented on issue #2405: CLOUDSTACK-10146 checksum in java instead of script

2018-01-23 Thread GitBox
blueorangutan commented on issue #2405: CLOUDSTACK-10146 checksum in java instead of script URL: https://github.com/apache/cloudstack/pull/2405#issuecomment-359724807 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] borisstoyanov commented on issue #2405: CLOUDSTACK-10146 checksum in java instead of script

2018-01-23 Thread GitBox
borisstoyanov commented on issue #2405: CLOUDSTACK-10146 checksum in java instead of script URL: https://github.com/apache/cloudstack/pull/2405#issuecomment-358908779 @blueoranbutan package This is an automated message from

[GitHub] borisstoyanov commented on issue #2405: CLOUDSTACK-10146 checksum in java instead of script

2018-01-23 Thread GitBox
borisstoyanov commented on issue #2405: CLOUDSTACK-10146 checksum in java instead of script URL: https://github.com/apache/cloudstack/pull/2405#issuecomment-359724674 @blueorangutan package This is an automated message from

[GitHub] blueorangutan commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess

2018-01-23 Thread GitBox
blueorangutan commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess URL: https://github.com/apache/cloudstack/pull/2421#issuecomment-359722482 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] borisstoyanov commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess

2018-01-23 Thread GitBox
borisstoyanov commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess URL: https://github.com/apache/cloudstack/pull/2421#issuecomment-359722269 @blueorangutan package This is an automated message

[GitHub] borisstoyanov commented on issue #2420: CLOUDSTACK-10247: L2 network not shared on projects

2018-01-23 Thread GitBox
borisstoyanov commented on issue #2420: CLOUDSTACK-10247: L2 network not shared on projects URL: https://github.com/apache/cloudstack/pull/2420#issuecomment-359721828 @blueorangutan test This is an automated message from the

[GitHub] blueorangutan commented on issue #2420: CLOUDSTACK-10247: L2 network not shared on projects

2018-01-23 Thread GitBox
blueorangutan commented on issue #2420: CLOUDSTACK-10247: L2 network not shared on projects URL: https://github.com/apache/cloudstack/pull/2420#issuecomment-359721943 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] wido commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess

2018-01-23 Thread GitBox
wido commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess URL: https://github.com/apache/cloudstack/pull/2421#issuecomment-359721717 I changed the base against 4.11 @rhtyd If that passes I'll draft a new one for master so that we also fix it there.

[GitHub] rhtyd commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

2018-01-23 Thread GitBox
rhtyd commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group URL: https://github.com/apache/cloudstack/pull/2418#issuecomment-359719151 Test LGTM, merging based on code reviews and test results.

[GitHub] rhtyd commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

2018-01-23 Thread GitBox
rhtyd commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group URL: https://github.com/apache/cloudstack/pull/2418#issuecomment-359720851 @wido please send bugfixes to 4.11 branch, this issue is marked blocker and should be send for 4.11 branch. I've rebased

[GitHub] blueorangutan commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

2018-01-23 Thread GitBox
blueorangutan commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group URL: https://github.com/apache/cloudstack/pull/2418#issuecomment-359721069 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

2018-01-23 Thread GitBox
rhtyd commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group URL: https://github.com/apache/cloudstack/pull/2418#issuecomment-359720851 @wido please send bugfixes to 4.11 branch, this issue is marked blocker and should be send for 4.11 branch. I've rebased

[GitHub] blueorangutan commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess

2018-01-23 Thread GitBox
blueorangutan commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess URL: https://github.com/apache/cloudstack/pull/2421#issuecomment-359720892 Packaging result: ?centos6 ?centos7 ?debian. JID-1668

[GitHub] blueorangutan commented on issue #2420: CLOUDSTACK-10247: L2 network not shared on projects

2018-01-23 Thread GitBox
blueorangutan commented on issue #2420: CLOUDSTACK-10247: L2 network not shared on projects URL: https://github.com/apache/cloudstack/pull/2420#issuecomment-359720778 Packaging result: ?centos6 ?centos7 ?debian. JID-1667

[GitHub] wido commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess

2018-01-23 Thread GitBox
wido commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess URL: https://github.com/apache/cloudstack/pull/2421#issuecomment-359720211 @rhtyd I don't know what the parameters are exactly, I've seen this happen on 4.10 clouds and it's becoming a issue we see

[GitHub] blueorangutan commented on issue #2419: CLOUDSTACK-10245: Fix password server

2018-01-23 Thread GitBox
blueorangutan commented on issue #2419: CLOUDSTACK-10245: Fix password server URL: https://github.com/apache/cloudstack/pull/2419#issuecomment-359719283 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

2018-01-23 Thread GitBox
rhtyd commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group URL: https://github.com/apache/cloudstack/pull/2418#issuecomment-359719151 Test LGTM, merging based on code reviews and test results.

[GitHub] rhtyd commented on issue #2419: CLOUDSTACK-10245: Fix password server

2018-01-23 Thread GitBox
rhtyd commented on issue #2419: CLOUDSTACK-10245: Fix password server URL: https://github.com/apache/cloudstack/pull/2419#issuecomment-359719049 @blueorangutan package This is an automated message from the Apache Git Service.

[GitHub] rhtyd commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess

2018-01-23 Thread GitBox
rhtyd commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess URL: https://github.com/apache/cloudstack/pull/2421#issuecomment-359718678 @wido how do we reproduce a failure or timeout/delay you may have observed, and does this apply for 4.11, if so please change

[GitHub] borisstoyanov commented on issue #2406: CLOUDSTACK-9663 return role on updateRole

2018-01-23 Thread GitBox
borisstoyanov commented on issue #2406: CLOUDSTACK-9663 return role on updateRole URL: https://github.com/apache/cloudstack/pull/2406#issuecomment-359711325 @dhlaluku can you extend the test_dynamicroles.py by adding test for verification of this response? There are some conflicts as

[GitHub] borisstoyanov commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess

2018-01-23 Thread GitBox
borisstoyanov commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess URL: https://github.com/apache/cloudstack/pull/2421#issuecomment-359710341 Thanks for this fix @wido @blueorangutan package

[GitHub] blueorangutan commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess

2018-01-23 Thread GitBox
blueorangutan commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess URL: https://github.com/apache/cloudstack/pull/2421#issuecomment-359710403 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] blueorangutan commented on issue #2420: CLOUDSTACK-10247: L2 network not shared on projects

2018-01-23 Thread GitBox
blueorangutan commented on issue #2420: CLOUDSTACK-10247: L2 network not shared on projects URL: https://github.com/apache/cloudstack/pull/2420#issuecomment-359709774 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] borisstoyanov commented on issue #2420: CLOUDSTACK-10247: L2 network not shared on projects

2018-01-23 Thread GitBox
borisstoyanov commented on issue #2420: CLOUDSTACK-10247: L2 network not shared on projects URL: https://github.com/apache/cloudstack/pull/2420#issuecomment-359709724 @blueorangutan package This is an automated message from