rhtyd closed pull request #2429: CLOUDSTACK-10255: Fix agent logrotate
URL: https://github.com/apache/cloudstack/pull/2429
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.11 by this push:
new 22d6718 CLOUDSTACK-10255: Fix agent logrotate (#
blueorangutan commented on issue #2429: CLOUDSTACK-10255: Fix agent logrotate
URL: https://github.com/apache/cloudstack/pull/2429#issuecomment-360275431
Trillian test result (tid-2190)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 21245 seconds
blueorangutan commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from
bypassed registered template
URL: https://github.com/apache/cloudstack/pull/2423#issuecomment-360251196
Trillian test result (tid-2188)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Tot
DaanHoogland commented on issue #2311: CLOUDSTACK-10134 Optimization of
applying port forwarding rules
URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-360225127
those network tests seem related to the code , @yvsubhash @rhtyd ?
-
blueorangutan commented on issue #2311: CLOUDSTACK-10134 Optimization of
applying port forwarding rules
URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-360223732
Trillian test result (tid-2189)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Tota
DaanHoogland commented on issue #2430: CLOUDSTACK-10239 default provider if
needed
URL: https://github.com/apache/cloudstack/pull/2430#issuecomment-360221834
@rhtyd it does,
@marcaurele I think this is in your toko, not? just did some googling, guess
it is not.
I am not sure of my so
DaanHoogland commented on issue #2430: CLOUDSTACK-10239 default provider if
needed
URL: https://github.com/apache/cloudstack/pull/2430#issuecomment-360221834
@rhtyd it does,
@marcaurele I think this is in your toko, not?
I am not sure of my solution, it fixes backwards compatibility b
DaanHoogland commented on a change in pull request #2430: CLOUDSTACK-10239
default provider if needed
URL: https://github.com/apache/cloudstack/pull/2430#discussion_r163628970
##
File path:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.j
rhtyd commented on issue #2428: CLOUDSTACK-10253: JSON response for
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360220812
@marcaurele can you run test_hostha_simulator.py smoketest against simulator
in your local environment
DaanHoogland commented on a change in pull request #2430: CLOUDSTACK-10239
default provider if needed
URL: https://github.com/apache/cloudstack/pull/2430#discussion_r163628911
##
File path:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.j
rhtyd commented on issue #2428: CLOUDSTACK-10253: JSON response for
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360220812
@marcaurele can you run test_hostha_simulator.py smoketest against simulator
in your local environment
rhtyd commented on issue #2428: CLOUDSTACK-10253: JSON response for
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360220812
@marcaurele can you run test_hostha_simulator.py smoketest against simulator
in your local environment
DaanHoogland commented on a change in pull request #2430: CLOUDSTACK-10239
default provider if needed
URL: https://github.com/apache/cloudstack/pull/2430#discussion_r163628527
##
File path:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapContextFactory.java
###
rhtyd commented on a change in pull request #2430: CLOUDSTACK-10239 default
provider if needed
URL: https://github.com/apache/cloudstack/pull/2430#discussion_r163627668
##
File path:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
##
rhtyd commented on issue #2429: CLOUDSTACK-10255: Fix agent logrotate
URL: https://github.com/apache/cloudstack/pull/2429#issuecomment-360220197
Okay, will move it to 4.11.0 milestone.
This is an automated message from the Apa
rhtyd commented on a change in pull request #2430: CLOUDSTACK-10239 default
provider if needed
URL: https://github.com/apache/cloudstack/pull/2430#discussion_r163627731
##
File path:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
##
rhtyd commented on a change in pull request #2430: CLOUDSTACK-10239 default
provider if needed
URL: https://github.com/apache/cloudstack/pull/2430#discussion_r163627862
##
File path:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapContextFactory.java
##
rhtyd commented on issue #2430: CLOUDSTACK-10239 default provider if needed
URL: https://github.com/apache/cloudstack/pull/2430#issuecomment-360219344
@DaanHoogland does this PR solve the issue (blocker-ish) shared on users@
towards 4.11 RC1?
---
DaanHoogland commented on issue #2429: CLOUDSTACK-10255: Fix agent logrotate
URL: https://github.com/apache/cloudstack/pull/2429#issuecomment-360218607
4.11.0 i concur
This is an automated message from the Apache Git Service.
DaanHoogland opened a new pull request #2430: CLOUDSTACK-10239 default provider
if needed
URL: https://github.com/apache/cloudstack/pull/2430
This is an automated message from the Apache Git Service.
To respond to the messag
blueorangutan commented on issue #2424: CLOUDSTACK-10251: HTTPS downloader for
Direct Download templates failure
URL: https://github.com/apache/cloudstack/pull/2424#issuecomment-360194044
Trillian test result (tid-2187)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server
rhtyd commented on issue #2429: CLOUDSTACK-10255: Fix agent logrotate
URL: https://github.com/apache/cloudstack/pull/2429#issuecomment-360169200
Since this is packaging related issue, clearly causing failures on
logrotation we can consider this towards 4.11.0 milestone. /cc @DaanHoogland
@
rhtyd commented on issue #2429: CLOUDSTACK-10255: Fix agent logrotate
URL: https://github.com/apache/cloudstack/pull/2429#issuecomment-360168220
@blueorangutan test
This is an automated message from the Apache Git Service.
To
blueorangutan commented on issue #2429: CLOUDSTACK-10255: Fix agent logrotate
URL: https://github.com/apache/cloudstack/pull/2429#issuecomment-360168288
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
--
blueorangutan commented on issue #2429: CLOUDSTACK-10255: Fix agent logrotate
URL: https://github.com/apache/cloudstack/pull/2429#issuecomment-360164947
Packaging result: ?centos6 ?centos7 ?debian. JID-1679
This is an automate
blueorangutan commented on issue #2429: CLOUDSTACK-10255: Fix agent logrotate
URL: https://github.com/apache/cloudstack/pull/2429#issuecomment-360156225
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted
as I make progress.
rhtyd commented on issue #2429: CLOUDSTACK-10255: Fix agent logrotate
URL: https://github.com/apache/cloudstack/pull/2429#issuecomment-360156007
@blueorangutan package
This is an automated message from the Apache Git Service.
marcaurele commented on issue #2428: CLOUDSTACK-10253: JSON response for
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360140019
@rhtyd I did, and looked inside the related test code to see if any were
doing any particular che
rhtyd commented on issue #2428: CLOUDSTACK-10253: JSON response for
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360132886
@marcaurele if you scroll down to the test results, every test jobs has this
result table. You want to
marcaurele commented on issue #2428: CLOUDSTACK-10253: JSON response for
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360126226
@rhtyd I see the name of the failed tests but there is no hint on where
exactly it failed. I look
fmaximus opened a new pull request #2429: CLOUDSTACK-10255: Fix agent logrotate
URL: https://github.com/apache/cloudstack/pull/2429
Renamed `cloudstack-agent.logrotate` to `cloudstack-agent.logrotate.in`,
so Ant will run the filterchain while copying.
This made the ant run copy block
rhtyd commented on issue #2428: CLOUDSTACK-10253: JSON response for
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360112649
@marcaurele looks like this will add regression, see Travis failures.
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.
from c591c5a CLOUDSTACK-10248: Fix errors that appeared after #2283 (#2417)
add 3b23d5a CLOUDSTACK-10245: Fix pa
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
commit bc1b5fb98f7febd99ee610e08ffc2bc72526e572
Merge: c591c5a 170b6ce
Author: Rohit Yadav
AuthorDate: Wed Jan 24 13:11:55 2
rhtyd closed pull request #2426: CLOUDSTACK-10236: Enable dynamic roles for
missing props file
URL: https://github.com/apache/cloudstack/pull/2426
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
A
rhtyd commented on issue #2426: CLOUDSTACK-10236: Enable dynamic roles for
missing props file
URL: https://github.com/apache/cloudstack/pull/2426#issuecomment-360111511
Thanks, merging this based on code reviews and test results.
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.11 by this push:
new 170b6ce CLOUDSTACK-10236: Enable dynamic roles f
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-admin.git
The following commit(s) were added to refs/heads/master by this push:
new 079eac0 accounts: update docs on
DaanHoogland commented on a change in pull request #2425: [CLOUDSTACK-10240]
ACS cannot migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#discussion_r163481172
##
File path:
api/src/main/java/org/apache/cloudstack/api/command/admin/storage
blueorangutan commented on issue #2311: CLOUDSTACK-10134 Optimization of
applying port forwarding rules
URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-360097926
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has
been kicked to run smoke tests
DaanHoogland commented on issue #2311: CLOUDSTACK-10134 Optimization of
applying port forwarding rules
URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-360097683
@blueorangutan test
This is an automated messag
greut commented on issue #2428: CLOUDSTACK-10253: JSON response for
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360094250
:+1:
@marcaurele which is already the case for any result obtained within a
`queryAsyncJobResul
marcaurele commented on issue #2428: CLOUDSTACK-10253: JSON response for
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360091310
It changes the JSON output from:
```json
{"success": "true"}
```
to
```json
{"
marcaurele commented on issue #2422: [CLOUDSTACK-10254] checkstyle: add package
name declaration validation
URL: https://github.com/apache/cloudstack/pull/2422#issuecomment-360086212
Having a hard time try to make checkstyle to skip `generated-sources`
directories (first encounter is in `p
rhtyd commented on issue #2426: CLOUDSTACK-10236: Enable dynamic roles for
missing props file
URL: https://github.com/apache/cloudstack/pull/2426#issuecomment-360082799
We've enough code review and test results. I'll wait for @borisstoyanov 's
test results, then we may merge.
rhtyd commented on issue #2426: CLOUDSTACK-10236: Enable dynamic roles for
missing props file
URL: https://github.com/apache/cloudstack/pull/2426#issuecomment-360082799
We've enough code review and test results LGTM. I'll wait for @borisstoyanov
's test results, then we may merge.
---
rhtyd commented on issue #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on
restart
URL: https://github.com/apache/cloudstack/pull/2427#issuecomment-360082506
Thanks, merging this based on code reviews and test results.
T
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.11 by this push:
new 61a5a29 CLOUDSTACK-10252: Delete dnsmasq leases
rhtyd closed pull request #2427: CLOUDSTACK-10252: Delete dnsmasq leases file
on restart
URL: https://github.com/apache/cloudstack/pull/2427
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this
resmo commented on issue #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on
restart
URL: https://github.com/apache/cloudstack/pull/2427#issuecomment-360077587
sounds like a plan.
LGTM
This is an automated message from
blueorangutan commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from
bypassed registered template
URL: https://github.com/apache/cloudstack/pull/2423#issuecomment-360072397
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has
been kicked to run smoke tests
--
borisstoyanov commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from
bypassed registered template
URL: https://github.com/apache/cloudstack/pull/2423#issuecomment-360072178
@blueorangutan test
This is an automated mess
blueorangutan commented on issue #2428: CLOUDSTACK-10253: JSON response for
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360070309
Packaging result: ?centos6 ?centos7 ?debian. JID-1678
blueorangutan commented on issue #2311: CLOUDSTACK-10134 Optimization of
applying port forwarding rules
URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-360067983
Packaging result: ?centos6 ?centos7 ?debian. JID-1677
-
DaanHoogland commented on issue #2427: CLOUDSTACK-10252: Delete dnsmasq leases
file on restart
URL: https://github.com/apache/cloudstack/pull/2427#issuecomment-360067539
Yes, well that bit of code does dnsmasq's job. I think we should merge this
and then find a way to call a release on a s
blueorangutan commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from
bypassed registered template
URL: https://github.com/apache/cloudstack/pull/2423#issuecomment-360066328
Packaging result: ?centos6 ?centos7 ?debian. JID-1676
resmo commented on a change in pull request #2427: CLOUDSTACK-10252: Delete
dnsmasq leases file on restart
URL: https://github.com/apache/cloudstack/pull/2427#discussion_r163486340
##
File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
##
@@ -49,15 +49,21 @@ def process(
rhtyd commented on issue #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on
restart
URL: https://github.com/apache/cloudstack/pull/2427#issuecomment-360063571
@DaanHoogland that's right, the aim of the PR was scoped only to fix the
blocker. Perhaps for 4.11.1+ we can aim to improve cha
borisstoyanov commented on issue #2426: CLOUDSTACK-10236: Enable dynamic roles
for missing props file
URL: https://github.com/apache/cloudstack/pull/2426#issuecomment-360060946
Yes, I'm on it @rhtyd
This is an automated
DaanHoogland commented on a change in pull request #2427: CLOUDSTACK-10252:
Delete dnsmasq leases file on restart
URL: https://github.com/apache/cloudstack/pull/2427#discussion_r163482774
##
File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
##
@@ -49,15 +49,21 @@ def p
rhtyd commented on issue #2426: CLOUDSTACK-10236: Enable dynamic roles for
missing props file
URL: https://github.com/apache/cloudstack/pull/2426#issuecomment-360060400
@borisstoyanov can you help with upgrade related testing?
---
blueorangutan commented on issue #2428: CLOUDSTACK-10253: JSON response for
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360060204
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted
as I make progres
rhtyd commented on issue #2428: CLOUDSTACK-10253: JSON response for
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360059991
This may cause upgrade API compatibility regressions if response is string
than boolean (json type), w
blueorangutan commented on issue #2311: CLOUDSTACK-10134 Optimization of
applying port forwarding rules
URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-360059686
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
--
DaanHoogland commented on issue #2311: CLOUDSTACK-10134 Optimization of
applying port forwarding rules
URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-360059649
@blueorangutan package
This is an automated mes
DaanHoogland commented on a change in pull request #2423: CLOUDSTACK-10250:
Reinstall VM from bypassed registered template
URL: https://github.com/apache/cloudstack/pull/2423#discussion_r163480756
##
File path: server/src/com/cloud/vm/UserVmManagerImpl.java
##
@@ -6100,9 +
blueorangutan commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from
bypassed registered template
URL: https://github.com/apache/cloudstack/pull/2423#issuecomment-360057528
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep
you posted as I make progress.
borisstoyanov commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from
bypassed registered template
URL: https://github.com/apache/cloudstack/pull/2423#issuecomment-360057388
@blueorangutan package
This is an automated m
borisstoyanov commented on issue #2424: CLOUDSTACK-10251: HTTPS downloader for
Direct Download templates failure
URL: https://github.com/apache/cloudstack/pull/2424#issuecomment-360057276
@blueorangutan test
This is an automa
blueorangutan commented on issue #2424: CLOUDSTACK-10251: HTTPS downloader for
Direct Download templates failure
URL: https://github.com/apache/cloudstack/pull/2424#issuecomment-360057311
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has
been kicked to run smoke t
blueorangutan commented on issue #2424: CLOUDSTACK-10251: HTTPS downloader for
Direct Download templates failure
URL: https://github.com/apache/cloudstack/pull/2424#issuecomment-360057153
Packaging result: ?centos6 ?centos7 ?debian. JID-1675
DaanHoogland commented on a change in pull request #2420: CLOUDSTACK-10247: L2
network not shared on projects
URL: https://github.com/apache/cloudstack/pull/2420#discussion_r163479947
##
File path: server/src/com/cloud/network/NetworkModelImpl.java
##
@@ -1637,7 +1637,8 @@
DaanHoogland commented on issue #2402: [CLOUDSTACK-10128] Simplify the search
for host to execute command
URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-360055719
@rafaelweingartner no extra PR please, we will merge forward 4.11 after
merge of any fixes
-
marcaurele opened a new pull request #2428: JSON response for SuccessResponse
as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428
Signed-off-by: Marc-Aur?le Brothier
This is an automated message
rhtyd commented on issue #2427: CLOUDSTACK-10252: Delete dnsmasq leases file on
restart
URL: https://github.com/apache/cloudstack/pull/2427#issuecomment-360054333
@resmo the values from json/dictionary are written on commit.
rhtyd commented on a change in pull request #2427: CLOUDSTACK-10252: Delete
dnsmasq leases file on restart
URL: https://github.com/apache/cloudstack/pull/2427#discussion_r163477509
##
File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
##
@@ -49,15 +49,21 @@ def process(
borisstoyanov commented on issue #2424: CLOUDSTACK-10251: HTTPS downloader for
Direct Download templates failure
URL: https://github.com/apache/cloudstack/pull/2424#issuecomment-360051013
@blueorangutan package
This is an aut
blueorangutan commented on issue #2424: CLOUDSTACK-10251: HTTPS downloader for
Direct Download templates failure
URL: https://github.com/apache/cloudstack/pull/2424#issuecomment-360051197
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep
you posted as I make progres
79 matches
Mail list logo
